The bug is that we don't know why the string is invalid.
Test case:
before
tests/rigctl -r "invalid:123:port" -m 2
Unhandled host=invalid:123:port
Unhandled host=invalid:123:port
after:
tests/rigctl -r "invalid:123:port" -m 2
(no output)
tests/rigctl -r "invalid:123:port" -m 2 -v
parse_hoststr: Unhandled host=invalid:123:port
parse_hoststr: Unhandled host=invalid:123:port
I wrote this one-liner, and then realized I couldn't test it - I have
no systems that do not have pthreads as an integral part - does anybody?
Since <pthread.h> has been a de facto requirement since 4.5, the point may
be moot.
(Update: quick '# mv pthread.h pthread2.h' and it fails)
And are the URLs in README.developer correct? Should they point to github?
Options availables are:
./configure # same as --with-cxx-binding=detect
./configure --with-cxx-binding=detect # build if prerequisites are met
./configure --with-cxx-binding=no # do not build
./configure --without-cxx-binding # do not build
./configure --with-cxx-binding=yes # fail if prerequisites aren't met
Options availables are:
./configure # same as --with-indi=detect
./configure --with-indi=detect # build if prerequisites are met
./configure --with-indi=no # do not build
./configure --without-indi # do not build
./configure --with-indi=yes # fail if prerequisites aren't met
It has several issues:
* these are trace messages so RIG_DEBUG_ERR is inappropriate
* they are in a custom format which doesn't handle end of line chars
* write_block() and read_string() print the same information when
debug level is set to TRACE
Needed to adjust one of the timeouts. Was causing issues on Windows. Also made some changes due to IF command response size being 30, it was erroring out. And last band mapping was a little different on this rig for 2m, 70cm, 4m and Air Band.
If the earlier macro AC_PROG_CXX found a compiler that needs some
arguments, the variable CXX will contain also the arguments, so the
macro AC_CHECK_PROG will try to find a file that doesn't exist
(such as "g++ -std=gnu++11" instead of just "g++").
If AC_PROG_CXX didn't find a compiler, the variable CXX is empty.
At some time, the commented out line check_PROGRAMS removed by this commit was
identical to the line following it, plus testsecurity appended, then they went
out of sync.
The commented out line check_PROGRAMS added by this commit appends testsecurity
in an explicit way.
Nate Bargmann