Nate Bargmann
c51357388c
Merge GitHub PR #1841
2025-08-12 07:04:50 -05:00
Daniele Forsi IU5HKX
3b79b13f6d
Make the tests for set_conf() and get_conf() more meaningful
2025-08-11 23:41:39 +02:00
Daniele Forsi IU5HKX
e2feb1d1d0
Fix "val_len" paramenter for rot_get_conf2() and amp_get_conf2()
...
Thanks to @GeoBaltz.
2025-08-11 23:40:01 +02:00
Daniele Forsi IU5HKX
19dce9dc32
Remove deprecated functions and methods from the bindings
2025-08-11 15:50:10 +02:00
Nate Bargmann
5e13d102af
Merge merge GitHub PR #1840
2025-08-11 08:31:20 -05:00
Daniele Forsi IU5HKX
6dec579144
Replace library functions deprecated in Hamlib
2025-08-11 15:09:49 +02:00
Daniele Forsi IU5HKX
65439c6719
Fix typo
2025-08-11 15:09:37 +02:00
Daniele Forsi IU5HKX
e16f4077e7
Implement the Python bindings and the tests for rig_send_raw()
...
Allows to send either string or bytes and to receive a response
converted to the same datatype. Also the "term" argument can be
of either type (but it can't contain NULs, it's a single char
or byte anyway).
Closes #1624 .
2025-08-11 12:33:49 +02:00
Daniele Forsi IU5HKX
289a3952ce
Change the dummy implementation of rig_send_raw()
...
Makes it more similar to the regular version handling also
the reply and term arguments.
2025-08-11 12:18:50 +02:00
Daniele Forsi IU5HKX
12ec55c3d7
Add missing set_transaction_inactive()
...
Otherwise no other command will be executed afterwards.
2025-08-10 21:39:15 +02:00
Daniele Forsi IU5HKX
5e336b90c1
Improve Doxygen comments
2025-08-10 21:39:09 +02:00
Nate Bargmann
0d1481d86f
Update W32 and W64 build scripts
...
Renaming the lib\gcc directory to lib\gcc-mingw broke the build of
WSJT-X. See (yes, the archive sucks):
https://sourceforge.net/p/hamlib/mailman/message/59215755/
2025-08-10 10:39:54 -05:00
Nate Bargmann
c1aaeba5ac
Merge GitHub PR #1837
2025-08-09 18:43:57 -05:00
Daniele Forsi IU5HKX
221cc512bc
Fix setting antenna number 3 for Yaesu FTDX3000
...
The argument ant_t ant is a bit mask, not a scalar.
Also use the defines instead of magic numbers.
2025-08-09 22:34:12 +02:00
Daniele Forsi IU5HKX
10303d5803
Fix function signature of spectrum_callback()
2025-08-09 18:09:17 +02:00
Daniele Forsi IU5HKX
81cb260670
Fix ptt_callback()
2025-08-09 17:57:18 +02:00
Daniele Forsi IU5HKX
e2214fd2f1
Change .ptt_type to RIG_PTT_RIG for RIG_MODEL_DUMMY
...
With the old value of RIG_PTT_NONE, dummy_get_ptt() and dummy_set_ptt()
were never called because rig_get_ptt() and rig_set_ptt() do check
.ptt_type and return -RIG_ENAVAIL in that case.
Do not change .ptt_type for RIG_MODEL_DUMMY_NOVFO so that both cases
can be tested if needed.
2025-08-09 15:57:45 +02:00
Daniele Forsi IU5HKX
2890da9d79
Split the tests
...
It makes it easier in future to conditionally run some tests(eg.
to not test PTT for receiver-only rigs), or to run tests in
isolation (after renaming them).
It makes it easier to look at failing tests because pytest prints
the code of the failing test up to the failure including any
function that called the failed test (in this case would print
everything from def test_with_open() up to the line with the
failed assert.
2025-08-09 15:57:45 +02:00
Daniele Forsi IU5HKX
8e4bcbcede
Add another cross-reference in a Doxygen comment
2025-08-09 15:57:40 +02:00
Daniele Forsi IU5HKX
9e1c7b5ec1
Allocate zereod memory for struct python_callbacks
...
Otherwise Py_XDECREF() would randomly segfault trying to use
uninitialized memory that by chance is not zeroed.
2025-08-09 10:33:54 +02:00
Daniele Forsi IU5HKX
3bc1cc8744
Implement remaining event callbacks
...
Implements:
rig_set_dcd_callback(), rig_set_freq_callback(), rig_set_mode_callback(),
rig_pltune_callback(), rig_set_ptt_callback(), rig_set_spectrum_callback(),
rig_set_vfo_callback()
2025-08-09 10:33:51 +02:00
Daniele Forsi IU5HKX
8324c85487
Implement the Python callback for freq_event
...
Fixes #481 .
2025-08-09 10:33:17 +02:00
Daniele Forsi IU5HKX
2462ab0a13
Improve Doxygen comments
...
Adds missing cross-references. Fix tagging of comment blocks in "aor"
even if the rigs aren't included in the generated documentation.
2025-08-08 10:38:55 +02:00
Nate Bargmann
93a24356e5
Merge GitHub PR #1831
2025-08-07 07:26:47 -05:00
Daniele Forsi IU5HKX
891070941f
Fix compiler warnings
...
Fixes:
simic905.c:108:9: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
simic910.c:112:9: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
2025-08-07 14:14:58 +02:00
Daniele Forsi IU5HKX
5b1517778e
Replace "goto again" with "continue" (third case)
...
When the software on the other side of the pty closes the device,
the simulator would close and reopen its side but it is unneeded
because it can continue to call read() without doing anything special.
2025-08-07 11:38:12 +02:00
Daniele Forsi IU5HKX
8887294cd8
Replace "goto again" with "continue" (second case)
...
Does the same thing with more structured control flow.
It also silences compiler warnings.
2025-08-07 11:22:44 +02:00
Daniele Forsi IU5HKX
5b87b38704
Replace "goto again" with "continue" (first case)
...
Does the same thing with more structured control flow.
It also silences compiler warnings.
2025-08-07 11:22:14 +02:00
Daniele Forsi IU5HKX
4251c50b7f
Fix reading line when the client (eg. rigctl) closes
...
Fixes an infinite stream of debug output because it erroneously
appeared to have read 1 byte instead of 0:
n=1
00
Not 8 bytes? bytes=1
Unknown cmd=00
Tested with:
tests/rigctl -m 37001 -r /dev/pts/6 f
(however it doesn't read the frequency because it looks like the
protocol is different or incomplete, rigs/anytone/d578.c is still
in beta)
2025-08-07 08:54:09 +02:00
Daniele Forsi IU5HKX
49c78edb80
Make code more uniform
2025-08-06 21:49:17 +02:00
George Baltz N3GB
70d50d0efb
Fix one byte buffer overrun
...
All the pictures in manuals show message as 4 bytes, but they don't
include the major command (0x26).
Found by `gcc -fanalyzer`
2025-08-06 05:13:25 -04:00
George Baltz N3GB
1e5adb9fde
Fix errors in error cases
...
Leak FDs in error exits, seg faults if RIG missing.
Found by `gcc -fanalyzer`
2025-08-06 04:56:02 -04:00
Daniele Forsi IU5HKX
59acdb791e
Fix compiler warning
...
Move both initialization outside of the conditional.
Fixes:
simyaesu.c:364:12: warning: ‘pbuf’ may be used uninitialized [-Wmaybe-uninitialized]
2025-08-06 09:34:04 +02:00
Daniele Forsi IU5HKX
032e78826e
Fix BC and FO commands
...
The following command work from rigctl: get_freq get_ctcss_tone get_rig_info.
Uses the information from the manual linked at the top of rig/kenwood/tmd710.c.
Fixes:
simtmd710.c:64:44: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘double’ [-Wformat=]
simtmd710.c:68:44: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘double’ [-Wformat=]
2025-08-05 23:46:10 +02:00
Daniele Forsi IU5HKX
d5c5eeff15
No need to use strlen() because the i variable counted the chars read
2025-08-05 22:40:17 +02:00
Daniele Forsi IU5HKX
af4c6ec806
Make the output of simft990 more friendly
2025-08-05 22:40:17 +02:00
Daniele Forsi IU5HKX
9dd0009f9e
Remove unused define
2025-08-05 22:22:50 +02:00
Daniele Forsi IU5HKX
816d6d9bef
Replace magic number with a defined constant
2025-08-05 22:22:50 +02:00
Daniele Forsi IU5HKX
249a993633
Avoid spamming the terminal with 0's
2025-08-05 22:22:50 +02:00
Daniele Forsi IU5HKX
8064da8121
Avoid burning 100% CPU
...
Adds hl_usleep() like in the other version of getmyline().
2025-08-05 21:16:33 +02:00
Daniele Forsi IU5HKX
d9532a9c62
Fix compiler warning
...
Fixes:
simft990.c:64:36: warning: pointer targets in passing argument 2 of ‘getmyline5’ differ in signedness [-Wpointer-sign]
2025-08-05 20:51:04 +02:00
Daniele Forsi IU5HKX
f691a68c06
Fix compiler warning
...
Fixes:
simft990.c:39:16: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
2025-08-05 20:38:57 +02:00
Daniele Forsi IU5HKX
725fcee004
Fix compiler warning
...
Fixes:
simatd578.c:143:9: warning: ‘n’ may be used uninitialized [-Wmaybe-uninitialized]
2025-08-05 20:22:41 +02:00
George Baltz N3GB
96bc67d993
Fix FD leak in AESStringCrypt.c
...
Found by `gcc -fanalyzer`, which then spent the next 20+ minutes trying to
analyze md5.c, at which point I gave up.
2025-08-05 11:33:00 -04:00
George Baltz N3GB
c26113c5cc
Fix more cppcheck messages
...
Suppress non-errors in rx331.c and rx340.c
Mark runflag(s) as volatile
2025-08-04 18:43:39 -04:00
George Baltz N3GB
c1132a77b5
Mark cache structure in rig_state as deprecated.
...
It is no longer being initialized or updated, so anyone referencing it
is being misled.
2025-08-04 10:24:15 -04:00
George Baltz N3GB
c1e6dcf010
More cppcheck stuff in amplifiers/ and rotators/
2025-08-04 09:59:23 -04:00
George Baltz N3GB
8ce51d13aa
Update Kenwood max CW message size.
2025-08-04 09:59:23 -04:00
Nate Bargmann
1e310b7958
Merge GitHub PR #1828
2025-08-04 08:04:15 -05:00
Nate Bargmann
c881bc7132
Merge GitHub PR #1827
2025-08-04 07:49:28 -05:00