Daniele Forsi IU5HKX
725fcee004
Fix compiler warning
...
Fixes:
simatd578.c:143:9: warning: ‘n’ may be used uninitialized [-Wmaybe-uninitialized]
2025-08-05 20:22:41 +02:00
George Baltz N3GB
96bc67d993
Fix FD leak in AESStringCrypt.c
...
Found by `gcc -fanalyzer`, which then spent the next 20+ minutes trying to
analyze md5.c, at which point I gave up.
2025-08-05 11:33:00 -04:00
George Baltz N3GB
c26113c5cc
Fix more cppcheck messages
...
Suppress non-errors in rx331.c and rx340.c
Mark runflag(s) as volatile
2025-08-04 18:43:39 -04:00
George Baltz N3GB
c1132a77b5
Mark cache structure in rig_state as deprecated.
...
It is no longer being initialized or updated, so anyone referencing it
is being misled.
2025-08-04 10:24:15 -04:00
George Baltz N3GB
c1e6dcf010
More cppcheck stuff in amplifiers/ and rotators/
2025-08-04 09:59:23 -04:00
George Baltz N3GB
8ce51d13aa
Update Kenwood max CW message size.
2025-08-04 09:59:23 -04:00
Nate Bargmann
1e310b7958
Merge GitHub PR #1828
2025-08-04 08:04:15 -05:00
Nate Bargmann
c881bc7132
Merge GitHub PR #1827
2025-08-04 07:49:28 -05:00
Daniele Forsi IU5HKX
151549bb3b
Remove disabled code
...
None of these simulators does multicast networking.
2025-08-04 11:36:03 +02:00
Daniele Forsi IU5HKX
790820ab22
Refactor to remove code duplication of one version of getmyline()
2025-08-04 11:36:03 +02:00
Daniele Forsi IU5HKX
b809937395
Rename in preparation of conflicting changes
2025-08-04 11:36:03 +02:00
Daniele Forsi IU5HKX
498b45f5b0
Rename in preparation of conflicting changes
2025-08-04 11:36:03 +02:00
Daniele Forsi IU5HKX
a5467f4033
Refactor to remove code duplication of one version of getmyline()
2025-08-04 11:34:00 +02:00
Daniele Forsi IU5HKX
10f6504897
Remove disabled code and change signature
...
Makes getmyline() identical to the other simulators.
2025-08-04 11:32:26 +02:00
jeremybox
8ccc197b7c
ftx1: implement tuning step functionality and cleanup
...
- Add ftx1_get_ts() and ftx1_set_ts() functions using EX0306 commands
- Support mode-specific tuning step values:
* SSB/CW & RTTY/PSK: 5Hz, 10Hz, 20Hz
* FM: 5kHz, 6.25kHz, 10kHz, 12.5kHz, 20kHz, 25kHz, Auto
- Remove unused functions: ftx1_handle_cat_error, ftx1_get_split, ftx1_set_split
- Remove unused variable in ftx1_set_freq
- Update header file to remove unused function declarations
- Fix format specifiers (%d -> %ld) for shortfreq_t type
Tested with real FTX-1 hardware using rigctl commands.
Tuning step functionality verified in LSB mode with 20Hz step.
2025-08-03 20:52:29 -04:00
jeremybox
182597ebc4
Clean up unused functions in FTX-1 driver
...
- Remove unused ftx1_handle_cat_error function
- Remove unused ftx1_get_split and ftx1_set_split functions
- Remove unused variable 'err' in ftx1_set_freq
- Remove corresponding function declarations from ftx1.h
- Eliminates all compiler warnings for clean build
2025-08-03 18:20:06 -04:00
Daniele Forsi IU5HKX
f8881f9bb9
Remove disabled code
...
None of these simulators does multicast networking.
2025-08-03 22:09:04 +02:00
Daniele Forsi IU5HKX
9e51419ab8
Do not use relative paths for including rig.h
...
The Makefile adds all necessary include directories.
2025-08-03 16:09:51 +02:00
Daniele Forsi IU5HKX
c26f033395
Do not use relative paths for including misc.h
...
The Makefile adds all necessary include directories.
2025-08-03 16:09:47 +02:00
Daniele Forsi IU5HKX
fbe9803777
Fix initialization of comm_status
...
The function rig_init() doesn't touch the hardware, it's rig_open()
that initiates the connection and in fact the first use of comm_status
in rig_open() is when it gets the value RIG_COMM_STATUS_CONNECTING and
rig_close() sets it to RIG_COMM_STATUS_DISCONNECTED.
2025-08-03 13:34:36 +02:00
Daniele Forsi IU5HKX
8d8d0328bf
Fix typos
2025-08-03 10:49:23 +02:00
Daniele Forsi IU5HKX
99df93067c
Add a .gitignore for C++ tests
2025-08-03 09:35:03 +02:00
Daniele Forsi IU5HKX
f89ebfd226
Add include missed by IWYU
2025-08-03 09:35:03 +02:00
Daniele Forsi IU5HKX
df7fbbec9b
Have IWYU fix the includes
2025-08-03 09:35:03 +02:00
Daniele Forsi IU5HKX
3b2a95053b
Refactor to remove code duplication of dumphex()
2025-08-03 09:35:03 +02:00
Daniele Forsi IU5HKX
1568a6c7fc
Refactor to remove code duplication of typedef enum nc_rigid_e
...
Also updates nc_rigid_e from rigs/yaesu/newcat.c
There where different versions of that enum in the simulators.
2025-08-03 09:35:03 +02:00
Daniele Forsi IU5HKX
98a81a5074
Replace magic number with a defined constant
...
The same constant is used by memset() in getmyline().
2025-08-03 09:35:03 +02:00
Daniele Forsi IU5HKX
7fc222dc88
Remove perror()
...
Makes getmyline() identical to the other simulators.
2025-08-03 09:35:03 +02:00
Daniele Forsi IU5HKX
ecece62828
Refactor to remove code duplication of openPort()
...
The code wasn't indented in simic7300.c and simic7700.c but it was
identical.
2025-08-03 09:35:02 +02:00
jeremybox
0d079d2338
Restore tests/Makefile.am to match master branch exactly
2025-08-02 22:18:36 -04:00
jeremybox
971ab5e126
Remove test_ftx1 from Makefile to fix build issues
...
- Removed test_ftx1 from check_PROGRAMS list
- Removed test_ftx1_SOURCES definition
- This prevents build failures on systems without the test file
2025-08-02 22:12:46 -04:00
jeremybox
bb070edfa3
Enhanced FTX-1 support with comprehensive improvements
2025-08-02 22:02:05 -04:00
Daniele Forsi IU5HKX
16a69722e2
Use the resp buffer for all responses
...
Insetad of the command buffer.
2025-08-02 16:20:38 +02:00
Daniele Forsi IU5HKX
b5d136ff08
Print responses
2025-08-02 16:01:48 +02:00
Daniele Forsi IU5HKX
f3e2ea9e3d
Avoid printing the received command twice
...
It is printed at the beginning of the while loop.
2025-08-02 15:53:04 +02:00
Daniele Forsi IU5HKX
3009ec86b7
Add a .gitignore for simulators
2025-08-02 15:16:51 +02:00
Daniele Forsi IU5HKX
17b301a371
Add missing includes
...
Automatically added by IWYU.
2025-08-02 13:14:35 +02:00
Daniele Forsi IU5HKX
e8467032ad
Remove unused includes
...
Found with IWYU.
2025-08-02 13:13:10 +02:00
Nate Bargmann
989623ec51
Merge GitHub PR #1824
2025-08-01 18:31:38 -05:00
Nate Bargmann
b4eb1bdb12
Quell warning from clang
...
This warning was seen on MacOS and on Debian 12 and 13 using clang:
CC kenwood.lo
kenwood.c:2293:9: warning: absolute value function 'abs' given an argument of type 'shortfreq_t' (aka 'long') but has parameter of type 'int' which may cause truncation of value [-Wabsolute-value]
2293 | if (abs(rit) > 9999) { RETURNFUNC(-RIG_EINVAL); }
| ^
kenwood.c:2293:9: note: use function 'labs' instead
2293 | if (abs(rit) > 9999) { RETURNFUNC(-RIG_EINVAL); }
| ^~~
| labs
1 warning generated.
Closes issue #1806 on GitHub
2025-08-01 18:25:16 -05:00
Nate Bargmann
a9ecd50329
Sanitize radio model names and manufacturers
...
Reference GitHub issue #1013 .
2025-08-01 07:55:41 -05:00
Daniele Forsi IU5HKX
0c57ccad26
Add missing include file
...
Otherwise it isn't added to the distribution archive created by
"make distcheck".
2025-07-30 23:29:12 +02:00
Daniele Forsi IU5HKX
094b5e741a
Remove unused variables
2025-07-30 23:29:12 +02:00
Daniele Forsi IU5HKX
200b2aaecc
Remove unneeded typedef
...
It's only used by Yeasu simulators.
2025-07-30 23:29:12 +02:00
Daniele Forsi IU5HKX
6af3b3a94e
Remove DECLARE_INITRIG_BACKEND()
...
This code is uneeded.
2025-07-30 23:29:12 +02:00
Daniele Forsi IU5HKX
5f78c54bae
Remove DECLARE_INITRIG_BACKEND()
...
Breaks rig_probe() for rigs probed later (eg. Kenwood).
2025-07-30 23:29:12 +02:00
George Baltz N3GB
b4f0a3b4b3
Update NEWS
2025-07-29 14:04:16 -04:00
George Baltz N3GB
1c36377480
Still more cppcheck tweaks
2025-07-29 13:10:28 -04:00
George Baltz N3GB
72bc62366d
A few more cppcheck messages silenced
2025-07-28 19:31:20 -04:00
Daniele Forsi IU5HKX
f8c3d6b614
Fix error messages
2025-07-28 22:04:18 +02:00