Wykres commitów

2555 Commity (0703598c2f4e4285956b51c718fca604ebfb5174)

Autor SHA1 Wiadomość Data
Eliot Berriot f281189f47 Merge branch '781-remove-tracks-not-found' into 'develop'
Fix #781: Added a `check_inplace_files` management command to remove purge the...

Closes #781

See merge request funkwhale/funkwhale!707
2019-04-05 18:58:17 +02:00
Eliot Berriot 6649d0720d
Fix #781: Added a `check_inplace_files` management command to remove purge the database from references to in-place imported files that don't exist on disk anymore 2019-04-05 18:55:00 +02:00
Eliot Berriot da6b3400a0
Better permissions on .env file, added a few missing env vars in mono-container install 2019-04-05 17:48:04 +02:00
Eliot Berriot 156d9c813a Merge branch '787-broken-follow' into 'develop'
Fix #787: federation issue due to missing error handling

Closes #787

See merge request funkwhale/funkwhale!706
2019-04-05 16:25:37 +02:00
Eliot Berriot f5a6a40d7f
Fix #787: federation issue due to missing error handling 2019-04-05 16:22:32 +02:00
Eliot Berriot 9bf1c0cde0 Merge branch '788-album-error-handling' into 'develop'
Fix #788: fixed crashing import with empty album artist

Closes #788

See merge request funkwhale/funkwhale!705
2019-04-05 15:44:05 +02:00
Eliot Berriot 2a82367667
Fix #788: fixed crashing import with empty album artist 2019-04-05 15:41:28 +02:00
Eliot Berriot 48ce87d25f Merge branch '783-migration-error' into 'develop'
Fix #783: migration issue on develop

Closes #783

See merge request funkwhale/funkwhale!704
2019-04-04 16:08:11 +02:00
Eliot Berriot 47b3b1ae0a Merge branch '718-error-handling' into 'develop'
Resolve "Upload problem due to a formatting error in the date tag"

Closes #718, #583, #501, #252, #544 (yes, that's a lot :D)

So, this MR changes the way we parse audio metadata and handle validation for this data:

- There is now a strict and explicit separation between the retrieve step (extracting raw metadata value from files), and the validation step (ensure the raw metadata is actually valid, convert it to our internal types, etc.)
- The date parsing issue from #718 should be solved (and Funkwhale should not crash anymore against invalid dates, skipping those instead)
- We are now ready to deal with multiple artists at the metadata parsing level (cf !515). It should also be easier to exclude featuring artists now (cf #736), but it's not implemented here
- When invalid metadata makes the import fail, we store the errors on the upload so we can display those to the user
- Tables that list uploads in the Web UI leverage this new data to display more detailed errors and advices, as shown on the screenshot below

## Link to the detail modal

![image](/uploads/20eab969c7cb46fe68a402d8a509815d/image.png)

## Import error detail

![image](/uploads/7cebae6dd05f437345fa38340e8675c7/image.png)

![image](/uploads/946c8ae59cd89fe29e701700fbd5063f/image.png)

As you can see, we display the type of errors, the failing tags and the actual error, as well as some link to the documentation, support forum and some debug info you can easily copy-paste to get help.

See merge request funkwhale/funkwhale!703
2019-04-04 16:07:44 +02:00
Eliot Berriot 05f0129025 Better error handling on display for import errors (#718, #583, #501, #252, #544) 2019-04-04 16:07:43 +02:00
Eliot Berriot 63c3c22534
Fix #783: migration issue on develop 2019-04-04 16:05:34 +02:00
Eliot Berriot 28a5c918cf Merge branch 'eliotberriot-master-patch-07259' into 'master'
Added missing sudo in upgrade instructions

See merge request funkwhale/funkwhale!701
2019-04-01 19:23:07 +02:00
Eliot Berriot 3a4c927820 Added missing sudo in upgrade instructions 2019-04-01 19:20:17 +02:00
Eliot Berriot 524794c81f Merge branch 'tag-data' into 'master'
Added a small json file in documentation to get releases info

See merge request funkwhale/funkwhale!700
2019-04-01 11:41:18 +02:00
Eliot Berriot cf51d37a47
Added a small json file in documentation to get releases info 2019-04-01 11:36:13 +02:00
Eliot Berriot 3a95957dfe Merge branch 'eliotberriot-master-patch-38666' into 'master'
Added missing library_id parameter on in-place import documentation

See merge request funkwhale/funkwhale!699
2019-04-01 09:50:15 +02:00
Eliot Berriot 537f18cf08 Added missing library_id parameter on in-place import documentation 2019-04-01 09:45:54 +02:00
Eliot Berriot 7bb0fa2e64 Merge branch '777-library-pruning' into 'develop'
Fix #777: Added a prune_library management command to remove obsolete metadata

Closes #777

See merge request funkwhale/funkwhale!698
2019-03-27 17:07:23 +01:00
Eliot Berriot 5916a1ba99
Fix #777: Added a prune_library management command to remove obsolete metadata 2019-03-27 17:04:10 +01:00
Eliot Berriot 96010917fb Merge branch 'migration-to-loomio' into 'develop'
Updated forum urls

See merge request funkwhale/funkwhale!697
2019-03-27 13:49:02 +01:00
Eliot Berriot 8a5c85a823 Merge branch 'discard-unhandled-activities' into 'develop'
Fix #776: Don't store unhandled ActivityPub messages in database

Closes #776

See merge request funkwhale/funkwhale!696
2019-03-27 13:46:08 +01:00
Eliot Berriot 9e8c223021
Updated forum urls 2019-03-27 13:45:52 +01:00
Eliot Berriot 583a6ddf08 Merge branch '740-skipped-track-position' into 'develop'
Fix #740: Do not consider tracks as duplicates during import if they have different positions

Closes #740

See merge request funkwhale/funkwhale!695
2019-03-27 12:58:29 +01:00
Eliot Berriot ca7b39c692
Fix #740: Do not consider tracks as duplicates during import if they have different positions 2019-03-27 12:54:29 +01:00
Eliot Berriot 46f1d96206
Fix #776: Don't store unhandled ActivityPub messages in database 2019-03-27 12:53:35 +01:00
Eliot Berriot b9b1e1e26a Merge branch '772-skipped-release' into 'develop'
Fix #772: Prevent skipping on file import if album_mbid is different

Closes #772

See merge request funkwhale/funkwhale!694
2019-03-27 12:16:55 +01:00
Eliot Berriot 31227b8641
Fix #772: Prevent skipping on file import if album_mbid is different 2019-03-27 12:13:25 +01:00
Eliot Berriot 659c355ad8
API doc introduction 2019-03-26 17:21:44 +01:00
Eliot Berriot f8e30736a2 Merge branch 'more-api-docs-again' into 'master'
More api docs again

See merge request funkwhale/funkwhale!693
2019-03-26 17:13:08 +01:00
Eliot Berriot dcb9ca04a1
Documented /users and /auth endpoints 2019-03-26 15:38:14 +01:00
Eliot Berriot 26e8281733 Merge branch 'more-api-docs' into 'master'
More api docs

See merge request funkwhale/funkwhale!692
2019-03-26 15:04:36 +01:00
Eliot Berriot a1817f6473
Documented /listen endpoint 2019-03-26 15:01:19 +01:00
Eliot Berriot 800dd5ba18
Documented /favorites endpoint 2019-03-26 13:58:47 +01:00
Eliot Berriot 5b74448e66
Documented /uploads endpoint 2019-03-26 12:32:04 +01:00
Eliot Berriot 4aabcf8d57
Libraries endpoint documentation 2019-03-26 11:40:53 +01:00
Eliot Berriot d5712ea2fb Merge branch 'revert-5a97dde3' into 'develop'
Revert "Merge branch '769-ci-changes' into 'develop'"

See merge request funkwhale/funkwhale!691
2019-03-26 10:48:58 +01:00
Eliot Berriot 37b878270e Revert "Merge branch '769-ci-changes' into 'develop'"
This reverts merge request !689
2019-03-26 10:45:52 +01:00
Eliot Berriot 5a97dde3dc Merge branch '769-ci-changes' into 'develop'
Fix #769: run CI jobs only when relevant

Closes #769

See merge request funkwhale/funkwhale!689
2019-03-26 10:34:13 +01:00
Eliot Berriot eed8ac009f
Fix #769: run CI jobs only when relevant 2019-03-26 10:30:27 +01:00
Eliot Berriot 86ea3cf4f3 Merge branch '752-funkwhale-oauth-provider' into 'develop'
Resolve "Implement a Oauth provider in Funkwhale"

Closes #752

See merge request funkwhale/funkwhale!672
2019-03-25 17:02:51 +01:00
Eliot Berriot 4c13d47387 Resolve "Implement a Oauth provider in Funkwhale" 2019-03-25 17:02:51 +01:00
Eliot Berriot 1dc7304bd3 Merge branch '768-show-description-of-libraries-in-card' into 'develop'
Resolve "Show 'description' of libraries in card"

See merge request funkwhale/funkwhale!688
2019-03-22 09:41:35 +01:00
Ciarán Ainsworth 6e20f63f09 Resolve "Show 'description' of libraries in card" 2019-03-22 09:41:35 +01:00
Eliot Berriot eae337d4ed
Merge branch 'master' into develop 2019-03-21 11:31:16 +01:00
Eliot Berriot 65dd21d1a3
Fixed formatting issue in changelog 2019-03-21 11:30:41 +01:00
Eliot Berriot 1cedddf533
Fixed duplicated section in CONTRIBUTING 2019-03-21 10:49:07 +01:00
Eliot Berriot e587e5aebc
Merge branch 'master' into develop 2019-03-21 10:46:28 +01:00
Eliot Berriot 78734a86e3
Merge branch 'release/0.18.3' 2019-03-21 10:41:29 +01:00
Eliot Berriot c196016035
Version bump and changelog for 0.18.3 2019-03-21 10:41:14 +01:00
Eliot Berriot b49720caf5 Merge branch '570-inplace-quota' into 'master'
Fix #570: Exclude in-place imported files from quota computation

See merge request funkwhale/funkwhale!687
2019-03-21 10:35:01 +01:00