Daniele Forsi IU5HKX
caf7346fc0
Fix typos
2025-08-16 11:52:55 +02:00
George Baltz N3GB
1e5adb9fde
Fix errors in error cases
...
Leak FDs in error exits, seg faults if RIG missing.
Found by `gcc -fanalyzer`
2025-08-06 04:56:02 -04:00
George Baltz N3GB
c1e6dcf010
More cppcheck stuff in amplifiers/ and rotators/
2025-08-04 09:59:23 -04:00
George Baltz N3GB
1c36377480
Still more cppcheck tweaks
2025-07-29 13:10:28 -04:00
George Baltz N3GB
72bc62366d
A few more cppcheck messages silenced
2025-07-28 19:31:20 -04:00
George Baltz N3GB
faad247f06
Deprecate rot_get_conf()
2025-07-28 10:43:10 -04:00
Daniele Forsi IU5HKX
0267068220
Fix ambiguity between system includes and Hamlib includes
2025-07-22 23:33:57 +02:00
Daniele Forsi IU5HKX
2fab137fc5
Apply fixes suggested by iwyu
...
Removes unused includes and adds missing includes.
2025-07-22 23:33:57 +02:00
Daniele Forsi IU5HKX
b57ad227a0
Remove unused #include <math.h>
...
Found with iwyu.
2025-07-22 23:33:56 +02:00
Daniele Forsi IU5HKX
974e619dd2
Replace #include serial.h with iofunc.h
...
According to iwyu, to avoid unecessary rebuilds and to reduce the
chances of breakages of the build if includes are rearranged, the
code that uses serial_open() and ser_close() should include
serial.h while the code that uses read_block() write_block() and
similar should include iofunc.h, code that uses all of them should
include both files.
Found with iwyu.
2025-07-22 23:33:56 +02:00
Daniele Forsi IU5HKX
195ed01543
Remove unused #include "serial.h"
...
Found with iwyu.
2025-07-22 23:33:56 +02:00
Michael Morgan
5c06f66aa8
Update gs232.c
...
I don't use that so I added a line to void it to suppress the warning. Hope that is ok.
2025-07-15 14:28:03 -05:00
George Baltz N3GB
f3e9a859ed
Move ???PORT() macro definitions back to rig.h
...
Many (most?) of the uses of the port structures in Hamlib are to pass through
to the basic I/O routines (rig_flush(), write_block(), read_string()),
without referencing any of the structure data. Don't bother including
port.h if it won't be used.
The ???PORT macros are independent of actual hamlib_port_t data use.
2025-07-10 09:54:03 -04:00
George Baltz N3GB
213e7751bf
Add needed includes of new files to rotators/*/*
2025-07-10 09:54:03 -04:00
Michael Morgan
c2a8ceab2b
Removed Redundant IF
2025-07-09 11:11:02 -05:00
Michael Morgan
e4716be366
Added AF6SA WRC
...
It uses non-standard W command.
2025-07-09 11:11:01 -05:00
Daniele Forsi IU5HKX
976bfb4276
Remove the executable bit from data files
2025-07-06 19:45:43 +02:00
Nate Bargmann
bddd3ace00
Revert 17b404a6c7
...
These changes were unnecessary as the real bug is that the incorrect
function was being called in meade.c.
Closes GitHub issue #268 .
Fix testloc.c
2025-06-14 11:42:45 -05:00
Daniele Forsi IU5HKX
10180a6dc2
Fix sign of error return values
...
All RIG_E* constants should be negated when returned or compared.
Fixed with:
perl -pe 's/return RIG_E/return -RIG_E/' -i $(grep -lEr "return RIG_E" --include=*.{c,h})
perl -pe 's/= RIG_E/= -RIG_E/g' -i $(grep -lEr "= RIG_E" --include=*.{c,h})
2025-06-07 12:07:44 +02:00
Daniele Forsi IU5HKX
4109d606b5
Fix typos
2025-05-22 21:55:10 +02:00
gereta
c2d3202ffb
Update skywatcher.h - Added coordinates for parking position
...
Added coordinates for parking position
2025-03-10 08:18:46 +01:00
Michael Black
820c28e63f
Merge pull request #1650 from dforsi/fix/unused-sources
...
Remove unused and empty source files
2025-01-05 10:03:31 -06:00
Daniele Forsi IU5HKX
3222289ef5
Remove unused and empty source files
2025-01-05 15:14:45 +01:00
Michael Black W9MDB
86518546db
Fix sscanf compare in gs232b.c
2024-12-22 10:37:15 -06:00
Daniele Forsi IU5HKX
e480bc7479
Fix typos
2024-12-01 21:59:11 +01:00
Daniele Forsi IU5HKX
6036a65d2e
Fix typos in comments
2024-11-24 19:24:35 +01:00
Daniele Forsi IU5HKX
82c8a0795e
Fix typos in man pages and other documentation
2024-11-24 19:24:35 +01:00
Mike Black W9MDB
5c269964c2
astyle files in preparation for release 4.6
2024-11-06 08:07:34 -06:00
Mike Black W9MDB
73cdd0b214
Fix gs232.c for a clean run on AF6SA WRC -- hopefully that firmware will get fixed to provide CR/LF like it should
2024-09-21 17:48:08 -05:00
Mike Black W9MDB
4b05884fd7
Fix gs232.c to allow C2 reponse to time out as long as we still get 10 chars it's good
...
This fixes usage tieh AF6SA WRC Wifi Rotator Controller
2024-09-21 15:20:38 -05:00
Mike Black W9MDB
5d3d35d7be
Fix logic error in spid.c
2024-09-08 09:03:53 -05:00
Mike Black W9MDB
25ecaea63a
Fix build on Linux
2024-08-28 16:45:59 -05:00
dernasherbrezon
3a09649816
Fix compilation on linux
2024-08-28 19:26:56 +01:00
dernasherbrezon
4d1148c1ba
Add legal headers
2024-08-28 15:50:43 +01:00
dernasherbrezon
099cc7fc48
Implement initial skywatcher rotator
...
Use GOTO mode when setting position.
Use cache for CPR (Counts Per Revolution) because it is hardcoded for the motor
2024-08-27 23:41:01 +01:00
Mike Black W9MDB
5ba43ba00e
Fix mingw compiles
...
https://github.com/Hamlib/Hamlib/issues/1597
2024-08-18 08:15:11 -05:00
Mike Black W9MDB
6e0aa59cc2
Add ROT_MODEL_SPID_ROT1PROG to priv allocation in spid.c -- fixes potential segfaults
2024-08-16 06:54:15 -05:00
Mike Black W9MDB
64518dac35
Fix possible segfault in spid.c
2024-08-15 16:10:11 -05:00
George Baltz N3GB
c28caa7a9c
Use macros/pointers for rot->state references
2024-07-14 01:17:28 -04:00
George Baltz N3GB
d1520aa166
Fix other rotators that try to do I/O before open.
...
Get rid of possible infinite recursion.
2024-06-14 16:33:39 -04:00
George Baltz N3GB
81a8745fca
Implement the first user of the deferred set_conf entries.
...
Testing with simrotorez shows the correct sequence of actions and
correct commands being received.
2024-06-14 16:23:36 -04:00
Mike Black W9MDB
3549dfe22c
Revert "Move rot_dummy to rotators/dummy -- in preparation for PSKRotator dummy device"
...
This reverts commit 205e03bc57
.
2024-06-02 08:47:27 -05:00
Mike Black W9MDB
205e03bc57
Move rot_dummy to rotators/dummy -- in preparation for PSKRotator dummy device
2024-06-02 08:29:54 -05:00
Mike Black W9MDB
745e72a6cf
Add
...
ROT_MOVE_UP_LEFT, ROT_MOVE_UP_CCW
ROT_MOVE_UP_RIGHT, ROT_MOVE_UP_CW
ROT_MOVE_DOWN_LEFT, ROT_MOVE_DOWN_CCW
ROT_MOVE_DOWN_RIGHT, ROT_MOVE_DOWN_CW
Supported by SPID rotators
2024-05-30 17:34:02 -05:00
George Baltz N3GB
9f997d799d
Fix incorrect port read for elevation
...
Add missing port parameters for rotp2
Remove funky character(^B) from simrotorez.c so `file` and `more` think it
is plain text.
Dunno if this works on the real H/W, but at least the simulator can get
and set az/el position without errors.
2024-03-28 16:26:21 -04:00
George Baltz N3GB
8ff07c47f9
Finish rotators/
2024-02-19 13:06:53 -05:00
George Baltz N3GB
f247ee2088
Convert first part of rotators/
2024-02-19 13:06:53 -05:00
Mike Black W9MDB
e1f2342982
Promote all BETA to STABLE
...
Promot all ALPHA to BETA
2024-02-14 07:11:20 -06:00
Mike Black W9MDB
05033171c3
Change token_t to hamlib_token_t to avoid collsions with libbsm and others
...
https://github.com/Hamlib/Hamlib/issues/1469
2024-01-21 23:11:55 -06:00
Mike Black W9MDB
7334da6d89
Split AZ/EL request into two transactions for easycomm.c
2023-12-19 09:29:31 -06:00