Apply fixes suggested by iwyu

Removes unused includes and adds missing includes.

amplifiers/elecraft/kpa.c

@@ -18,12 +18,15 @@
  *   Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
  *
  */
-
+#include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
+
+#include "amplifier.h"
 #include "kpa.h"
 #include "hamlib/port.h"
 #include "hamlib/amp_state.h"
+#include "iofunc.h"
 
 struct fault_list
 {

amplifiers/elecraft/kpa.h

@@ -27,7 +27,6 @@
 #define _AMP_ELECRAFT_H 1
 
 #include <hamlib/amplifier.h>
-#include <iofunc.h>
 
 // Is this big enough?
 #define KPABUFSZ 100

rigs/anytone/anytone.c

@@ -25,16 +25,16 @@
 //    SYSTEM INCLUDES
 // ---------------------------------------------------------------------------
 
+#include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
-#include <unistd.h>
-#include <ctype.h>
 #include <errno.h>
 
 // ---------------------------------------------------------------------------
 //    HAMLIB INCLUDES
 // ---------------------------------------------------------------------------
 
+#include "config.h"
 #include <hamlib/rig.h>
 #include "serial.h"
 #include "misc.h"

rigs/commradio/commradio.c

@@ -3,9 +3,8 @@
  * idk, copyright and GPL here
  */
 
+#include <stdint.h>
 #include <stdlib.h>
-#include <string.h>
-#include <unistd.h>
 
 #include <hamlib/rig.h>
 #include <register.h>

rigs/commradio/frame.c

@@ -3,9 +3,7 @@
  * idk, copyright and GPL here
  */
 
-#include <stdlib.h>
-#include <string.h>
-#include <unistd.h>
+#include <stdint.h>
 
 #include <hamlib/rig.h>
 

rigs/gomspace/gs100.c

@@ -22,6 +22,7 @@
 
 /* Includes ------------------------------------------------------------------*/
 
+#include <stdint.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>

rigs/guohetec/pmr171.c

@@ -19,9 +19,8 @@
  *
  */
 
+#include <stdint.h>
 #include <stdlib.h>
-#include <string.h>     /* String function definitions */
-#include <stdbool.h>
 
 #ifdef HAVE_SYS_TIME_H
 #include <sys/time.h>
@@ -33,8 +32,6 @@
 #include "cache.h"
 #include "tones.h"
 #include "bandplan.h"
-#include "cal.h"
-
 
 typedef struct pmr171_data_s
 {

rigs/guohetec/q900.c

@@ -19,9 +19,8 @@
  *
  */
 
+#include <stdint.h>
 #include <stdlib.h>
-#include <string.h>     /* String function definitions */
-#include <stdbool.h>
 
 #ifdef HAVE_SYS_TIME_H
 #include <sys/time.h>
@@ -33,7 +32,6 @@
 #include "cache.h"
 #include "tones.h"
 #include "bandplan.h"
-#include "cal.h"
 
 typedef struct q900_data_s
 {

rigs/icom/id5100.c

@@ -26,7 +26,6 @@
 #include "icom_defs.h"
 #include "frame.h"
 #include "misc.h"
-#include "cache.h"
 
 enum
 {

rigs/kenwood/ts990s.c

@@ -22,7 +22,6 @@
 /* SPDX-License-Identifier: LGPL-2.1-or-later */
 
 #include <stdlib.h>
-#include <string.h>
 #include <math.h>
 
 #include <hamlib/rig.h>

rigs/kit/dwt.c

@@ -512,8 +512,6 @@ static const char *dwtdll_get_info(RIG *rig)
 # include <libusb-1.0/libusb.h>
 #endif
 
-#include "token.h"
-
 
 #define USB_VID_CT  0x1539  /* AFG Engineering */
 #define USB_PID_CT_DWT  0x1730  /* Digital World Traveller */

rigs/kit/funcube.c

@@ -28,7 +28,6 @@
 #include <stdlib.h>
 #include <stdio.h>
 #include "hamlib/rig.h"
-#include "misc.h"
 
 #define BACKEND_VER "20210830"
 

rigs/rs/xk852.c

@@ -1,13 +1,10 @@
-#include <stdlib.h>
 
 #include <stdio.h>
-#include <stdlib.h>
 #include <string.h>
 
 #include "hamlib/rig.h"
 #include "iofunc.h"
 #include "misc.h"
-#include "num_stdio.h"
 
 #include "xk852.h"
 

rigs/uniden/uniden_digital.c

@@ -19,8 +19,6 @@
  *
  */
 
-
-#include <stdio.h>
 #include <string.h>  /* String function definitions */
 
 #include "hamlib/rig.h"

rigs/winradio/g313-posix.c

@@ -22,7 +22,6 @@
 #include <stdlib.h>
 #include <string.h>
 #include <unistd.h>
-#include <sys/stat.h>
 
 #include "config.h"
 

rigs/yaesu/ft3000.c

@@ -24,11 +24,12 @@
  *   Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
  *
  */
+#include <string.h>
 
 #include "hamlib/rig.h"
 #include "misc.h"
-#include "newcat.h"
 #include "bandplan.h"
+#include "idx_builtin.h"
 #include "newcat.h"
 #include "yaesu.h"
 #include "ft5000.h"

rigs/yaesu/ft736.c

@@ -27,7 +27,6 @@
 #include "iofunc.h"
 #include "misc.h"
 #include "yaesu.h"
-#include "tones.h"
 #include "cache.h"
 
 #define FT736_MODES (RIG_MODE_CW|RIG_MODE_SSB|RIG_MODE_FM|RIG_MODE_FMN|RIG_MODE_CWN)

rigs/yaesu/vr5000.c

@@ -59,7 +59,6 @@
 
 #include "hamlib/rig.h"
 #include "iofunc.h"
-#include "misc.h"
 #include "yaesu.h"
 
 #define VR5000_MODES (RIG_MODE_CW|RIG_MODE_SSB|RIG_MODE_AM|RIG_MODE_FM|RIG_MODE_WFM)

rotators/grbltrk/grbltrk.c

@@ -25,14 +25,9 @@
 
 #include <stdint.h>
 #include <stdio.h>
-#include <stdlib.h>
 #include <string.h>  /* String function definitions */
 #include <unistd.h>  /* UNIX standard function definitions */
 
-#ifdef HAVE_SYS_IOCTL_H
-#include <sys/ioctl.h>
-#endif
-
 #include "hamlib/rotator.h"
 #include "hamlib/port.h"
 #include "hamlib/rot_state.h"

src/amp_conf.c

@@ -33,7 +33,6 @@
 #include <hamlib/config.h>
 
 #include <stdlib.h>
-#include <stdarg.h>
 #include <stdio.h>   /* Standard input/output definitions */
 #include <string.h>  /* String function definitions */
 

src/conf.c

@@ -33,9 +33,9 @@
 #include <hamlib/config.h>
 
 #include <stdlib.h>
-#include <stdarg.h>
 #include <stdio.h>   /* Standard input/output definitions */
 #include <string.h>  /* String function definitions */
+#include <strings.h>
 
 #include <hamlib/rig.h>
 #include "hamlib/port.h"

src/ext.c

@@ -36,7 +36,6 @@
 
 #include <hamlib/config.h>
 
-#include <stdarg.h>
 #include <stdio.h>   /* Standard input/output definitions */
 #include <string.h>  /* String function definitions */
 

src/extamp.c

@@ -42,7 +42,6 @@
 
 #include <hamlib/config.h>
 
-#include <stdarg.h>
 #include <stdio.h>   /* Standard input/output definitions */
 #include <string.h>  /* String function definitions */
 

src/iofunc.c

@@ -34,7 +34,6 @@
 #include <hamlib/rig.h>
 #include <hamlib/config.h>
 
-#include <stdio.h>   /* Standard input/output definitions */
 #include <string.h>  /* String function definitions */
 #include <unistd.h>  /* UNIX standard function definitions */
 #include <fcntl.h>   /* File control definitions */

src/misc.c

@@ -32,7 +32,6 @@
 #include <hamlib/config.h>
 
 #include <stdlib.h>
-#include <stdarg.h>
 #include <stdio.h>   /* Standard input/output definitions */
 #include <string.h>  /* String function definitions */
 

src/parallel.h

@@ -23,8 +23,8 @@
 #ifndef _PARALLEL_H
 #define _PARALLEL_H 1
 
+#include "config.h"
 #include <hamlib/rig.h>
-#include "iofunc.h"
 
 #ifdef HAVE_PARALLEL
 #ifdef HAVE_LINUX_PARPORT_H

src/rig.c

@@ -60,7 +60,6 @@
 #include <string.h>
 #include <unistd.h>
 #include <stdio.h>
-#include <sys/stat.h>
 #include <errno.h>
 
 #include "mutex.h"

src/rot_conf.c

@@ -34,7 +34,6 @@
 #include <hamlib/config.h>
 
 #include <stdlib.h>
-#include <stdarg.h>
 #include <stdio.h>   /* Standard input/output definitions */
 #include <string.h>  /* String function definitions */
 

src/usb_port.c

@@ -33,10 +33,10 @@
 
 #include <hamlib/config.h>
 
-
-
+#include <stdio.h>
 #include <stdlib.h>
 #include <string.h>  /* String function definitions */
+#include <strings.h>
 
 #include <hamlib/rig.h>
 #include "hamlib/port.h"

tests/ampctl_parse.c

@@ -32,9 +32,9 @@
 #include <stdlib.h>
 #include <string.h>
 #include <strings.h>
+#include <unistd.h>
 #include <ctype.h>
 #include <errno.h>
-#include <getopt.h>
 
 #ifdef HAVE_LIBREADLINE
 #  if defined(HAVE_READLINE_READLINE_H)

tests/memload.c

@@ -18,8 +18,6 @@
  *
  */
 
-#include <stdlib.h>
-
 #include <hamlib/rig.h>
 
 #ifdef HAVE_XML2

tests/rig_tests.c

@@ -1,4 +1,4 @@
-#include <stdio.h>
+#include <string.h>
 #include <hamlib/rig.h>
 #include <misc.h>
 

tests/rigctl_parse.c

@@ -35,7 +35,6 @@
 #include <unistd.h>
 #include <ctype.h>
 #include <errno.h>
-#include <getopt.h>
 #include <rig_tests.h>
 
 // If true adds some debug statements to see flow of rigctl parsing

tests/rigmem.c

@@ -25,6 +25,7 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
+#include <unistd.h>
 
 #include <getopt.h>
 

tests/rigtestmcastrx.c

@@ -1,7 +1,6 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
-#include <errno.h>
 #include <unistd.h>
 
 #ifdef _WIN32

tests/rotctl_parse.c

@@ -33,7 +33,6 @@
 #include <unistd.h>
 #include <ctype.h>
 #include <errno.h>
-#include <getopt.h>
 
 #ifdef HAVE_LIBREADLINE
 #  if defined(HAVE_READLINE_READLINE_H)