Trialling a minimal pull request template. The Github "new PR" interface is quite overwhelming for new contributors, especially when Github adds its own signposting towards the contributing guidelines for first-time PRs - it's likely that this is leading users to see the already-filled text box as just more "wall of text", rather than something they're supposed to fill in.
This is useful when the controller is used in views that would produce an identical response if the page is hard-reloaded with the same params, e.g. listings
Issue was appearing when there was nested inline panels.
currentChild. find would match the parent up/down button
but also all the ones of the nested inline panels
Fixes#5919
- Changed all British spellings to American spellings, in the Customizing admin templates section of the docs
- Transferred all British spellings in the usage guide and advanced topics section to American spellings
- Update a series of other pages to use the spelling cutomize in the file name
Implemented all feedbacks on the usage guide and advanced topics section
This un-reverts commit 99dd11510b with fixes for Prettier mirror (it's rev must be 3.0.3 even if using a newer Prettier).
The original commit which was reverted is 5971ce7f3f
- React Button was only ever used to render a link (a element)
- This creates a potential accessibility issue if developers want to render a button, it's confusing and incorrect
- Additionally, the unused prop (dialogTrigger) & aria-haspopup is non-compliant and has been removed
Rather than special-casing whether the page is root or not, just check
if there is only one item. If that's the case, then the user is
exploring the "explorable root instance", which may be the root Page
instance or the closest common ancestor where the user has permission.
In this case, we don't want to show the breadcrumbs toggle/expand button
(it's always expanded).
This also removes the incorrectly extraneous right arrow when exploring
the root instance.
Fixes#11451
Remove the special case for when the first item in the breadcrumb is something other than the site root. This special-casing had two effects, neither of which was actually desirable:
* It replaced the displayed page title with 'Root' (which is undesirable because the page in question is often one that the user can edit, and therefore they ought to be able to see what it is
* It took precedence over the styling for the _last_ item in the breadcrumb, which should be always visible rather than on-hover
Matt Westcott