Merge pull request #695 from nextcloud/bugfix/noid/misc

some fixes

lib/Service/PushService.php

@@ -94,9 +94,6 @@ class PushService {
 
 	/**
 	 * @param string $streamId
-	 *
-	 * @throws SocialAppConfigException
-	 * @throws PushInstallException
 	 */
 	public function onNewStream(string $streamId) {
 		// FIXME: remove in nc18
@@ -114,8 +111,13 @@ class PushService {
 			return;
 		}
 
-		$pushHelper = $this->pushManager->getPushHelper();
-		$details = $this->detailsService->generateDetailsFromStream($stream);
+		try {
+			$pushHelper = $this->pushManager->getPushHelper();
+			$details = $this->detailsService->generateDetailsFromStream($stream);
+		} catch (PushInstallException | SocialAppConfigException $e) {
+			return;
+		}
+
 		$home = array_map(
 			function(Person $item): string {
 				return $item->getUserId();

lib/Service/SignatureService.php

@@ -396,12 +396,12 @@ class SignatureService {
 	 * @param string $publicKey
 	 * @param array $sign
 	 * @param string $estimated
-	 * @param bool $signed
+	 * @param string $signed
 	 *
 	 * @throws SignatureException
 	 */
 	private function checkRequestSignatureUsingPublicKey(
-		string $publicKey, array $sign, string $estimated, bool $signed
+		string $publicKey, array $sign, string $estimated, string $signed
 	) {
 		$algorithm = $this->getAlgorithmFromSignature($sign);
 		if ($publicKey === ''