YuviPanda
b854c6c30d
Document why we put certs in current dir
2025-02-28 13:15:57 -08:00
YuviPanda
0bc550a494
Add a .gitignore for any generated tmp certs
2025-02-28 13:15:07 -08:00
pre-commit-ci[bot]
c9b78be470
[pre-commit.ci] auto fixes from pre-commit.com hooks
...
for more information, see https://pre-commit.ci
2025-02-28 21:12:03 +00:00
YuviPanda
c04652e706
Replace mocked find_image tests with real ones
2025-02-28 13:11:34 -08:00
YuviPanda
9753570370
Pass cert_dir removal some of the time
2025-02-28 13:06:17 -08:00
pre-commit-ci[bot]
5aaf26aa9d
[pre-commit.ci] auto fixes from pre-commit.com hooks
...
for more information, see https://pre-commit.ci
2025-02-28 19:45:45 +00:00
YuviPanda
af1050f72b
Re-add docker import for container running
2025-02-28 11:45:26 -08:00
YuviPanda
2d9a350700
Inspect returns a list of dicts
2025-02-28 11:34:54 -08:00
pre-commit-ci[bot]
a0f02ce2c6
[pre-commit.ci] auto fixes from pre-commit.com hooks
...
for more information, see https://pre-commit.ci
2025-02-28 19:31:50 +00:00
YuviPanda
48da2c1bf4
Re-add dockerpy for using exclude patterns
2025-02-28 11:29:20 -08:00
YuviPanda
576b8967bc
Stop using docker-py for anything
...
Also properly setup TLS for docker daemon to close security hole
2025-02-28 11:19:45 -08:00
pre-commit-ci[bot]
9f6fbf7678
[pre-commit.ci] auto fixes from pre-commit.com hooks
...
for more information, see https://pre-commit.ci
2025-02-28 17:44:57 +00:00
YuviPanda
a8369beed4
Use custom dind for talking to insecure registry
2025-02-28 09:44:35 -08:00
YuviPanda
69e67a23bf
Don't need -it for docker run here
2025-02-27 21:28:50 -08:00
YuviPanda
8444a28d86
Explicitly pull registry image before trying to run
2025-02-27 21:26:42 -08:00
YuviPanda
82e049fcec
Add a docker registry integration test with real registry
2025-02-27 20:49:09 -08:00
YuviPanda
364a18932c
Add a local registry in github actions for us to test with
2025-02-27 20:21:22 -08:00
pre-commit-ci[bot]
3bdc004e46
[pre-commit.ci] auto fixes from pre-commit.com hooks
...
for more information, see https://pre-commit.ci
2025-02-26 21:00:18 +00:00
YuviPanda
268e18765b
Properly set DOCKER_CONFIG to be a dir, not a file
2025-02-26 12:58:29 -08:00
YuviPanda
ac0def4028
Use CLI to push docker image
...
Preserves existing authentication information handling behavior:
1. If registry_credentials are present, they are used but not leaked
on to existing ~/.docker/config
2. If registry_credentials are not present, they are not used
3. Regardless of registry_credentials being present, we still will use
existing authentication info in DOCKER_CONFIG
2025-02-26 11:12:16 -08:00
Min RK
17a23c4ae6
Merge pull request #1416 from yuvipanda/runtime
...
Add a test for runtime.txt with full R version specified
2025-02-21 13:09:45 +01:00
YuviPanda
3304921cdd
Ask for very specific version
2025-02-20 14:55:08 -08:00
YuviPanda
a9e5a19aee
Add a test for runtime.txt with full R version specified
...
Catching possible errors as reported in https://discourse.jupyter.org/t/error-in-mybinder-org-there-is-no-package-called-irkernel/32478/13 .
The other tests only specify x.y, not x.y.z
2025-02-20 14:07:28 -08:00
Yuvi Panda
1ad76bcbca
Merge pull request #1403 from minrk/r-triplets
...
add triplets for r versions 4.3, 4.4
2025-02-20 12:24:12 -08:00
Min RK
a6e9ddffc2
update expected version in verify
2025-02-19 08:49:55 +01:00
YuviPanda
5a3144f960
Update r version we test
2025-02-18 14:23:24 -08:00
Yuvi Panda
11b8fc1ab8
Fix typo
...
Co-authored-by: Simon Li <orpheus+devel@gmail.com>
2025-02-18 14:05:07 -08:00
Min RK
d13330a288
resolve unrecognized x.y r versions to x.y.0
...
R.deb download step requires a full x.y.z version, it will 404 on `r-4.4`
2025-02-18 14:05:07 -08:00
Min RK
8d916f46c4
add triplets for r versions 4.3, 4.4
...
otherwise r-4.3 won't work
2025-02-18 14:05:07 -08:00
Yuvi Panda
80d186a577
Merge pull request #1413 from yuvipanda/push
...
Simulate json output from docker buildx build
2025-02-14 08:41:51 -08:00
YuviPanda
b6fa2d447e
Simulate json output from docker buildx build
...
We still use the docker python api to push images, and to run.
So we need to set string_output to false, and simulate the json
output on buildx. Alternatively we could completely get rid of the
python API, but that's a much bigger lift (especially around registry
credentials) that I don't want us to do right now.
Without this, push progress is reported as raw bytes in the
binderhub UI
2025-02-13 16:01:32 -08:00
Yuvi Panda
13cbc9e572
Merge pull request #1402 from yuvipanda/docker-buildx
...
Shell out to `docker buildx build` to build images
2025-02-13 09:28:14 -08:00
Min RK
6d50085b85
Merge pull request #1412 from manics/docker-alpine
...
Bump alpine docker to 3.21
2025-02-13 11:01:23 +01:00
Min RK
8ff109f179
Merge pull request #1411 from manics/min-python
...
Require Python 3.9 to run repo2docker
2025-02-13 11:00:54 +01:00
Simon Li
7793358699
Bump alpine docker to 3.21
2025-02-13 09:34:00 +00:00
Simon Li
89e78b7caf
Require Python 3.9 to run repo2docker
2025-02-13 09:27:45 +00:00
Yuvi Panda
709eb8e527
Update error message
...
Co-authored-by: Simon Li <orpheus+devel@gmail.com>
2025-02-12 21:23:41 -08:00
pre-commit-ci[bot]
ac485fa06c
[pre-commit.ci] auto fixes from pre-commit.com hooks
...
for more information, see https://pre-commit.ci
2025-02-12 17:55:42 +00:00
Simon Li
c1ddf464d6
BREAKING: Require Python 3.8 to run repo2docker
2025-02-12 17:52:28 +00:00
Simon Li
72816ca708
Bump GitHub actions runner to ubuntu-24.04
2025-02-12 17:44:16 +00:00
Simon Li
f50c0c52eb
Merge pull request #1410 from manics/playwright
...
Add basic UI Playwright tests
2025-02-12 17:32:47 +00:00
Yuvi Panda
a9a38de516
Clarify where memory limits are
...
Co-authored-by: Simon Li <orpheus+devel@gmail.com>
2025-02-12 08:17:50 -08:00
Simon Li
704b91c4f1
set `external-verify` name in test
...
Co-authored-by: Min RK <benjaminrk@gmail.com>
2025-02-12 13:18:31 +00:00
pre-commit-ci[bot]
6484673698
[pre-commit.ci] auto fixes from pre-commit.com hooks
...
for more information, see https://pre-commit.ci
2025-02-12 04:59:13 +00:00
YuviPanda
b243cb6079
Add another unit test for sys.exit behavior
2025-02-11 20:58:58 -08:00
pre-commit-ci[bot]
bd39320153
[pre-commit.ci] auto fixes from pre-commit.com hooks
...
for more information, see https://pre-commit.ci
2025-02-12 04:52:38 +00:00
YuviPanda
34399f8f87
Throw error if using --build-memory-limit
2025-02-11 20:52:23 -08:00
Yuvi Panda
b0cfd45b14
Merge pull request #1409 from manics/terminal-no-set-e
...
`set -e` should not be set after conda environment is sourced
2025-02-11 20:41:07 -08:00
Simon Li
0186eef20d
Add basic UI Playwright tests
2025-02-12 00:14:01 +00:00
Yuvi Panda
374b8e5646
Merge pull request #1408 from manics/forks-no-scheduled-workflows
...
Don't run scheduled workflows on forks
2025-02-11 13:11:19 -08:00