yuvipanda
74fc378230
Clarify comment around memswap & memory
2019-05-08 09:44:58 -07:00
Tim Head
2eb4781c2e
Swap limit doesn't have to be bigger than memory limit
2019-05-08 18:22:11 +02:00
Tim Head
032baf6d04
Add check to `build()` for memory limit type
2019-05-08 14:23:43 +02:00
Tim Head
9f44075839
Fix cache-from tests to pass memory limit as integer
2019-05-08 13:20:10 +02:00
Tim Head
ef2860371a
Fix memory limits set for container image builds
2019-05-08 08:11:38 +02:00
Tim Head
5adc4b257e
Update base image used for memory limit checks
2019-05-07 19:12:34 +02:00
Tim Head
56708c662e
specification info page ( #662 )
...
specification info page
2019-05-05 15:06:59 +02:00
Chris Holdgraf
f86a06d4ba
tim comments in specification doc
2019-05-04 10:57:27 -07:00
Chris Holdgraf
1c66925090
updates per comments
2019-05-03 09:38:07 -07:00
Tim Head
df89849e21
tweak language to make clear `exec "$@"` works ( #663 )
...
tweak language to make clear `exec "$@"` works
2019-05-03 18:18:42 +02:00
Wayne's Bioinformatics Code Portal
48578bda66
Merge pull request #1 from fomightez/tweak_start_config_descr
...
tweak language to make clear `exec "$@"` works
2019-05-03 11:18:34 -04:00
Wayne's Bioinformatics Code Portal
21c730298e
tweak language to make clear `exec "$@"` works
...
originally it was: "The last line must be ``exec "$@"`` equivalent." Seemed open to interpretation as I needed to deduce what the equivalent of that would be here. I think adding 'or' before equivalent shows that will work, but I assume other options exist? Or why note say "The last line must be ``exec "$@"``"?
2019-05-03 11:14:25 -04:00
Chris Holdgraf
b20438bd59
specification info
2019-05-02 16:01:37 -07:00
Tim Head
e976627c1e
Merge pull request #657 from yuvipanda/abs-start
...
Make sure ENTRYPOINT is an absolute path
2019-04-30 21:44:50 +02:00
Tim Head
e35277410a
[MRG] Update contributing guidelines and issue templates ( #655 )
...
[MRG] Update contributing guidelines and issue templates
2019-04-30 21:40:15 +02:00
Tim Head
92d69010c7
Merge pull request #652 from betatim/fix-memory-limit
...
[MRG] Fix handling of memory limit command line argument
2019-04-30 21:34:52 +02:00
Kirstie Whitaker
a6911a10a0
Update docs/source/contributing/contributing.md
2019-04-30 20:11:17 +01:00
Tim Head
c56e8b1f21
add note to changelog ( #659 )
...
add note to changelog
2019-04-30 19:50:27 +02:00
yuvipanda
c8cff1bccc
Fix typo in comment
2019-04-30 10:46:34 -07:00
yuvipanda
c0a33b340b
Add test for integral --build-memory-limit
2019-04-30 10:46:09 -07:00
Joseph Hamman
9ded2b5ee6
add note to changelog
2019-04-30 10:06:24 -07:00
yuvipanda
4dd32f3563
Make sure ENTRYPOINT is an absolute path
...
Unlike other parts of the generated Dockerfile,
the start script is evaluated at run time, rather
than at build time. Currently, we assume that the
current working directory is the same at runtime
as build time for the start script. This doesn't
hold true always, and particularly not in JupyterHub
environments where ${HOME} is often overlaid with
a persistent directory.
We change this to always refer to the full path,
using the ${REPO_DIR} environment variable. This
lets people building JupyterHub images to set
REPO_DIR to something like /srv/repo (like hubploy
does), and still have a working start script.
2019-04-30 10:04:53 -07:00
Tim Head
5e67e3c743
Support .binder directory ( #653 )
...
Support .binder directory
2019-04-30 18:29:38 +02:00
Joseph Hamman
6de4c5ea6b
add unit tests for binder dir
2019-04-30 08:35:58 -07:00
Tim Head
9099def40a
[MRG] install notebook in its own env ( #651 )
...
[MRG] install notebook in its own env
2019-04-30 14:25:21 +02:00
Kirstie Whitaker
6344f39d25
Update contributing.md
2019-04-30 09:23:34 +01:00
Tim Head
34cff4d5d3
Update docs/source/contributing/contributing.md
...
Co-Authored-By: KirstieJane <kw401@cam.ac.uk>
2019-04-30 09:20:47 +01:00
Kirstie Whitaker
288c3fe811
Update .github/ISSUE_TEMPLATE/feature_request.md
2019-04-30 09:18:01 +01:00
Chris Holdgraf
c25e6bc2ae
Update docs/source/contributing/contributing.md
...
Co-Authored-By: KirstieJane <kw401@cam.ac.uk>
2019-04-30 09:13:32 +01:00
Tim Head
e2c7de8d19
Update Julia tests for new conda env path
2019-04-30 08:43:19 +02:00
Tim Head
e15007d528
Make sure start script is executable
2019-04-30 08:43:19 +02:00
Joseph Hamman
34ad355de6
fix up nix-shell-wrapper for .binder feature
2019-04-29 20:30:07 -07:00
Kirstie Whitaker
f9afea1f29
Reword comment and remove thank you prompt
2019-04-29 17:58:22 +01:00
Joseph Hamman
05273abb38
fix bash spacing
2019-04-29 08:52:18 -07:00
Chris Holdgraf
c9a161746d
Update CONTRIBUTING.md
...
Co-Authored-By: KirstieJane <kw401@cam.ac.uk>
2019-04-29 16:40:02 +01:00
Chris Holdgraf
f3e004dd19
Update CONTRIBUTING.md
...
Co-Authored-By: KirstieJane <kw401@cam.ac.uk>
2019-04-29 16:39:49 +01:00
Joseph Hamman
7ac4cb4932
error if both binder and .binder dirs exist
2019-04-29 08:05:49 -07:00
Kirstie Whitaker
6cd3d1d895
Update .github/ISSUE_TEMPLATE/feature_request.md
2019-04-29 15:09:42 +01:00
Joseph Hamman
e83b12f5b2
add missing break
2019-04-29 06:47:51 -07:00
Joseph Hamman
3c0ceaacc2
clarify that only one of binder and .binder can be used at once
2019-04-28 20:28:09 -07:00
Chris Holdgraf
7681a6c774
[MRG] Update issue templates ( #654 )
...
[MRG] Update issue templates
2019-04-28 16:50:45 -07:00
Kirstie Whitaker
13922ee249
Embelish the links in contributing.md
2019-04-28 20:09:34 +01:00
Kirstie Whitaker
6c43fb927a
Extend the points about feature requests & bug reports
2019-04-28 19:58:55 +01:00
Kirstie Whitaker
5a7add7929
Update process and guidelines for making contribution
2019-04-28 19:41:33 +01:00
Kirstie Whitaker
a27420e29f
Add types of contributions section
2019-04-28 19:11:32 +01:00
Kirstie Whitaker
1e0eb726ce
Make html comments all on one long line
2019-04-28 18:25:57 +01:00
Kirstie Whitaker
6ff13e9162
Add comments and additional structure to feature request
2019-04-28 18:25:25 +01:00
Kirstie Whitaker
1d9a64551f
Add html comments to bug report
2019-04-28 18:12:23 +01:00
Tim Head
991a6826a8
Tweak bug report template
2019-04-28 18:31:46 +02:00
Tim Head
e3ee8afa6f
Update issue templates
2019-04-28 13:02:41 +02:00