yuvipanda
4858f42d7f
Only set REPO_PATH if explicitly passed in
...
Expanding env vars through ARG and ENV is too confusing
to get right.
2018-12-18 11:50:24 -08:00
yuvipanda
8b26bbe4e0
Allow setting REPO_PATH from commandline
2018-12-18 11:50:24 -08:00
yuvipanda
0f3076387a
Set REPO_PATH as late as possible
...
Leads to maximum cache re-use
2018-12-18 11:50:24 -08:00
yuvipanda
3dfe0a8143
Copy repo to ${REPO_DIR} rather than ${HOME}
...
We want to put the repo somewhere other than ${HOME}
so we can mount persistent storage in ${HOME} more easily.
Most of repo2docker assumes current directory is where
the contents are, so we should be able to get most of it
working by setting WORKDIR to ${REPO_PATH} and letting
${REPO_PATH} be configurable.
Unclear what to do for plain Dockerfiles, Legacy Dockerfiles &
nix.
2018-12-18 11:50:24 -08:00
Yuvi Panda
bdd32b292a
Merge pull request #520 from jrbourbeau/remove-f-strings
...
Remove f-strings
2018-12-18 10:20:50 -08:00
James Bourbeau
4f72fd8c94
Remove f-string in test
2018-12-18 09:29:28 -06:00
James Bourbeau
3cadb1832d
Another f-string
2018-12-18 09:07:52 -06:00
James Bourbeau
929deaceb4
Remove f-strings
2018-12-18 08:57:53 -06:00
Tim Head
36641f3b6f
Merge pull request #501 from minrk/push-tags
...
fix push-tags condition
2018-12-18 12:49:20 +01:00
Tim Head
0670ca004d
Merge pull request #519 from minrk/just-574
...
refreeze with notebook 5.7.4
2018-12-18 11:31:04 +01:00
Tim Head
a583b1554c
Merge pull request #483 from yuvipanda/quiet-apt
...
Make apt-get install be quiet
2018-12-18 09:45:47 +01:00
Tim Head
14be26e625
Merge pull request #518 from jrbourbeau/fix-rtd
...
Update RTD to install repo2docker
2018-12-18 08:40:02 +01:00
James Bourbeau
a6820bee7b
Update RTD to install repo2docker
2018-12-17 21:41:10 -06:00
yuvipanda
7eb1ac46af
Redirect apt-get install output to /dev/null
...
`apt-get install` calls `dpkg` underneath to do the
installation. Unfortunately, `-qq` does not get passed
through, and we end up with a lot of log output even with
`-qq`. Redirecting stdout to /dev/null stops this output.
Errors come out to stderr, so those will be displayed.
2018-12-17 16:31:14 -08:00
yuvipanda
6ec05e3693
Pass quiet flag to apt properly
...
-qq is a parameter to 'apt-get' rather than the subcommand
2018-12-17 16:28:48 -08:00
Yuvi Panda
82faafcf98
Merge pull request #515 from jrbourbeau/api-docs
...
Add command line API to docs
2018-12-17 16:28:13 -08:00
James Bourbeau
7403530f07
Add pip install repo
2018-12-17 16:11:26 -06:00
James Bourbeau
1bb2b2f3a7
Move autoprogram to doc requirements
2018-12-17 16:04:47 -06:00
James Bourbeau
cc98e3f041
Add ArgumentParser description
2018-12-17 13:49:43 -06:00
James Bourbeau
9421c73117
Add CLI API docs
2018-12-17 13:06:32 -06:00
Min RK
b4665f71d4
refreeze with notebook 5.7.4
2018-12-17 16:30:15 +01:00
Tim Head
aac8857aeb
Merge pull request #504 from jrbourbeau/move-changelog
...
Move changelog to docs
2018-12-17 16:14:01 +01:00
Tim Head
2d7f2a1681
Merge pull request #512 from minrk/unittests
...
move unittests into tests/unit
2018-12-17 16:04:19 +01:00
James Bourbeau
5f65cd0858
Use relative link to changelog [skip travis]
2018-12-17 08:49:56 -06:00
James Bourbeau
2f00a1444c
Update new contributing guide changelog ref [skip travis]
2018-12-17 08:46:21 -06:00
James Bourbeau
d78125b91b
Merge remote-tracking branch 'upstream/master' into move-changelog
2018-12-17 08:37:38 -06:00
James Bourbeau
4f3d5de778
Add GitHub users to extlinks
2018-12-17 08:36:29 -06:00
Min RK
5c84117fba
report top 10 slowest tests in each group
2018-12-17 14:43:20 +01:00
Min RK
aca4259534
update port tests
...
use repo2docker directly, not as a subprocess
2018-12-17 14:23:02 +01:00
Min RK
58a1ff7f1e
run unittests first on travis
...
since they should give us the quickest and clearest failure indicators
2018-12-17 13:19:37 +01:00
Min RK
22de9f40d0
get unittests passing again
...
fix some relative paths, temporary dirs, etc.
2018-12-17 13:11:45 +01:00
Min RK
a5d5e77ad1
move unittests into tests/unit directory
...
for easier test discovery so we don't skip tests without realizing
2018-12-17 13:06:28 +01:00
Min RK
50cee3e123
Merge pull request #496 from yuvipanda/separate-argparse
...
Make repo2docker easier to use as a library - Part 1
2018-12-17 10:29:40 +01:00
Tim Head
ed85e17373
Merge pull request #509 from yuvipanda/fix-local-cache-busting
...
Fix cache-busting when running tests locally
2018-12-17 08:04:09 +01:00
yuvipanda
b555adda43
Fix cache-busting when running tests locally
...
When you run repo2docker locally, the uid is usually set
to the current user's uid. However, when we push the content
to Docker, we invariably set the uid of the scripts we
use as part of repo2docker at 1000. This causes a cache bust
every time.
This patch uses the correct uid, and fixes cache busting. Makes
local test runs *much* faster.
Fixes #508
2018-12-16 11:15:36 -08:00
Yuvi Panda
c02bba2e44
Merge pull request #505 from betatim/docs-fixup
...
Fix typos and syntax errors in the documentation
2018-12-15 12:15:08 -08:00
James Bourbeau
381d21c25b
Update CHANGES.rst [skip travis]
2018-12-15 10:25:49 -06:00
Tim Head
3f9f4918c5
Fix typos and syntax errors in the documentation
2018-12-15 08:40:27 +01:00
yuvipanda
3a85fb814b
Use pytest's capsys to test for stdout values
...
Works better with pytest's output capturing system
2018-12-14 13:30:22 -08:00
yuvipanda
a9f45e6fae
Make sure our args tests are run
...
We don't wanna block this PR on fixing all the tests,
instead only on making the added tests run
2018-12-14 13:15:33 -08:00
yuvipanda
0a1d9e3d5f
Add test for valid & invalid docker image names
2018-12-14 13:15:33 -08:00
yuvipanda
183d504515
Add test for cleanup_checkout
2018-12-14 13:15:33 -08:00
yuvipanda
a44aed7664
Add some argument parsing tests
...
And fix the one bug discovered in this process
2018-12-14 13:15:33 -08:00
yuvipanda
769efb8a69
Add test for proper failure when ref isn't found in git repo
2018-12-14 13:15:33 -08:00
yuvipanda
8f56061e69
Don't call sys.exit from inside the class
...
Instead, we raise exceptions that can be caught and
handled by calling code instead
2018-12-14 13:15:33 -08:00
yuvipanda
a0ad3f92e3
Rename 'build' to 'dry_run'
...
A better description
2018-12-14 13:15:33 -08:00
yuvipanda
ac700c49be
Split 'build' function out of start
2018-12-14 13:15:33 -08:00
yuvipanda
cd04da56fc
Move cleanup_checkout automatic determination to main()
...
This is automaticaly determined only from commandline args,
so it should be in __main__
2018-12-14 13:15:33 -08:00
yuvipanda
e1ead75302
Move argument parsing out of Repo2Docker class
...
Argument parsing should only be used when calling from
the command line, and not be deeply tied into the class
itself. This makes it easier for folks to just set
traitlets on an empty class and start it, without having to
deal with passing arguments.
This breaks how people might already be using Repo2Docker as
a library, so should not be part of 0.7
2018-12-14 13:15:33 -08:00
James Bourbeau
454782426e
Move changelog to docs
2018-12-14 14:20:47 -06:00