MIDI CC signals can now be used to change frequency slider

CHANGELOG.md

@@ -1,3 +1,7 @@
+- 1.24.5
+  - Bug fix: MIDI CC signals can now be used to change frequency slider
+
+
 - 1.24.4
   - Fix various bugs with MIDI synthesis
     - Attack and decay now applied to sine waves in background

pom.xml

@@ -6,7 +6,7 @@
 
     <groupId>sh.ball</groupId>
     <artifactId>osci-render</artifactId>
-    <version>1.24.4</version>
+    <version>1.24.5</version>
 
     <name>osci-render</name>
 

src/main/java/sh/ball/gui/components/EffectComponentGroupController.java

@@ -144,7 +144,7 @@ public class EffectComponentGroupController implements Initializable, SubControl
   }
 
   @Override
-  public void micSignalReceived() {}
+  public void slidersUpdated() {}
 
   public void setType(EffectType type) {
     this.type = type;

src/main/java/sh/ball/gui/controller/EffectsController.java

@@ -178,5 +178,5 @@ public class EffectsController implements Initializable, SubController {
   }
 
   @Override
-  public void micSignalReceived() {}
+  public void slidersUpdated() {}
 }

src/main/java/sh/ball/gui/controller/GeneralController.java

@@ -275,7 +275,7 @@ public class GeneralController implements Initializable, SubController {
   }
 
   @Override
-  public void micSignalReceived() {}
+  public void slidersUpdated() {}
 
   public void setFrameSourceName(String name) {
     this.frameSourceName = name;

src/main/java/sh/ball/gui/controller/ImageController.java

@@ -247,7 +247,7 @@ public class ImageController implements Initializable, SubController {
   }
 
   @Override
-  public void micSignalReceived() {
+  public void slidersUpdated() {
     frequency.set(Math.pow(MAX_FREQUENCY, frequencySlider.getValue()));
   }
 }

src/main/java/sh/ball/gui/controller/MainController.java

@@ -792,6 +792,7 @@ public class MainController implements Initializable, FrequencyListener, MidiLis
             double scale = MidiNote.MAX_VELOCITY / (double) actualChannels;
             double zeroPoint = closestToZero / (double) MidiNote.MAX_VELOCITY;
             slider.setValue(getValueInSliderRange(slider, scale * ((correctedValue / (double) MidiNote.MAX_VELOCITY) - zeroPoint) + zeroPoint));
+            subControllers().forEach(SubController::slidersUpdated);
           }
         });
       } else if (cc == MidiNote.ALL_NOTES_OFF) {
@@ -1140,7 +1141,7 @@ public class MainController implements Initializable, FrequencyListener, MidiLis
             } else if (sliderValue < slider.getMin()) {
               sliderValue = slider.getMin();
             }
-            subControllers().forEach(SubController::micSignalReceived);
+            subControllers().forEach(SubController::slidersUpdated);
             sliders.get(i).setValue(sliderValue);
           }
         }

src/main/java/sh/ball/gui/controller/ObjController.java

@@ -185,5 +185,5 @@ public class ObjController implements Initializable, SubController {
   }
 
   @Override
-  public void micSignalReceived() {}
+  public void slidersUpdated() {}
 }

src/main/java/sh/ball/gui/controller/SubController.java

@@ -24,5 +24,5 @@ public interface SubController {
 
   void load(Element root);
 
-  void micSignalReceived();
+  void slidersUpdated();
 }