Wykres commitów

1187 Commity (2e4f862387926f90de14a4510fdd8c82b8f4c679)

Autor SHA1 Wiadomość Data
Eliot Berriot 2e4f862387
See #212: record user last activity date 2018-06-17 17:53:40 +02:00
Eliot Berriot 307959dfa6 Merge branch '264-webserver-permission' into 'develop'
Resolve "Documentation : Better layout for in-place imports"

Closes #254

See merge request funkwhale/funkwhale!259
2018-06-17 13:28:38 +00:00
Eliot Berriot aaad2329ef Merge branch '265-user-upgrade' into 'develop'
Resolve "Upgrade doc"

Closes #265

See merge request funkwhale/funkwhale!258
2018-06-17 11:05:23 +00:00
Eliot Berriot fb66d06c09
#254: documented a saner layout with symlinks for in-place imports 2018-06-17 12:59:08 +02:00
Eliot Berriot 51c3927618
Fix #265: Upgrade documentation now use the correct user on non-docker setups 2018-06-17 12:40:46 +02:00
Eliot Berriot 26c3449770
Merge tag '0.14.2' into develop
0.14.2 (2018-06-16)
-------------------

.. warning::

    This release contains a fix for a permission issue. You should upgrade
    as soon as possible. Read the changelog below for more details.

Upgrade instructions are available at
https://docs.funkwhale.audio/upgrading.html

Enhancements:

- Added feedback on shuffle button (#262)
- Added multiple warnings in the documentation that you should never run
  makemigrations yourself (#291)
- Album cover served in http (#264)
- Apache2 reverse proxy now supports websockets (tested with Apache 2.4.25)
  (!252)
- Display file size in human format during file upload (#289)
- Switch from BSD-3 licence to AGPL-3 licence (#280)

Bugfixes:

- Ensure radios can only be edited and deleted by their owners (#311)
- Fixed admin menu not showing after login (#245)
- Fixed broken pagination in Subsonic API (#295)
- Fixed duplicated websocket connexion on timeline (#287)

Documentation:

- Improved documentation about in-place imports setup (#298)

Other:

- Added Black and flake8 checks in CI to ensure consistent code styling and
  formatting (#297)
- Added bug and feature issue templates (#299)

Permission issues on radios
^^^^^^^^^^^^^^^^^^^^^^^^^^^

Because of an error in the way we checked user permissions on radios,
public radios could be deleted by any logged-in user, even if they were not
the owner of the radio.

We recommend instances owners to upgrade as fast as possible to avoid any abuse
and data loss.

Funkwhale is now licenced under AGPL-3
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Following the recent switch made by PixelFed
(https://github.com/dansup/pixelfed/issues/143), we decided along with
the community to relicence Funkwhale under the AGPL-3 licence. We did this
switch for various reasons:

- This is better aligned with other fediverse software
- It prohibits anyone to distribute closed-source and proprietary forks of Funkwhale

As end users and instance owners, this does not change anything. You can
continue to use Funkwhale exactly as you did before :)

Apache support for websocket
^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Up until now, our Apache2 configuration was not working with websockets. This is now
solved by adding this at the beginning of your Apache2 configuration file::

    Define funkwhale-api-ws ws://localhost:5000

And this, before the "/api" block::

    # Activating WebSockets
    ProxyPass "/api/v1/instance/activity" ${funkwhale-api-ws}/api/v1/instance/activity

Websockets may not be supported in older versions of Apache2. Be sure to upgrade to the latest version available.

Serving album covers in https (Apache2 proxy)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Two issues are addressed here. The first one was about Django replying with
mixed content (http) when queried for covers. Setting up the `X-Forwarded-Proto`
allows Django to know that the client is using https, and that the reply must
be https as well.

Second issue was a problem of permission causing Apache a denied access to
album cover folder. It is solved by adding another block for this path in
the Apache configuration file for funkwhale.

Here is how to modify your `funkwhale.conf` apache2 configuration::

  <VirtualHost *:443>

    ...
    #Add this new line
    RequestHeader set X-Forwarded-Proto "https"
    ...
    # Add this new block below the other <Directory/> blocks
    # replace /srv/funkwhale/data/media with the path to your media directory
    # if you're not using the standard layout.
    <Directory /srv/funkwhale/data/media/albums>
      Options FollowSymLinks
      AllowOverride None
      Require all granted
    </Directory>
    ...
  </VirtualHost>

About the makemigrations warning
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

You may sometimes get the following warning while applying migrations::

    "Your models have changes that are not yet reflected in a migration, and so won't be applied."

This is a warning, not an error, and it can be safely ignored.
Never run the ``makemigrations`` command yourself.
2018-06-16 15:05:16 +02:00
Eliot Berriot 544a60b800
Merge branch 'release/0.14.2' 2018-06-16 15:04:55 +02:00
Eliot Berriot cb1957a961
Version bump and changelog for 0.14.2 2018-06-16 15:04:49 +02:00
Eliot Berriot 8b202d49c9 Merge branch '312-radios-delete' into 'develop'
radios permissions

Closes #311

See merge request funkwhale/funkwhale!257
2018-06-16 12:53:18 +00:00
Eliot Berriot 98e3bb9cfc
Fix #311: Ensure radios can only be edited and deleted by their owners 2018-06-16 14:47:34 +02:00
Eliot Berriot b14b8ade6d Merge branch 'fixdoc' into 'develop'
Fix MUSIC_DIRECTORY_SERVE_PATH example value in configuration.rst

See merge request funkwhale/funkwhale!255
2018-06-14 18:55:09 +00:00
Eliot Berriot a662b9dc83 Merge branch 'dockerFederation' into 'develop'
Fix CONTRIBUTING

See merge request funkwhale/funkwhale!254
2018-06-14 09:58:04 +00:00
RenonDis 746f1b0883 Fix CONTRIBUTING 2018-06-14 11:53:15 +02:00
Eliot Berriot fde28c2129 Merge branch 'wssApache' into 'develop'
Updated apache2 conf file for websockets

See merge request funkwhale/funkwhale!252
2018-06-14 07:36:02 +00:00
RenonDis ae4a470145 Details in changelog
Fix changelog
2018-06-14 09:20:05 +02:00
RenonDis 070ad9615f Updated apache2 conf file for websockets 2018-06-14 09:19:11 +02:00
Eliot Berriot c6b04ee5f1 Merge branch 'dev-setup' into 'develop'
Fixed bad order in contributing instructions

See merge request funkwhale/funkwhale!253
2018-06-13 16:34:15 +00:00
Eliot Berriot 6656573a83
Fixed bad order in contributing instructions 2018-06-13 18:30:06 +02:00
Eliot Berriot 232d9ca86e Merge branch 'jd-improve-inplace-docs' into 'develop'
Improve doc about in-place imports setup

Closes #298

See merge request funkwhale/funkwhale!249
2018-06-13 14:05:48 +00:00
Eliot Berriot e3f3a9b644 Merge branch 'fixLicense' into 'develop'
fix license on README

See merge request funkwhale/funkwhale!251
2018-06-13 14:02:41 +00:00
Julien Veyssier a1819aa8ad Fix MUSIC_DIRECTORY_SERVE_PATH example value in configuration.rst 2018-06-13 13:55:44 +00:00
Jocelyn Delalande 4e9aa16d05 Better document MUSIC_DIRECTORY_PATH 2018-06-12 20:58:47 +02:00
RenonDis fac81f8da0 fix license on README 2018-06-12 09:58:48 +02:00
Eliot Berriot c6b79bcd75 Merge branch '287-websocket' into 'develop'
Resolve "Display bug in Activity"

Closes #287

See merge request funkwhale/funkwhale!250
2018-06-11 20:51:15 +00:00
Eliot Berriot ef224e9fe9
Fixed #287: duplicated websocket connexion on timeline 2018-06-11 22:47:00 +02:00
Eliot Berriot d544ae3c1b Merge branch 'troll-develop-patch-82829' into 'develop'
+ Pour aligner l’icône (artistes) au centre du cercle violet.

See merge request funkwhale/funkwhale!247
2018-06-11 16:24:57 +00:00
Eliot Berriot 1823554bbc Merge branch '262-shuffle-feedback' into 'develop'
Resolve "No feedback on the shuffle button"

Closes #262

See merge request funkwhale/funkwhale!238
2018-06-11 16:20:37 +00:00
Jocelyn Delalande f13a1d2445 Remove obsolete /_protected/media config
See https://code.eliotberriot.com/funkwhale/funkwhale/issues/298#note_3314

ref #298
2018-06-10 22:49:36 +02:00
Jocelyn Delalande a72479b0c9 Fix letsencrypt-apache URL 2018-06-10 22:48:20 +02:00
Eliot Berriot 2fb8f0333a Merge branch 'patch-1' into 'develop'
Stop giving too much hope on Debian 8 compatibility

Closes #300

See merge request funkwhale/funkwhale!248
2018-06-10 19:55:19 +00:00
JocelynDelalande 91a1c7108b Stop giving too much hope on Debian 8 compatibility
FW requires Python>=3.5 ; only Python 3.4 is packaged in Debian 8.

fix #300
2018-06-10 19:48:16 +00:00
troll 30a519f598 + Pour aligner l’icône (artistes) au centre du cercle violet.
+ Pour espacer les boutons:
- start radio
- play all albums
- search on wikipedia
- view on MusicBrainz

quand le navigateur est réduit car les boutons étaient collés les uns aux autres.
2018-06-10 19:28:33 +00:00
Eliot Berriot ed305a2c7c
Fixed broken configure 2018-06-10 18:59:40 +02:00
Eliot Berriot a2f2226450 Merge branch '245-admin-menu' into 'develop'
Resolve "Disappearing admin menu in the sidebar"

Closes #245

See merge request funkwhale/funkwhale!245
2018-06-10 12:30:52 +00:00
Eliot Berriot 946401fd61 Merge branch 'fix-changelog' into 'develop'
Fixed #289: wrong changelog

Closes #289

See merge request funkwhale/funkwhale!246
2018-06-10 12:29:06 +00:00
Eliot Berriot 9f18b95069
Fixed #245: admin menu not showing after login 2018-06-10 14:25:22 +02:00
Eliot Berriot f3c0f1e6ed
Fixed #289: wrong changelog 2018-06-10 14:21:43 +02:00
Eliot Berriot c48809bf22 Merge branch '295-subsonic-pagination' into 'develop'
Resolve "Fix broken pagination in Subsonic getAlbumlist2"

Closes #295

See merge request funkwhale/funkwhale!244
2018-06-10 11:46:32 +00:00
Eliot Berriot 031784556f
Fixed #295: broken pagination in Subsonic API 2018-06-10 13:34:15 +02:00
Eliot Berriot 5009a5d0cc
See #262: lighter message blue, reversed order, less messages 2018-06-10 13:09:31 +02:00
Eliot Berriot fd5c19163b
See #262: added message feedback on play button 2018-06-10 13:00:08 +02:00
Eliot Berriot f8de5c2f00
Fix #262: added feedback on shuffle button 2018-06-10 13:00:08 +02:00
Eliot Berriot 3634c00ee6
See #262: light messaging area and helpers for the front-end 2018-06-10 13:00:07 +02:00
Eliot Berriot 4c81de9226 Merge branch '299-issue-templates' into 'develop'
Resolve "Add some issue templates"

Closes #299

See merge request funkwhale/funkwhale!243
2018-06-10 10:54:33 +00:00
Eliot Berriot 2b0f7f6db3 Merge branch '297-linting' into 'develop'
Resolve "Add some linting for Python code"

Closes #297

See merge request funkwhale/funkwhale!242
2018-06-10 10:50:35 +00:00
Eliot Berriot 1f5e596883
Fix #299: Added bug and feature issue templates 2018-06-10 12:50:06 +02:00
Eliot Berriot 7f5e9d6404
Fix #297: changelog 2018-06-10 12:14:39 +02:00
Eliot Berriot 77c0b2b1a2
See #297: added black as a local dependency, more verbose check in CI 2018-06-10 12:13:02 +02:00
Eliot Berriot d17ceec1f0
See #297: linting of various, uncommon errors 2018-06-10 12:06:46 +02:00
Eliot Berriot ab80dffeea
See #297: sorted config imports 2018-06-10 11:29:24 +02:00