Merge pull request #8805 from MrPetovan/bug/notices

Add logging to rare condition in Model\Profile::sidebar

src/Model/Profile.php

@@ -258,7 +258,7 @@ class Profile
 	 * @hooks 'profile_sidebar'
 	 *      array $arr
 	 */
-	private static function sidebar(App $a, $profile, $block = 0, $show_connect = true)
+	private static function sidebar(App $a, array $profile, $block = 0, $show_connect = true)
 	{
 		$o = '';
 		$location = false;
@@ -266,7 +266,8 @@ class Profile
 		// This function can also use contact information in $profile
 		$is_contact = !empty($profile['cid']);
 
-		if (!is_array($profile) && !count($profile)) {
+		if (empty($profile['nickname'])) {
+			Logger::warning('Received profile with no nickname', ['profile' => $profile, 'callstack' => System::callstack(10)]);
 			return $o;
 		}
 
@@ -291,8 +292,6 @@ class Profile
 		$subscribe_feed_link = null;
 		$wallmessage_link = null;
 
-
-
 		$visitor_contact = [];
 		if (!empty($profile['uid']) && self::getMyURL()) {
 			$visitor_contact = Contact::selectFirst(['rel'], ['uid' => $profile['uid'], 'nurl' => Strings::normaliseLink(self::getMyURL())]);