From 192576f01aa8547cecaba05aa18d9a47d80443b4 Mon Sep 17 00:00:00 2001 From: Hypolite Petovan Date: Wed, 24 Jun 2020 09:56:11 -0400 Subject: [PATCH] Add logging to rare condition in Model\Profile::sidebar - Adresses https://github.com/friendica/friendica/issues/8475#issuecomment-647104375 --- src/Model/Profile.php | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/Model/Profile.php b/src/Model/Profile.php index 2b1546db49..2fcbde0779 100644 --- a/src/Model/Profile.php +++ b/src/Model/Profile.php @@ -258,7 +258,7 @@ class Profile * @hooks 'profile_sidebar' * array $arr */ - private static function sidebar(App $a, $profile, $block = 0, $show_connect = true) + private static function sidebar(App $a, array $profile, $block = 0, $show_connect = true) { $o = ''; $location = false; @@ -266,7 +266,8 @@ class Profile // This function can also use contact information in $profile $is_contact = !empty($profile['cid']); - if (!is_array($profile) && !count($profile)) { + if (empty($profile['nickname'])) { + Logger::warning('Received profile with no nickname', ['profile' => $profile, 'callstack' => System::callstack(10)]); return $o; } @@ -291,8 +292,6 @@ class Profile $subscribe_feed_link = null; $wallmessage_link = null; - - $visitor_contact = []; if (!empty($profile['uid']) && self::getMyURL()) { $visitor_contact = Contact::selectFirst(['rel'], ['uid' => $profile['uid'], 'nurl' => Strings::normaliseLink(self::getMyURL())]);