Remove buffer falloff from GUI, set default = 0.5

CHANGELOG.md

@@ -2,7 +2,7 @@
 
 ### Breaking Changes
 
-...
+- Remove buffer falloff from GUI (defaults to 0.5)
 
 ### Features
 

corrscope/corrscope.py

@@ -121,7 +121,6 @@ def default_config(**kwargs) -> Config:
         trigger=CorrelationTriggerConfig(
             edge_strength=2,
             responsiveness=0.5,
-            buffer_falloff=0.5,
             pitch_tracking=SpectrumConfig(),
             # post_trigger=ZeroCrossingTriggerConfig(),
         ),

corrscope/gui/__init__.py

@@ -831,7 +831,6 @@ class ChannelModel(qc.QAbstractTableModel):
         Column("trigger__edge_direction", plus_minus_one, None),
         Column("trigger__edge_strength", float, None),
         Column("trigger__responsiveness", float, None),
-        Column("trigger__buffer_falloff", float, None),
     ]
 
     idx_of_key = {}

corrscope/gui/view_mainwindow.py

@@ -272,11 +272,6 @@ class MainWindow(QWidget):
                         self.trigger__responsiveness.setMaximum(1.0)
                         self.trigger__responsiveness.setSingleStep(0.1)
 
-                    with add_grid_col(s, "", BoundDoubleSpinBox) as (
-                        self.trigger__buffer_falloff
-                    ):
-                        self.trigger__buffer_falloff.setSingleStep(0.5)
-
                 with append_widget(s, HLine):
                     pass
 
@@ -407,7 +402,6 @@ class MainWindow(QWidget):
         self.optionTrigger.setTitle(tr("Trigger"))
         self.trigger__edge_strengthL.setText(tr("Edge Strength"))
         self.trigger__responsivenessL.setText(tr("Responsiveness"))
-        self.trigger__buffer_falloffL.setText(tr("Buffer Falloff"))
         self.trigger__pitch_tracking.setText(tr("Pitch Tracking"))
         self.trigger__edge_directionL.setText(tr("Edge Direction"))
 

corrscope/triggers.py

@@ -356,7 +356,7 @@ class CorrelationTriggerConfig(MainTriggerConfig, always_dump="pitch_tracking"):
 
     # _update_buffer
     responsiveness: float
-    buffer_falloff: float  # Gaussian std = wave_period * buffer_falloff
+    buffer_falloff: float = 0.5  # Gaussian std = wave_period * buffer_falloff
 
     # Pitch tracking = compute spectrum.
     pitch_tracking: Optional["SpectrumConfig"] = None