diff --git a/CHANGELOG.md b/CHANGELOG.md index 1767172..af06e95 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,7 +2,7 @@ ### Breaking Changes -... +- Remove buffer falloff from GUI (defaults to 0.5) ### Features diff --git a/corrscope/corrscope.py b/corrscope/corrscope.py index 507c280..a95581a 100644 --- a/corrscope/corrscope.py +++ b/corrscope/corrscope.py @@ -121,7 +121,6 @@ def default_config(**kwargs) -> Config: trigger=CorrelationTriggerConfig( edge_strength=2, responsiveness=0.5, - buffer_falloff=0.5, pitch_tracking=SpectrumConfig(), # post_trigger=ZeroCrossingTriggerConfig(), ), diff --git a/corrscope/gui/__init__.py b/corrscope/gui/__init__.py index 540a81f..dc3cc7a 100644 --- a/corrscope/gui/__init__.py +++ b/corrscope/gui/__init__.py @@ -831,7 +831,6 @@ class ChannelModel(qc.QAbstractTableModel): Column("trigger__edge_direction", plus_minus_one, None), Column("trigger__edge_strength", float, None), Column("trigger__responsiveness", float, None), - Column("trigger__buffer_falloff", float, None), ] idx_of_key = {} diff --git a/corrscope/gui/view_mainwindow.py b/corrscope/gui/view_mainwindow.py index 6f862df..1feefdd 100644 --- a/corrscope/gui/view_mainwindow.py +++ b/corrscope/gui/view_mainwindow.py @@ -272,11 +272,6 @@ class MainWindow(QWidget): self.trigger__responsiveness.setMaximum(1.0) self.trigger__responsiveness.setSingleStep(0.1) - with add_grid_col(s, "", BoundDoubleSpinBox) as ( - self.trigger__buffer_falloff - ): - self.trigger__buffer_falloff.setSingleStep(0.5) - with append_widget(s, HLine): pass @@ -407,7 +402,6 @@ class MainWindow(QWidget): self.optionTrigger.setTitle(tr("Trigger")) self.trigger__edge_strengthL.setText(tr("Edge Strength")) self.trigger__responsivenessL.setText(tr("Responsiveness")) - self.trigger__buffer_falloffL.setText(tr("Buffer Falloff")) self.trigger__pitch_tracking.setText(tr("Pitch Tracking")) self.trigger__edge_directionL.setText(tr("Edge Direction")) diff --git a/corrscope/triggers.py b/corrscope/triggers.py index 08d5e2a..cda7b47 100644 --- a/corrscope/triggers.py +++ b/corrscope/triggers.py @@ -356,7 +356,7 @@ class CorrelationTriggerConfig(MainTriggerConfig, always_dump="pitch_tracking"): # _update_buffer responsiveness: float - buffer_falloff: float # Gaussian std = wave_period * buffer_falloff + buffer_falloff: float = 0.5 # Gaussian std = wave_period * buffer_falloff # Pitch tracking = compute spectrum. pitch_tracking: Optional["SpectrumConfig"] = None