kopia lustrzana https://github.com/Tldraw/Tldraw
0b44a8b47a
Fixes culling for cases when another user would drag shapes inside your viewport. We weren't correctly calculating the culling status for arrows that might be bound to those shapes and also for shapes within dragged in groups / frames. ### Change Type <!-- ❗ Please select a 'Scope' label ❗️ --> - [ ] `sdk` — Changes the tldraw SDK - [ ] `dotcom` — Changes the tldraw.com web app - [ ] `docs` — Changes to the documentation, examples, or templates. - [ ] `vs code` — Changes to the vscode plugin - [x] `internal` — Does not affect user-facing stuff <!-- ❗ Please select a 'Type' label ❗️ --> - [x] `bugfix` — Bug fix - [ ] `feature` — New feature - [ ] `improvement` — Improving existing features - [ ] `chore` — Updating dependencies, other boring stuff - [ ] `galaxy brain` — Architectural changes - [ ] `tests` — Changes to any test code - [ ] `tools` — Changes to infrastructure, CI, internal scripts, debugging tools, etc. - [ ] `dunno` — I don't know ### Test Plan 1. Open the same room in two browsers / tabs. 2. Have some shapes that are visible in one browser, but not the other. 3. Drag these shapes so that they are visible in the other browser as well. 4. They should correctly get unculled. 5. Do this by dragging shapes that have arrows bound to them (arrows should uncull), groups (shapes within them should uncull), frames. - [x] Unit Tests - [ ] End to end tests ### Release Notes - Fix culling. |
||
|---|---|---|
| .. | ||
| __snapshots__ | ||
| commands | ||
| perf | ||
| testutils | ||
| ui | ||
| ClickManager.test.ts | ||
| Editor.test.tsx | ||
| EraserTool.test.ts | ||
| HandTool.test.ts | ||
| HighlightShape.test.ts | ||
| LaserTool.test.ts | ||
| SelectTool.test.ts | ||
| TLSessionStateSnapshot.test.ts | ||
| TLUserPreferences.test.ts | ||
| TestEditor.test.ts | ||
| TestEditor.ts | ||
| TldrawEditor.test.tsx | ||
| ZoomTool.test.ts | ||
| arrowBindingsIndex.test.tsx | ||
| arrows-megabus.test.tsx | ||
| assets.test.ts | ||
| bookmark-shapes.test.ts | ||
| cleanup.test.ts | ||
| cropping.test.ts | ||
| customSnapping.test.tsx | ||
| drawing.test.ts | ||
| duplicate.test.ts | ||
| flipShapes.test.ts | ||
| frames.test.ts | ||
| getCulledShapes.test.tsx | ||
| getShapeAtPoint.test.ts | ||
| getSnapLines.ts | ||
| groups.test.ts | ||
| middleMouseButtonPanning.test.ts | ||
| modifiers.test.ts | ||
| panning.test.ts | ||
| parentsToChildrenWithIndexes.test.ts | ||
| paste.test.ts | ||
| renderingShapes.test.tsx | ||
| resizeBox.test.ts | ||
| resizing.test.ts | ||
| rotating.test.ts | ||
| roundedBox.ts | ||
| select.test.tsx | ||
| selection-omnibus.test.ts | ||
| shapeIdsInCurrentPage.test.ts | ||
| shapeutils.test.ts | ||
| spacebarPanning.test.ts | ||
| styles2.test.tsx | ||
| styles3.test.ts | ||
| test-jsx.tsx | ||
| text.test.ts | ||
| translating.test.ts | ||
| viewport-following.test.ts | ||