mirror
/
RadioLib
kopia lustrzana https://github.com/jgromes/RadioLib
1
0
Forkuj 0
Kod Zgłoszenia Projekty Wydania Wiki Aktywność

[SX128x] Add missing register write when setting SF (#1549)

pull/1557/head
jgromes 2025-07-01 19:55:51 +02:00
rodzic 5f73a87a3a
commit 32c3570ad3
1 zmienionych plików z 10 dodań i 1 usunięć
Pokaż statystyki Ściągnij plik aktualizacji Ściągnij plik porównania Expand all files Collapse all files

11
src/modules/SX128x/SX128x.cpp
Wyświetl plik

@ -695,7 +695,7 @@ int16_t SX128x::setSpreadingFactor(uint8_t sf) {
int16_t state = setModulationParams(this->spreadingFactor, this->bandwidth, this->codingRateLoRa); int16_t state = setModulationParams(this->spreadingFactor, this->bandwidth, this->codingRateLoRa);
RADIOLIB_ASSERT(state); RADIOLIB_ASSERT(state);
// update mystery register in LoRa mode - SX1280 datasheet v3.0 section 13.4.1 // update mystery register in LoRa mode - SX1280 datasheet rev 3.2 section 14.4.1
if(modem == RADIOLIB_SX128X_PACKET_TYPE_LORA) { if(modem == RADIOLIB_SX128X_PACKET_TYPE_LORA) {
uint8_t data = 0; uint8_t data = 0;
if((this->spreadingFactor == RADIOLIB_SX128X_LORA_SF_5) || (this->spreadingFactor == RADIOLIB_SX128X_LORA_SF_6)) { if((this->spreadingFactor == RADIOLIB_SX128X_LORA_SF_5) || (this->spreadingFactor == RADIOLIB_SX128X_LORA_SF_6)) {
@ -706,6 +706,15 @@ int16_t SX128x::setSpreadingFactor(uint8_t sf) {
data = 0x32; data = 0x32;
} }
state = SX128x::writeRegister(RADIOLIB_SX128X_REG_LORA_SF_CONFIG, &data, 1); state = SX128x::writeRegister(RADIOLIB_SX128X_REG_LORA_SF_CONFIG, &data, 1);
RADIOLIB_ASSERT(state);
// this register must also be updated for some reason
state = SX128x::readRegister(RADIOLIB_SX128X_REG_FREQ_ERROR_CORRECTION, &data, 1);
RADIOLIB_ASSERT(state);
data |= 0x01;
state = SX128x::writeRegister(RADIOLIB_SX128X_REG_FREQ_ERROR_CORRECTION, &data, 1);
RADIOLIB_ASSERT(state);
} }
return(state); return(state);