kopia lustrzana https://github.com/OpenDroneMap/WebODM
More tasks testing (currently failing)
Piero Toffanin
rodzic
fa843be5fc
commit
792eee94e5
|
|
@ -126,6 +126,12 @@ class TaskViewSet(viewsets.ViewSet):
|
|||
|
||||
task = models.Task.create_from_images(files, project)
|
||||
if task is not None:
|
||||
|
||||
# Update other parameters such as processing node, task name, etc.
|
||||
serializer = TaskSerializer(task, data=request.data, partial=True)
|
||||
serializer.is_valid(raise_exception=True)
|
||||
serializer.save()
|
||||
|
||||
return Response({"id": task.id}, status=status.HTTP_201_CREATED)
|
||||
else:
|
||||
raise exceptions.ValidationError(detail="Cannot create task, input provided is not valid.")
|
||||
|
|
|
|||
|
|
@ -1,21 +1,12 @@
|
|||
from django import db
|
||||
from django.contrib.auth.models import User
|
||||
from django.test import TestCase
|
||||
from django.test import TransactionTestCase
|
||||
|
||||
from app.boot import boot
|
||||
from app.models import Project
|
||||
|
||||
|
||||
class BootTestCase(TestCase):
|
||||
'''
|
||||
This class provides optional default mock data as well as
|
||||
proper boot initialization code. All tests for the app
|
||||
module should derive from this class instead of TestCase.
|
||||
|
||||
We don't use fixtures because we have signal initialization login
|
||||
for some models, which doesn't play well with them.
|
||||
'''
|
||||
@classmethod
|
||||
def setUpClass(cls):
|
||||
def setupUsers():
|
||||
User.objects.create_superuser(username='testsuperuser',
|
||||
email='superuser@test.com',
|
||||
|
|
@ -27,6 +18,7 @@ class BootTestCase(TestCase):
|
|||
email='user2@test.com',
|
||||
password='test1234')
|
||||
|
||||
|
||||
def setupProjects():
|
||||
Project.objects.create(
|
||||
owner=User.objects.get(username="testsuperuser"),
|
||||
|
|
@ -44,7 +36,18 @@ class BootTestCase(TestCase):
|
|||
description="This is a test project"
|
||||
)
|
||||
|
||||
super(BootTestCase, cls).setUpClass()
|
||||
class BootTestCase(TestCase):
|
||||
'''
|
||||
This class provides optional default mock data as well as
|
||||
proper boot initialization code. All tests for the app
|
||||
module should derive from this class instead of TestCase.
|
||||
|
||||
We don't use fixtures because we have signal initialization login
|
||||
for some models, which doesn't play well with them.
|
||||
'''
|
||||
@classmethod
|
||||
def setUpTestData(cls):
|
||||
super(BootTestCase, cls).setUpTestData()
|
||||
boot()
|
||||
setupUsers()
|
||||
setupProjects()
|
||||
|
|
@ -52,3 +55,18 @@ class BootTestCase(TestCase):
|
|||
@classmethod
|
||||
def tearDownClass(cls):
|
||||
super(BootTestCase, cls).tearDownClass()
|
||||
|
||||
class BootTransactionTestCase(TransactionTestCase):
|
||||
'''
|
||||
Same as above, but inherits from TransactionTestCase
|
||||
'''
|
||||
@classmethod
|
||||
def setUpClass(cls):
|
||||
super(BootTransactionTestCase, cls).setUpClass()
|
||||
boot()
|
||||
setupUsers()
|
||||
setupProjects()
|
||||
|
||||
@classmethod
|
||||
def tearDownClass(cls):
|
||||
super(BootTransactionTestCase, cls).tearDownClass()
|
||||
|
|
|
|||
|
|
@ -222,151 +222,6 @@ class TestApi(BootTestCase):
|
|||
# TODO test:
|
||||
# - scheduler processing steps
|
||||
|
||||
def test_task(self):
|
||||
DELAY = 5 # time to sleep for during process launch, background processing, etc.
|
||||
client = APIClient()
|
||||
|
||||
user = User.objects.get(username="testuser")
|
||||
other_user = User.objects.get(username="testuser2")
|
||||
project = Project.objects.create(
|
||||
owner=user,
|
||||
name="test project"
|
||||
)
|
||||
other_project = Project.objects.create(
|
||||
owner=User.objects.get(username="testuser2"),
|
||||
name="another test project"
|
||||
)
|
||||
other_task = Task.objects.create(project=other_project)
|
||||
|
||||
# task creation via file upload
|
||||
image1 = open("app/fixtures/tiny_drone_image.jpg", 'rb')
|
||||
image2 = open("app/fixtures/tiny_drone_image_2.jpg", 'rb')
|
||||
|
||||
# Not authenticated?
|
||||
res = client.post("/api/projects/{}/tasks/".format(project.id), {
|
||||
'images': [image1, image2]
|
||||
}, format="multipart")
|
||||
self.assertTrue(res.status_code == status.HTTP_403_FORBIDDEN);
|
||||
|
||||
client.login(username="testuser", password="test1234")
|
||||
|
||||
# Cannot create a task for a project that does not exist
|
||||
res = client.post("/api/projects/0/tasks/", {
|
||||
'images': [image1, image2]
|
||||
}, format="multipart")
|
||||
self.assertTrue(res.status_code == status.HTTP_404_NOT_FOUND)
|
||||
|
||||
# Cannot create a task for a project for which we have no access to
|
||||
res = client.post("/api/projects/{}/tasks/".format(other_project.id), {
|
||||
'images': [image1, image2]
|
||||
}, format="multipart")
|
||||
self.assertTrue(res.status_code == status.HTTP_404_NOT_FOUND)
|
||||
|
||||
# Cannot create a task without images
|
||||
res = client.post("/api/projects/{}/tasks/".format(project.id), {
|
||||
'images': []
|
||||
}, format="multipart")
|
||||
self.assertTrue(res.status_code == status.HTTP_400_BAD_REQUEST)
|
||||
|
||||
# Cannot create a task with just 1 image
|
||||
res = client.post("/api/projects/{}/tasks/".format(project.id), {
|
||||
'images': image1
|
||||
}, format="multipart")
|
||||
self.assertTrue(res.status_code == status.HTTP_400_BAD_REQUEST)
|
||||
|
||||
# Normal case with just images[] parameter
|
||||
res = client.post("/api/projects/{}/tasks/".format(project.id), {
|
||||
'images': [image1, image2]
|
||||
}, format="multipart")
|
||||
self.assertTrue(res.status_code == status.HTTP_201_CREATED)
|
||||
|
||||
# Should have returned the id of the newly created task
|
||||
task = Task.objects.latest('created_at')
|
||||
self.assertTrue('id' in res.data)
|
||||
self.assertTrue(task.id == res.data['id'])
|
||||
|
||||
# Two images should have been uploaded
|
||||
self.assertTrue(ImageUpload.objects.filter(task=task).count() == 2)
|
||||
|
||||
# No processing node is set
|
||||
self.assertTrue(task.processing_node is None)
|
||||
|
||||
image1.close()
|
||||
image2.close()
|
||||
|
||||
# tiles.json should not be accessible at this point
|
||||
res = client.get("/api/projects/{}/tasks/{}/tiles.json".format(project.id, task.id))
|
||||
self.assertTrue(res.status_code == status.HTTP_400_BAD_REQUEST)
|
||||
|
||||
# Neither should an individual tile
|
||||
# Z/X/Y coords are choosen based on node-odm test dataset for orthophoto_tiles/
|
||||
res = client.get("/api/projects/{}/tasks/{}/tiles/16/16020/42443.png".format(project.id, task.id))
|
||||
self.assertTrue(res.status_code == status.HTTP_404_NOT_FOUND)
|
||||
|
||||
# Cannot access a tiles.json we have no access to
|
||||
res = client.get("/api/projects/{}/tasks/{}/tiles.json".format(other_project.id, other_task.id))
|
||||
self.assertTrue(res.status_code == status.HTTP_404_NOT_FOUND)
|
||||
|
||||
# Cannot access an individual tile we have no access to
|
||||
res = client.get("/api/projects/{}/tasks/{}/tiles/16/16020/42443.png".format(other_project.id, other_task.id))
|
||||
self.assertTrue(res.status_code == status.HTTP_404_NOT_FOUND)
|
||||
|
||||
# Cannot download assets (they don't exist yet)
|
||||
assets = ["all", "geotiff", "las", "csv", "ply"]
|
||||
|
||||
for asset in assets:
|
||||
res = client.get("/api/projects/{}/tasks/{}/download/{}/".format(project.id, task.id, asset))
|
||||
self.assertTrue(res.status_code == status.HTTP_404_NOT_FOUND)
|
||||
|
||||
# Cannot access raw assets (they don't exist yet)
|
||||
res = client.get("/api/projects/{}/tasks/{}/assets/odm_orthophoto/odm_orthophoto.tif".format(project.id, task.id))
|
||||
self.assertTrue(res.status_code == status.HTTP_404_NOT_FOUND)
|
||||
|
||||
# Start processing node
|
||||
current_dir = os.path.dirname(os.path.realpath(__file__))
|
||||
node_odm = subprocess.Popen(['node', 'index.js', '--port', '11223', '--test'], shell=False,
|
||||
cwd=os.path.join(current_dir, "..", "..", "nodeodm", "external", "node-OpenDroneMap"))
|
||||
time.sleep(DELAY) # Wait for the server to launch
|
||||
|
||||
# Create processing node
|
||||
pnode = ProcessingNode.objects.create(hostname="localhost", port=11223)
|
||||
|
||||
# Verify that it's working
|
||||
self.assertTrue(pnode.api_version is not None)
|
||||
|
||||
# Cannot assign processing node to a task we have no access to
|
||||
res = client.patch("/api/projects/{}/tasks/{}/".format(other_project.id, other_task.id), {
|
||||
'processing_node': pnode.id
|
||||
})
|
||||
self.assertTrue(res.status_code == status.HTTP_404_NOT_FOUND)
|
||||
|
||||
# Assign processing node to task via API
|
||||
res = client.patch("/api/projects/{}/tasks/{}/".format(project.id, task.id), {
|
||||
'processing_node': pnode.id
|
||||
})
|
||||
self.assertTrue(res.status_code == status.HTTP_200_OK)
|
||||
|
||||
# After a processing node has been assigned, the task processing should start
|
||||
#time.sleep(DELAY)
|
||||
|
||||
# Processing should have completed
|
||||
#task.refresh_from_db()
|
||||
#self.assertTrue(task.status == status_codes.COMPLETED)
|
||||
|
||||
# TODO: background tasks do not properly talk to the database
|
||||
# Task table is always empty when read from a separate Thread. Why?
|
||||
# from app import scheduler
|
||||
# scheduler.process_pending_tasks(background=True)
|
||||
|
||||
#time.sleep(3)
|
||||
|
||||
# TODO: check
|
||||
# TODO: what happens when nodes go offline, or an offline node is assigned to a task
|
||||
# TODO: check raw/non-raw assets once task is finished processing
|
||||
# TODO: recheck tiles, tiles.json urls, etc.
|
||||
|
||||
# Teardown processing node
|
||||
node_odm.terminate()
|
||||
|
||||
def test_processingnodes(self):
|
||||
client = APIClient()
|
||||
|
|
|
|||
|
|
@ -0,0 +1,193 @@
|
|||
import os
|
||||
import subprocess
|
||||
|
||||
import time
|
||||
|
||||
from django import db
|
||||
from django.contrib.auth.models import User
|
||||
from rest_framework import status
|
||||
from rest_framework.test import APIClient
|
||||
|
||||
from app import scheduler
|
||||
from app.models import Project, Task, ImageUpload
|
||||
from app.tests.classes import BootTransactionTestCase
|
||||
from nodeodm import status_codes
|
||||
from nodeodm.models import ProcessingNode
|
||||
|
||||
# We need to test the task API in a TransactionTestCase because
|
||||
# processing happens on a separate thread. This is required by Django.
|
||||
class TestApi(BootTransactionTestCase):
|
||||
def test_task(self):
|
||||
DELAY = 1 # time to sleep for during process launch, background processing, etc.
|
||||
client = APIClient()
|
||||
|
||||
user = User.objects.get(username="testuser")
|
||||
self.assertFalse(user.is_superuser)
|
||||
|
||||
other_user = User.objects.get(username="testuser2")
|
||||
|
||||
project = Project.objects.create(
|
||||
owner=user,
|
||||
name="test project"
|
||||
)
|
||||
other_project = Project.objects.create(
|
||||
owner=other_user,
|
||||
name="another test project"
|
||||
)
|
||||
other_task = Task.objects.create(project=other_project)
|
||||
|
||||
# Start processing node
|
||||
current_dir = os.path.dirname(os.path.realpath(__file__))
|
||||
node_odm = subprocess.Popen(['node', 'index.js', '--port', '11223', '--test'], shell=False,
|
||||
cwd=os.path.join(current_dir, "..", "..", "nodeodm", "external", "node-OpenDroneMap"))
|
||||
time.sleep(DELAY) # Wait for the server to launch
|
||||
|
||||
# Create processing node
|
||||
pnode = ProcessingNode.objects.create(hostname="localhost", port=11223)
|
||||
|
||||
# Verify that it's working
|
||||
self.assertTrue(pnode.api_version is not None)
|
||||
|
||||
# task creation via file upload
|
||||
image1 = open("app/fixtures/tiny_drone_image.jpg", 'rb')
|
||||
image2 = open("app/fixtures/tiny_drone_image_2.jpg", 'rb')
|
||||
|
||||
# Not authenticated?
|
||||
res = client.post("/api/projects/{}/tasks/".format(project.id), {
|
||||
'images': [image1, image2]
|
||||
}, format="multipart")
|
||||
self.assertTrue(res.status_code == status.HTTP_403_FORBIDDEN);
|
||||
|
||||
client.login(username="testuser", password="test1234")
|
||||
|
||||
# Cannot create a task for a project that does not exist
|
||||
res = client.post("/api/projects/0/tasks/", {
|
||||
'images': [image1, image2]
|
||||
}, format="multipart")
|
||||
print(res.status_code)
|
||||
self.assertTrue(res.status_code == status.HTTP_404_NOT_FOUND)
|
||||
|
||||
# Cannot create a task for a project for which we have no access to
|
||||
res = client.post("/api/projects/{}/tasks/".format(other_project.id), {
|
||||
'images': [image1, image2]
|
||||
}, format="multipart")
|
||||
self.assertTrue(res.status_code == status.HTTP_404_NOT_FOUND)
|
||||
|
||||
# Cannot create a task without images
|
||||
res = client.post("/api/projects/{}/tasks/".format(project.id), {
|
||||
'images': []
|
||||
}, format="multipart")
|
||||
self.assertTrue(res.status_code == status.HTTP_400_BAD_REQUEST)
|
||||
|
||||
# Cannot create a task with just 1 image
|
||||
res = client.post("/api/projects/{}/tasks/".format(project.id), {
|
||||
'images': image1
|
||||
}, format="multipart")
|
||||
self.assertTrue(res.status_code == status.HTTP_400_BAD_REQUEST)
|
||||
|
||||
# Normal case with images[], name and processing node parameter
|
||||
res = client.post("/api/projects/{}/tasks/".format(project.id), {
|
||||
'images': [image1, image2],
|
||||
'name': 'test_task',
|
||||
'processing_node': pnode.id
|
||||
}, format="multipart")
|
||||
self.assertTrue(res.status_code == status.HTTP_201_CREATED)
|
||||
multiple_param_task = Task.objects.latest('created_at')
|
||||
self.assertTrue(multiple_param_task.name == 'test_task')
|
||||
self.assertTrue(multiple_param_task.processing_node.id == pnode.id)
|
||||
|
||||
# Cannot create a task with images[], name, but invalid processing node parameter
|
||||
res = client.post("/api/projects/{}/tasks/".format(project.id), {
|
||||
'images': [image1, image2],
|
||||
'name': 'test_task',
|
||||
'processing_node': 9999
|
||||
}, format="multipart")
|
||||
self.assertTrue(res.status_code == status.HTTP_400_BAD_REQUEST)
|
||||
|
||||
# Normal case with just images[] parameter
|
||||
res = client.post("/api/projects/{}/tasks/".format(project.id), {
|
||||
'images': [image1, image2]
|
||||
}, format="multipart")
|
||||
self.assertTrue(res.status_code == status.HTTP_201_CREATED)
|
||||
|
||||
# Should have returned the id of the newly created task
|
||||
task = Task.objects.latest('created_at')
|
||||
self.assertTrue('id' in res.data)
|
||||
self.assertTrue(task.id == res.data['id'])
|
||||
|
||||
# Two images should have been uploaded
|
||||
self.assertTrue(ImageUpload.objects.filter(task=task).count() == 2)
|
||||
|
||||
# No processing node is set
|
||||
self.assertTrue(task.processing_node is None)
|
||||
|
||||
image1.close()
|
||||
image2.close()
|
||||
|
||||
# tiles.json should not be accessible at this point
|
||||
res = client.get("/api/projects/{}/tasks/{}/tiles.json".format(project.id, task.id))
|
||||
self.assertTrue(res.status_code == status.HTTP_400_BAD_REQUEST)
|
||||
|
||||
# Neither should an individual tile
|
||||
# Z/X/Y coords are choosen based on node-odm test dataset for orthophoto_tiles/
|
||||
res = client.get("/api/projects/{}/tasks/{}/tiles/16/16020/42443.png".format(project.id, task.id))
|
||||
self.assertTrue(res.status_code == status.HTTP_404_NOT_FOUND)
|
||||
|
||||
# Cannot access a tiles.json we have no access to
|
||||
res = client.get("/api/projects/{}/tasks/{}/tiles.json".format(other_project.id, other_task.id))
|
||||
self.assertTrue(res.status_code == status.HTTP_404_NOT_FOUND)
|
||||
|
||||
# Cannot access an individual tile we have no access to
|
||||
res = client.get("/api/projects/{}/tasks/{}/tiles/16/16020/42443.png".format(other_project.id, other_task.id))
|
||||
self.assertTrue(res.status_code == status.HTTP_404_NOT_FOUND)
|
||||
|
||||
# Cannot download assets (they don't exist yet)
|
||||
assets = ["all", "geotiff", "las", "csv", "ply"]
|
||||
|
||||
for asset in assets:
|
||||
res = client.get("/api/projects/{}/tasks/{}/download/{}/".format(project.id, task.id, asset))
|
||||
self.assertTrue(res.status_code == status.HTTP_404_NOT_FOUND)
|
||||
|
||||
# Cannot access raw assets (they don't exist yet)
|
||||
res = client.get("/api/projects/{}/tasks/{}/assets/odm_orthophoto/odm_orthophoto.tif".format(project.id, task.id))
|
||||
self.assertTrue(res.status_code == status.HTTP_404_NOT_FOUND)
|
||||
|
||||
# Cannot assign processing node to a task we have no access to
|
||||
res = client.patch("/api/projects/{}/tasks/{}/".format(other_project.id, other_task.id), {
|
||||
'processing_node': pnode.id
|
||||
})
|
||||
self.assertTrue(res.status_code == status.HTTP_404_NOT_FOUND)
|
||||
|
||||
# Assign processing node to task via API
|
||||
res = client.patch("/api/projects/{}/tasks/{}/".format(project.id, task.id), {
|
||||
'processing_node': pnode.id
|
||||
})
|
||||
self.assertTrue(res.status_code == status.HTTP_200_OK)
|
||||
|
||||
# On update scheduler.processing_pending_tasks should have been called in the background
|
||||
time.sleep(DELAY)
|
||||
|
||||
# Processing should have completed
|
||||
task.refresh_from_db()
|
||||
self.assertTrue(task.status == status_codes.RUNNING)
|
||||
|
||||
|
||||
# TODO: need a way to prevent multithreaded code from executing
|
||||
# and a way to notify our test case that multithreaded code should have
|
||||
# executed
|
||||
|
||||
# TODO: at this point we might not even need a TransactionTestCase?
|
||||
|
||||
#from app import scheduler
|
||||
#scheduler.process_pending_tasks(background=True)
|
||||
|
||||
# time.sleep(3)
|
||||
|
||||
# TODO: check
|
||||
# TODO: what happens when nodes go offline, or an offline node is assigned to a task
|
||||
# TODO: check raw/non-raw assets once task is finished processing
|
||||
# TODO: recheck tiles, tiles.json urls, etc.
|
||||
|
||||
# Teardown processing node
|
||||
node_odm.terminate()
|
||||
time.sleep(20)
|
||||
|
|
@ -1 +1 @@
|
|||
Subproject commit 254ce04f55db521acbae1b38294d2ec65e3c8a09
|
||||
Subproject commit a25e688bcb31972671f3735efe17c0b1c32e6da4
|
||||
|
|
@ -91,10 +91,12 @@ class ProcessingNode(models.Model):
|
|||
except requests.exceptions.ConnectionError as e:
|
||||
raise ProcessingException(e)
|
||||
|
||||
if result['uuid']:
|
||||
if 'uuid' in result:
|
||||
return result['uuid']
|
||||
elif result['error']:
|
||||
elif 'error' in result:
|
||||
raise ProcessingException(result['error'])
|
||||
else:
|
||||
raise ProcessingException("Unexpected answer from server: {}".format(result))
|
||||
|
||||
@api
|
||||
def get_task_info(self, uuid):
|
||||
|
|
|
|||
Ładowanie…
Reference in New Issue