Do not delete projects when delete request is initiated by non-owners

pull/1285/head
Piero Toffanin 2023-01-25 10:32:53 -05:00
rodzic 6d58468be7
commit 0f7849990a
1 zmienionych plików z 15 dodań i 0 usunięć

Wyświetl plik

@ -136,3 +136,18 @@ class ProjectViewSet(viewsets.ModelViewSet):
return Response({'error': _("Invalid permissions")}, status=status.HTTP_400_BAD_REQUEST)
return Response({'success': True}, status=status.HTTP_200_OK)
def destroy(self, request, pk=None):
project = get_and_check_project(request, pk, ('delete_project', ))
# Owner? Delete the project
if project.owner == request.user:
return super().destroy(self, request, pk=pk)
else:
# Do not remove the project, simply remove all user's permissions to the project
# to avoid shared projects from being accidentally deleted
for p in ["add", "change", "delete", "view"]:
perm = p + "_project"
remove_perm(perm, request.user, project)
return Response(status=status.HTTP_204_NO_CONTENT)