Taylor Smock
b4a32e426c
GetDataRunnable: Move away from streams
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-06-02 13:08:52 -06:00
Taylor Smock
9e00328d33
Decrease allocations in various locations
...
With the changes from
325c169468bce987bd93e78da81b92c12e52d86f..2c11de9e3ca95e5ea26ba08b053692ff013eb728,
this reduces allocations due to MapWithAI cleanup methods
(on download) from 1.7 GB to 265 MB.
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-06-01 16:54:11 -06:00
Taylor Smock
7c3c0e72c2
MapWithAIDataUtils: Cleanup legacy methods
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-06-01 10:29:25 -06:00
Taylor Smock
2c11de9e3c
GetDataRunnable: Significantly reduce allocations from merging nodes
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-06-01 08:04:56 -06:00
Taylor Smock
c9beb019ef
GetDataRunnable: Various cleanups
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-06-01 08:04:56 -06:00
Taylor Smock
482ccffb8e
MapWithAIPreferenceHelper: Cache a property that is constantly hit
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-06-01 08:04:56 -06:00
Taylor Smock
844e67d5a1
MapWithAIDataUtils: Download inside a safe ForkJoinPool
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-06-01 08:04:56 -06:00
Taylor Smock
b350286a36
MapWithAIInfoTest: Add equals check
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-06-01 08:04:54 -06:00
Taylor Smock
7acae1ca7f
CountryUtils: Significantly reduce allocations by caching
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-05-31 16:10:40 -06:00
Taylor Smock
ebc1725a10
GetDataRunnable: Avoid allocations
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-05-31 14:47:47 -06:00
Taylor Smock
5a74db8351
MapWithAIPreferenceHelper: Avoid allocations by using specific property classes
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-05-31 14:45:37 -06:00
Taylor Smock
325c169468
Various fixups (mostly for parallelStream -> stream)
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-05-27 06:34:48 -06:00
Taylor Smock
d6914567c4
Fix a deadlock that could occur when downloading data
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-05-27 06:16:27 -06:00
Taylor Smock
f8723d9db4
ESRISourceReader: Directly submit ForkJoinTasks to safe ForkJoinPool
...
This fixes JOSM #22077 , which was caused by ForkJoinTask#fork submitting
the task to ForkJoinPool#commonPool, when not called inside a
ForkJoinPool. This is problematic under WebStart.
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-05-18 08:25:40 -06:00
Taylor Smock
10a821f794
MapWithAIPlugin: Call addDownloadSelection in tests
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-05-16 16:41:58 -06:00
Taylor Smock
1dc1f18e8e
ESRI: Get data in a ForkJoinPool (significant speedup)
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-05-16 16:02:29 -06:00
Taylor Smock
5aa3843271
Fix some javadoc issues
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-05-16 16:02:23 -06:00
Taylor Smock
1ff3296863
MapWithAILayerInfo: Fix EDT violation
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-05-16 15:07:20 -06:00
Taylor Smock
6c9e6c6719
Add test for remote icons
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-05-16 14:50:32 -06:00
Taylor Smock
0d24b66fd7
Fix issue with UI blocking
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-05-13 08:53:20 -06:00
Taylor Smock
5a265e6520
MapWithAIPlugin: initialize download option when user first starts download
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-05-13 08:36:20 -06:00
Taylor Smock
cfceddfb49
Dependency updates
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-05-12 13:03:18 -06:00
Taylor Smock
5c33179163
CI: Update for GitLab 15.0
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-05-12 12:23:49 -06:00
Taylor Smock
42aec40b25
MapWithAIInfo: Fix an issue where users would be unable to file bug reports
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-05-12 12:21:55 -06:00
Taylor Smock
52724d0ab7
Fix JOSM #21872 : NPE in MapWithAIProvidersPanel
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-03-23 12:20:37 -06:00
Taylor Smock
8056a8c09c
Dependency updates
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-03-10 08:51:32 -07:00
Taylor Smock
623d2dc6a8
MapWithAIInfo: Use conflate setting in addition to conflate
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-03-10 08:51:22 -07:00
Taylor Smock
960eb784e1
Commands: Add tests for participating primitives (partial)
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-03-02 14:26:40 -07:00
Taylor Smock
efca56d2b6
Use JMockit from JOSM to fixe AIOOBE in tests
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-03-02 11:25:55 -07:00
Taylor Smock
c81d0f24b5
Temporarily generate manifest for update site until v0.8.1 for the Gradle JOSM plugin is released
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-03-02 10:43:51 -07:00
Taylor Smock
2b9c88040c
Commands: Override getParticipatingPrimitives for better error reports
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-03-01 16:26:24 -07:00
Taylor Smock
b5f6eae7f3
Dependency updates
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-03-01 16:21:14 -07:00
Taylor Smock
6880c172e3
CI: Hopefully fix test fixture publishing
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-01-12 11:58:46 -07:00
Taylor Smock
8377d32dc4
Publish test fixture jar
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-01-12 10:47:10 -07:00
Taylor Smock
f535eaab6e
Refactor for test fixtures
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-01-12 10:31:10 -07:00
Taylor Smock
bdd2d5bafe
BoundingBoxMapWithAIDownloader: Fix issue where conflated Esri servers would fail
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-01-10 07:26:47 -07:00
Taylor Smock
98031cc0f3
Remove Esri detection for too many objects
...
This is due to issues with streams and parsing JSON.
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-01-05 13:14:33 -07:00
Taylor Smock
b9540604f7
Gradle: Update dependencies
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-01-05 12:44:20 -07:00
Taylor Smock
88d1bc7b81
Work around CI failure due to attempting to write preferences
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-01-05 11:04:39 -07:00
Taylor Smock
62f43c10ff
Add basic test for conflation (BoundingBoxMapWithAIDownloaderTest)
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-01-05 10:53:02 -07:00
Taylor Smock
a739e55eb7
Add BoundingBoxMapWithAIDownloaderTest
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-01-05 09:56:51 -07:00
Taylor Smock
526688ab4f
BoundingBoxMapWithAIDownloader: Account for feature servers that don't set the appropriate headers
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-01-04 16:29:19 -07:00
Taylor Smock
7d12e23b64
Fix an issue where query parameter modifications would not be saved
...
This is only for true/false parts.
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-12-07 11:46:44 -07:00
Taylor Smock
cf01febcf1
Fix URL reset on JOSM restart
...
This was reported on Slack by drkludge.
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-12-06 16:50:15 -07:00
Taylor Smock
a3cd232117
Really fix bound expansion issue
...
This was partially fixed in ca85a58cae
.
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-12-02 14:52:55 -07:00
Taylor Smock
eb143d0afc
Fix some lint issues
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-12-02 13:52:32 -07:00
Taylor Smock
e3f21db410
Update dependencies
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-12-02 13:52:26 -07:00
Taylor Smock
ca85a58cae
Fix issue where downloaded bounds is expanded
...
Also fix some lint issues, and remove last non-guarded reference to
ForkJoinPool.commonPool.
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-12-02 13:44:09 -07:00
Taylor Smock
0f8072833a
Fix JOSM #21623 : ACE in MapWithAILayerInfo
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-12-02 09:57:52 -07:00
Taylor Smock
52f9d8eae2
GetDataRunnable: Allow removal of tags
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-12-02 09:55:19 -07:00