- Remove unused ftx1_handle_cat_error function
- Remove unused ftx1_get_split and ftx1_set_split functions
- Remove unused variable 'err' in ftx1_set_freq
- Remove corresponding function declarations from ftx1.h
- Eliminates all compiler warnings for clean build
The function rig_init() doesn't touch the hardware, it's rig_open()
that initiates the connection and in fact the first use of comm_status
in rig_open() is when it gets the value RIG_COMM_STATUS_CONNECTING and
rig_close() sets it to RIG_COMM_STATUS_DISCONNECTED.
This warning was seen on MacOS and on Debian 12 and 13 using clang:
CC kenwood.lo
kenwood.c:2293:9: warning: absolute value function 'abs' given an argument of type 'shortfreq_t' (aka 'long') but has parameter of type 'int' which may cause truncation of value [-Wabsolute-value]
2293 | if (abs(rit) > 9999) { RETURNFUNC(-RIG_EINVAL); }
| ^
kenwood.c:2293:9: note: use function 'labs' instead
2293 | if (abs(rit) > 9999) { RETURNFUNC(-RIG_EINVAL); }
| ^~~
| labs
1 warning generated.
Closes issue #1806 on GitHub
Compile with -Wimplicit-fallthrough; analyze the results.
Define macro to mark valid fall through constructs. Mark all of the good
ones, and fix the bad.
Not available with all compilers - for those without the feature this commit
does nothing.
To execute the tests with the installed Hamlib use the same long arguments
as ampctl, eg:
bindings/python/test_amp.py --model {MODEL_NUMBER} --amp-file /dev/ttyUSB0 --serial-speed {BAUD}
To execute the tests from the build tree, add the path to the libraries
that you built, eg. from the root of the build tree:
PYTHONPATH=bindings/:bindings/.libs/ ...your command...
To execute the tests with the installed Hamlib use the same long arguments
as rotctl, eg:
bindings/python/test_rot.py --model {MODEL_NUMBER} --rot-file /dev/ttyUSB0 --serial-speed {BAUD}
To execute the tests from the build tree, add the path to the libraries
that you built, eg. from the root of the build tree:
PYTHONPATH=bindings/:bindings/.libs/ ...your command...
To execute the tests with the installed Hamlib use the same long arguments
as rigctl, eg:
bindings/python/test_rig.py --model {MODEL_NUMBER} --rig-file /dev/ttyUSB0 --serial-speed {BAUD}
To execute the tests from the build tree, add the path to the libraries
that you built, eg. from the root of the build tree:
PYTHONPATH=bindings/:bindings/.libs/ ...your command...