Wykres commitów

12250 Commity (70d50d0efbbdd84157c9cd89043744f07d15bfd8)

Autor SHA1 Wiadomość Data
George Baltz N3GB 70d50d0efb Fix one byte buffer overrun
All the pictures in manuals show message as 4 bytes, but they don't
include the major command (0x26).

Found by `gcc -fanalyzer`
2025-08-06 05:13:25 -04:00
George Baltz N3GB 1e5adb9fde Fix errors in error cases
Leak FDs in error exits, seg faults if RIG missing.
Found by `gcc -fanalyzer`
2025-08-06 04:56:02 -04:00
George Baltz N3GB 96bc67d993 Fix FD leak in AESStringCrypt.c
Found by `gcc -fanalyzer`, which then spent the next 20+ minutes trying to
analyze md5.c, at which point I gave up.
2025-08-05 11:33:00 -04:00
George Baltz N3GB c26113c5cc Fix more cppcheck messages
Suppress non-errors in rx331.c and rx340.c
Mark runflag(s) as volatile
2025-08-04 18:43:39 -04:00
George Baltz N3GB c1132a77b5 Mark cache structure in rig_state as deprecated.
It is no longer being initialized or updated, so anyone referencing it
is being misled.
2025-08-04 10:24:15 -04:00
George Baltz N3GB c1e6dcf010 More cppcheck stuff in amplifiers/ and rotators/ 2025-08-04 09:59:23 -04:00
George Baltz N3GB 8ce51d13aa Update Kenwood max CW message size. 2025-08-04 09:59:23 -04:00
Nate Bargmann 1e310b7958
Merge GitHub PR #1828 2025-08-04 08:04:15 -05:00
Nate Bargmann c881bc7132
Merge GitHub PR #1827 2025-08-04 07:49:28 -05:00
jeremybox 8ccc197b7c ftx1: implement tuning step functionality and cleanup
- Add ftx1_get_ts() and ftx1_set_ts() functions using EX0306 commands
- Support mode-specific tuning step values:
  * SSB/CW & RTTY/PSK: 5Hz, 10Hz, 20Hz
  * FM: 5kHz, 6.25kHz, 10kHz, 12.5kHz, 20kHz, 25kHz, Auto
- Remove unused functions: ftx1_handle_cat_error, ftx1_get_split, ftx1_set_split
- Remove unused variable in ftx1_set_freq
- Update header file to remove unused function declarations
- Fix format specifiers (%d -> %ld) for shortfreq_t type

Tested with real FTX-1 hardware using rigctl commands.
Tuning step functionality verified in LSB mode with 20Hz step.
2025-08-03 20:52:29 -04:00
jeremybox 182597ebc4 Clean up unused functions in FTX-1 driver
- Remove unused ftx1_handle_cat_error function
- Remove unused ftx1_get_split and ftx1_set_split functions
- Remove unused variable 'err' in ftx1_set_freq
- Remove corresponding function declarations from ftx1.h
- Eliminates all compiler warnings for clean build
2025-08-03 18:20:06 -04:00
Daniele Forsi IU5HKX fbe9803777 Fix initialization of comm_status
The function rig_init() doesn't touch the hardware, it's rig_open()
that initiates the connection and in fact the first use of comm_status
in rig_open() is when it gets the value RIG_COMM_STATUS_CONNECTING and
rig_close() sets it to RIG_COMM_STATUS_DISCONNECTED.
2025-08-03 13:34:36 +02:00
Daniele Forsi IU5HKX 8d8d0328bf Fix typos 2025-08-03 10:49:23 +02:00
jeremybox 0d079d2338 Restore tests/Makefile.am to match master branch exactly 2025-08-02 22:18:36 -04:00
jeremybox 971ab5e126 Remove test_ftx1 from Makefile to fix build issues
- Removed test_ftx1 from check_PROGRAMS list
- Removed test_ftx1_SOURCES definition
- This prevents build failures on systems without the test file
2025-08-02 22:12:46 -04:00
jeremybox bb070edfa3 Enhanced FTX-1 support with comprehensive improvements 2025-08-02 22:02:05 -04:00
Nate Bargmann 989623ec51
Merge GitHub PR #1824 2025-08-01 18:31:38 -05:00
Nate Bargmann b4eb1bdb12
Quell warning from clang
This warning was seen on MacOS and on Debian 12 and 13 using clang:

CC       kenwood.lo
kenwood.c:2293:9: warning: absolute value function 'abs' given an argument of type 'shortfreq_t' (aka 'long') but has parameter of type 'int' which may cause truncation of value [-Wabsolute-value]
 2293 |     if (abs(rit) > 9999) { RETURNFUNC(-RIG_EINVAL); }
      |         ^
kenwood.c:2293:9: note: use function 'labs' instead
 2293 |     if (abs(rit) > 9999) { RETURNFUNC(-RIG_EINVAL); }
      |         ^~~
      |         labs
1 warning generated.

Closes issue #1806 on GitHub
2025-08-01 18:25:16 -05:00
Nate Bargmann a9ecd50329
Sanitize radio model names and manufacturers
Reference GitHub issue #1013.
2025-08-01 07:55:41 -05:00
Daniele Forsi IU5HKX 0c57ccad26 Add missing include file
Otherwise it isn't added to the distribution archive created by
"make distcheck".
2025-07-30 23:29:12 +02:00
Daniele Forsi IU5HKX 094b5e741a Remove unused variables 2025-07-30 23:29:12 +02:00
Daniele Forsi IU5HKX 200b2aaecc Remove unneeded typedef
It's only used by Yeasu simulators.
2025-07-30 23:29:12 +02:00
Daniele Forsi IU5HKX 6af3b3a94e Remove DECLARE_INITRIG_BACKEND()
This code is uneeded.
2025-07-30 23:29:12 +02:00
Daniele Forsi IU5HKX 5f78c54bae Remove DECLARE_INITRIG_BACKEND()
Breaks rig_probe() for rigs probed later (eg. Kenwood).
2025-07-30 23:29:12 +02:00
George Baltz N3GB b4f0a3b4b3 Update NEWS 2025-07-29 14:04:16 -04:00
George Baltz N3GB 1c36377480 Still more cppcheck tweaks 2025-07-29 13:10:28 -04:00
George Baltz N3GB 72bc62366d A few more cppcheck messages silenced 2025-07-28 19:31:20 -04:00
Daniele Forsi IU5HKX f8c3d6b614 Fix error messages 2025-07-28 22:04:18 +02:00
George Baltz N3GB e172d34381 Deprecate amp_get_conf(), too 2025-07-28 11:32:34 -04:00
George Baltz N3GB faad247f06 Deprecate rot_get_conf() 2025-07-28 10:43:10 -04:00
Nate Bargmann 48804dc4da
Merge GitHub PR #1819 2025-07-27 18:45:52 -05:00
Nate Bargmann 66acf19efe
Merge GitHub PR #1818 2025-07-27 18:01:00 -05:00
Nate Bargmann 53b7cef537
Merge GitHub PR #1817 2025-07-27 17:10:45 -05:00
Daniele Forsi IU5HKX c0ec84ca4b Add default values for make (dist)check 2025-07-27 20:13:07 +02:00
Daniele Forsi IU5HKX ed138699c3 Add missing files for make distcheck 2025-07-27 20:12:58 +02:00
dforsi 96d5abab47
Merge branch 'master' into fix/pytest 2025-07-27 18:22:26 +02:00
Nate Bargmann 0d543f9483
Merge GitHub PR #1815 2025-07-27 10:54:55 -05:00
George Baltz N3GB 20eeb96787 Deprecate rig_get_conf()
Define macro to set attribute, if compiler is capable
Add macro to rig_get_conf(), Rig::getConf() declarations
Fix internal uses of rig_get_conf()
2025-07-27 11:31:18 -04:00
Nate Bargmann 119e079373
Merge GitHub PR #1790 2025-07-27 10:14:43 -05:00
Daniele Forsi IU5HKX 464076f193 Disable Tcl bindings for macOS when running make distcheck 2025-07-27 16:36:58 +02:00
George Baltz N3GB 6c372f981f Distinguish wanted from unwanted fall through instances
Compile with -Wimplicit-fallthrough; analyze the results.
Define macro to mark valid fall through constructs. Mark all of the good
 ones, and fix the bad.

Not available with all compilers - for those without the feature this commit
 does nothing.
2025-07-27 10:03:38 -04:00
George Baltz N3GB a7c8c3fa9e Fix another unwanted fall through 2025-07-27 10:03:38 -04:00
Daniele Forsi IU5HKX 4c28ba0bde Run the TCL tests using the library from build 2025-07-27 15:56:51 +02:00
Daniele Forsi IU5HKX 95bd993dd7 Do not clobber the return value of failed tests
While printing an error message is nice, it prevented "make check"
to fail; and the other two binding didn't print any.
2025-07-27 15:10:28 +02:00
Daniele Forsi IU5HKX 0df9d1767e Allow to execute some tests with a simulator or with a real amplifier
To execute the tests with the installed Hamlib use the same long arguments
as ampctl, eg:
 bindings/python/test_amp.py --model {MODEL_NUMBER} --amp-file /dev/ttyUSB0 --serial-speed {BAUD}

To execute the tests from the build tree, add the path to the libraries
that you built, eg. from the root of the build tree:
 PYTHONPATH=bindings/:bindings/.libs/ ...your command...
2025-07-27 12:57:35 +02:00
Daniele Forsi IU5HKX 6088445635 Allow to execute some tests with a simulator or with a real rotator
To execute the tests with the installed Hamlib use the same long arguments
as rotctl, eg:
 bindings/python/test_rot.py --model {MODEL_NUMBER} --rot-file /dev/ttyUSB0 --serial-speed {BAUD}

To execute the tests from the build tree, add the path to the libraries
that you built, eg. from the root of the build tree:
 PYTHONPATH=bindings/:bindings/.libs/ ...your command...
2025-07-27 12:53:23 +02:00
Daniele Forsi IU5HKX eefdda51e5 Update documentation for Python tests 2025-07-27 11:29:51 +02:00
Daniele Forsi IU5HKX ede84bfce4 Also check the "val" parameter in rig_set_conf()
Avoids a segfault in lower level functions that can more easily
happen when using the bindings.
Simmetric with rig_get_conf() via rig_get_conf2().
2025-07-27 10:47:46 +02:00
Daniele Forsi IU5HKX c3ec11e5f7 Allow to execute some tests with a simulator or with a real rig
To execute the tests with the installed Hamlib use the same long arguments
as rigctl, eg:
 bindings/python/test_rig.py --model {MODEL_NUMBER} --rig-file /dev/ttyUSB0 --serial-speed {BAUD}

To execute the tests from the build tree, add the path to the libraries
that you built, eg. from the root of the build tree:
 PYTHONPATH=bindings/:bindings/.libs/ ...your command...
2025-07-27 10:47:46 +02:00
Daniele Forsi IU5HKX eb5a838f30 Check datatype before actual value 2025-07-27 10:22:54 +02:00