4d69d19016
Merge 22636be85e into 623ff17f61
2025-07-05 21:30:04 +00:00
22636be85e
Commented out the embedded debugging (WARN level) that echoes all transaction data.
2025-07-05 17:11:33 -04:00
ec0a04669c
Merged remaining R8 set/get memory channel routines over to drake.c
...
Cleaned up comments and added interface documentation to newly added routines
Added TODO notes for things yet to be handled on R8A/B, such as channel name
2025-07-05 09:41:52 -04:00
49b01e1968
Removed EOM from set_mem's "Cxx" command because it was leaving an extra LF in the receive queue, messing up the response to any subsequent command.
2025-07-04 20:54:45 -04:00
cb0646c727
Merged all R8 testing routines (except set/get memory channel) into their equivalents within drake.
...
Will do the same with memory channel routines once they are better tested.
2025-07-04 00:53:28 -04:00
7a97578476
Fixed error in get_mem(), which was reading mode, not memory channel.
...
Adusted Report All to decode memory status AFTER mode, so VFO_MEM wouldn't get squashed.
2025-07-03 11:02:50 -04:00
6ac3dd596b
Fixed squelch detection to use an asterisk instead of a hash (like in the manual).
...
Also fixed setting of meter based on the status of RIG_DCD_ON/OFF instead of true/false.
2025-07-03 00:30:11 -04:00
48405744b5
Silence uninitiated variable warning in vfo_op on C99 compuler.
2025-07-02 22:08:47 -04:00
db863a6921
Added stdbool.h for c99 compilers in drake.c
2025-07-02 20:34:17 -04:00
3ff4bc99cc
Moved all r8's command debug routines over to drake.c and out of the r8-specifc backend.
...
Removed the r8-specific transaction routine and repointed it to the revised common one in drake.c.
2025-07-02 11:33:50 -04:00
d32d605be6
Fix crashing when attempting to receive data on 'set' actions... helps if the receive buffer is appropriately sized.
...
Also, added intialization to the receive buffer in the comms loop.
2025-07-02 11:13:06 -04:00
3b8a24179e
Fixed issue in comms loop where receive buffer was too small, causing buffer overflow crashes.
...
Also, added buffer initialization in case some receive errors are not handled properly.
Fixed potential C99 stdbool error.
2025-07-02 09:23:59 -04:00
e1562e675f
Organized most of the redundant rig freq, mode, mem, and all reporting into their individual routines that decode and pool most of the 'get' settings into the private data area.
2025-07-01 23:47:41 -04:00
03bf68c459
Removed redundant timout-specific error block.
2025-06-30 21:30:49 -04:00
f94ec6a47b
Changes to smooth out the transaction process for all Drakes, and more test edits for the R8.
2025-06-30 21:17:37 -04:00
623ff17f61
Build all language bindings
2025-07-01 00:32:06 +02:00
7acb809eef
Do not try to compile Python code when building other bindings
...
Fixes the issue reported by @dl8fcl
f7d38f92ca (commitcomment-161078321)
2025-07-01 00:12:23 +02:00
ca7353abaa
Merge GitHun PR #1788
2025-06-30 07:39:41 -05:00
a6fb8a079a
Update copyright to GUOHETEC in license headers for all GUOHETEC driver files
2025-06-30 08:43:04 +08:00
b95d349bff
Add LGPLv2.1 license headers to GUOHETEC driver files
2025-06-30 08:41:13 +08:00
8316886063
Adds a backend for the Drake R8 for non-intrusive testing. Module contains copies of parts of drake.c because several routines are significantly different than R8a/b. Resopnses will be different.
...
Test rig includes better debugging of message transfers, that replace nulls, CRs and LFs with token strings so they can be properly seen and counted as part of the sending and receiving messages.
2025-06-29 12:14:21 -04:00
3b6577834e
Added RetVal
2025-06-28 16:55:25 -05:00
b365d988a4
FlexCW
...
Added the option to send CW using CWX commands on Flex's.
2025-06-28 08:08:59 -05:00
6797ab7646
guohetec: fix cppcheck warnings and improve code quality
...
Based on cppcheck analysis and maintainer feedback:
- Fix constParameterPointer warnings: declare reply parameters as const where appropriate
- Fix variableScope warnings: reduce reply variable scope to minimum required
- Apply IWYU (IncludeWhatYouUse) suggestions for header optimization:
* Add iofunc.h (for read_block, write_block functions)
* Add riglist.h (for RIG_MODEL_* constants)
* Remove unistd.h, misc.h, serial.h (unnecessary includes)
- Maintain backward compatibility and existing functionality
- Improve code maintainability and reduce compilation warnings
All changes follow maintainer recommendations and maintain WSJT-X compatibility.
2025-06-28 17:13:12 +08:00
c2d4fbe601
guohetec: comprehensive code quality improvements
...
- Fix compilation warnings by removing unnecessary dump_hex function calls
- Resolve implicit function declaration warnings for validation macros
- Remove duplicate GUOHE_MODE_TABLE_MAX definitions across files
- Optimize header includes based on IWYU suggestions:
* Add iofunc.h (for read_block/write_block functions)
* Add riglist.h (for RIG_MODEL_* constants)
* Remove unistd.h, misc.h, serial.h (unnecessary includes)
- Convert validation macros to functions for better compiler compatibility
- Maintain backward compatibility with existing macro definitions
- Improve code structure and maintainability
- Ensure WSJT-X compatibility with consistent error handling
All changes maintain existing functionality while improving code quality
and reducing compilation warnings.
2025-06-28 16:56:54 +08:00
a61877a60b
Fix duplicate stdint.h includes in pmr171.c and q900.c
2025-06-28 11:07:50 +08:00
19c2cc0315
Fix duplicate retval variable definition in guohetec.c probe function
2025-06-28 11:04:58 +08:00
dee29c555f
Implement consistent error handling for GUOHETEC drivers
...
- Use unified error handling mechanism in send_cmd2 functions
- Always return RIG_OK to prevent WSJT-X errors
- Update cache with requested values even when communication fails
- Use English comments and debug messages
- Ensure graceful degradation with cached values on protocol/timeout errors
2025-06-28 10:55:20 +08:00
abf6be0b5e
Fix compilation errors in GUOHETEC drivers
...
- Remove duplicate function declarations in pmr171_send
- Remove duplicate code blocks in pmr171_set_mode
- Remove duplicate pmr171_send calls in pmr171_set_ptt
- Add missing from_be function implementation
- Fix syntax errors that were causing CI failures
2025-06-28 10:22:26 +08:00
c9161e2e25
Improve error handling for GUOHETEC drivers to enhance WSJT-X compatibility
...
- Add graceful degradation for communication errors
- Return cached values instead of error codes on failures
- Implement unified response validation functions
- Add cache return macros for consistent error handling
- Maintain backward compatibility while improving stability
This change ensures WSJT-X and similar applications continue working
even when temporary communication issues occur with GUOHETEC radios.
Fixes: WSJT-X compatibility issues with PMR-171 and Q900 drivers
2025-06-28 10:11:21 +08:00
862fda58be
Merge GitHub PR #1786
2025-06-27 07:40:51 -05:00
9c18734911
Update NEWS for recent merges
2025-06-27 07:22:21 -05:00
5eda68367f
Corrected a couple of cppcheck warnings: uninitialize variable and condition always false.
2025-06-27 08:05:03 -04:00
cb308819e7
Merge GitHub PR #1785
2025-06-27 06:53:07 -05:00
36f582222f
Merge GitHub PR #1784
2025-06-27 06:36:16 -05:00
7fe7602a82
Delete redundant functions and structures in guohetec. c, pmr171. c, and q900. c, optimize code structure, fix data length verification logic, and ensure the security and stability of data processing. All cppcheck style warnings have been fixed
2025-06-27 11:23:30 +08:00
bf518c0609
Fix Rig.get_ant()
...
The only supported value for get_ant() in the union of "option"
is signed integer.
Do the test when the rig is open.
2025-06-26 20:29:25 +02:00
ef3e278203
Merge GitHub PR #1776
2025-06-26 13:14:29 -05:00
ef0b7e30bd
Reverted CW Pitch value<->knob conversion for non-ICR75 radios. Apparently R75 is the only one using the set mode command.
...
Edited out all non-essential code commenting that was done during local testing.
2025-06-26 13:38:23 -04:00
82dd540d3a
Part 2 of Issue#1775: Adds optional wrappers for rigs that need to use the alternate AGC mapping originally specified in icom.c. Instructions for employment are provided within icom_alt_agc.c.
2025-06-26 13:04:58 -04:00
31c3c97352
Merge GitHub PR #1783
2025-06-25 21:32:26 -05:00
92a0775855
Modify the buffer size of q900. c to prevent overflow
2025-06-26 10:11:27 +08:00
acd4a98cd5
Modify buffer size to prevent overflow
2025-06-26 10:08:02 +08:00
b7388e2fca
Delete useless variables of pmr171 and q900
2025-06-26 09:21:05 +08:00
14a81b9ad9
Fix q900 and pmr171 compilation warnings
2025-06-26 09:07:11 +08:00
6c399b55ff
Assert the length of sequences instead of the list datatype
...
We only need to check how many values exist.
2025-06-25 22:54:18 +02:00
7223fb0766
Fix Rig.get_vfo_info()
2025-06-25 19:16:33 +02:00
453e68c6cd
Fix Rig.get_split_vfo()
...
The VFO argument optional with a default of RIG_VFO_CURR.
Fixes PR ##1555.
2025-06-25 19:16:33 +02:00
e163aa2645
Another reversion
2025-06-25 10:53:50 -04:00
55b0599b75
Stop the blithering
2025-06-25 10:41:55 -04:00
markjfine