Mike Black W9MDB
8fe190d622
Reduce error messages about RIG_VFO_OTHER which only applies to some rigs like Icom rigs with the 0x25 command
...
Add a flush_flag to read_string so that the new serial_flush will not produce a timeout value when flushing
https://github.com/Hamlib/Hamlib/issues/835
2021-11-01 23:43:45 -05:00
Mike Black W9MDB
c83949ae6d
For Icom rigs like IC910H and IC9700 Main/Sub are only used for split and satmode
...
Otherwise VFOA/B can be used on either Main or Sub VFOs
So if Main is requested and not in split/satmode then VFOA is assumed -- this case was fixed
And if Sub is requested and not in split/satmode then VFOB is assumed -- this was already true
https://github.com/Hamlib/Hamlib/issues/832
2021-10-20 15:56:11 -05:00
Mike Black W9MDB
569f21c7fe
Revert "Start to normalize Icom cmd detection"
...
This reverts commit 1ade49f3d5
.
2021-10-17 16:02:30 -05:00
Mike Black W9MDB
80f7378bf5
Arrgghhh..fix spelling of PKTLSB
2021-10-17 13:14:57 -05:00
Mike Black W9MDB
3dde8030a0
Add PKTUSB PKTLSB to allowed rig modes for Icom in set_dsp_flt
2021-10-17 13:11:11 -05:00
Mike Black W9MDB
1ade49f3d5
Start to normalize Icom cmd detection
2021-10-17 13:10:15 -05:00
Mike Black W9MDB
6c43e5c6ac
Fix bogus "not supported" message when icom_set_mode_x26 is called
2021-10-16 23:29:05 -05:00
Mike Black W9MDB
83b7243946
Change icom_set_mode_with_data to reuse existing filter# if RIG_PASSBAND_NOCHANGE is requested
...
https://github.com/Hamlib/Hamlib/issues/827
2021-10-15 12:56:17 -05:00
Mike Black W9MDB
16a879bc72
Fix icom_set_mode_x26
...
https://github.com/Hamlib/Hamlib/issues/811
2021-10-13 16:02:40 -05:00
Mike Black W9MDB
c7acbc19de
Improve Icom rigs with 1A 03 command and add some debug
...
https://github.com/Hamlib/Hamlib/issues/811
2021-10-13 11:53:45 -05:00
Mike Black W9MDB
fecc7d42aa
Hopefully fixed auto_power_on for IC-7610 and IC-9700
...
But it takes ~4 seconds on IC-7300 to power on 14 seconds to time out when the rig does not respond at all
https://github.com/Hamlib/Hamlib/issues/815
2021-10-05 11:40:54 -05:00
Mike Black W9MDB
ca9a45c93e
Reduce icom auto_power_on timeout from 15 seconds to just over 5 seconds
...
https://github.com/Hamlib/Hamlib/issues/815
2021-10-04 17:34:09 -05:00
Mike Black W9MDB
068544eccb
Fix icom_set_mode_with_data to also set filter width
...
https://github.com/Hamlib/Hamlib/issues/811
2021-10-02 23:17:36 -05:00
Mike Black W9MDB
0018422d46
Add another check for icom_set_mode to skip if both mode and width are not changing
2021-10-02 22:59:19 -05:00
Mike Black W9MDB
eadd1da009
Fix IC7300 (and other Icoms) set/get_dsp_filter
...
All Icoms will now try the 1A 03 command once and if it is rejected won't try again.
https://github.com/Hamlib/Hamlib/issues/811
2021-10-02 17:33:21 -05:00
Mike Black W9MDB
a2b3a8d67e
Disable icom_get_vfo as user twiddling VFO knob does not work while polling
...
current_vfo is still determined at startup
https://github.com/Hamlib/Hamlib/issues/806
2021-09-29 05:46:53 -05:00
Mike Black W9MDB
8399b4b4dc
For Icom get_vfo make the same change as last commit for other Icom rigs
...
https://github.com/Hamlib/Hamlib/issues/806
2021-09-28 14:06:50 -05:00
Mike Black W9MDB
3a76cb1b40
For Icom get_vfo when freqs are equal will only check vfo 1 time
...
This means get_vfo will not follow rig button pushes when freqs are equal
https://github.com/Hamlib/Hamlib/issues/806
2021-09-28 12:01:50 -05:00
Mike Black W9MDB
aae3ec4996
Allow IC-7300 and many other Icom rigs to find current vfo on startup
...
Icom rigs that do not have 0x25 or XCHG cannot do this yet which are older Icom rigs
XCHG rigs cannot get_vfo while transmitting but 0x25 rigs can
https://github.com/Hamlib/Hamlib/issues/806
2021-09-26 17:03:47 -05:00
Mike Black W9MDB
421c6e7c4e
Fix icom.c get_mode to not ask for unselected VFO when VFO_CURR is requested
...
https://github.com/Hamlib/Hamlib/issues/806
2021-09-22 10:40:56 -05:00
Mike Black W9MDB
a94dcddcf4
Fix ICOM request for VFOB info when VFOB is active vfo
...
https://github.com/Hamlib/Hamlib/issues/806
2021-09-21 12:17:17 -05:00
Mike Black W9MDB
ecea9da847
Remove unused value set in icom.c
2021-09-11 09:54:19 -05:00
Mike Black W9MDB
ec2d5387a7
Remove shadowed declaration from icom.c
2021-09-11 09:53:17 -05:00
Mike Black W9MDB
02f0ae986f
Remove always true clause from icom.c
2021-09-11 09:48:36 -05:00
Mike Black W9MDB
a85d6891c7
Fix return path in icom.c
2021-09-11 05:43:19 -05:00
Mike Black W9MDB
6e5bc09b27
Fix potential buffer underflow in icom.c
2021-09-11 05:41:25 -05:00
Mike Black W9MDB
f2c60aa33a
Since Icom rigs default to filter 2 if a filter is not selected we will do the same when turning on data mode
...
https://github.com/Hamlib/Hamlib/issues/791
2021-09-07 17:52:44 -05:00
Mike Black W9MDB
e900b4f9dc
Change set_icom_set_mode_with_data to not change mode unless necessary
...
Should allow filters to stay where they are set if USB-D is the starting mode
https://github.com/Hamlib/Hamlib/issues/791
2021-09-07 17:44:57 -05:00
Mike Black W9MDB
acac64c116
Really fix icom_set_func so that it can also turn off DUAL_WATCH
2021-09-01 09:08:13 -05:00
Mike Black W9MDB
004efafda7
Remove unnecessary set_mode command from TARGETABLE_MODE Icom rigs
...
https://github.com/Hamlib/Hamlib/issues/762
https://github.com/Hamlib/Hamlib/issues/430
2021-08-28 17:09:27 -05:00
Mike Black W9MDB
996dbbfa1a
Remove override of PKTUSB mode for Icom rigs -- don't think we need this
...
Was causing mode toggling on IC7300 during PTT transitions in JTDX
2021-08-28 10:21:16 -05:00
Mike Black W9MDB
06513a6869
Remove another unneeded vfo swap from icom rigs
...
https://github.com/Hamlib/Hamlib/issues/762
https://github.com/Hamlib/Hamlib/issues/430
2021-08-27 17:24:31 -05:00
Mike Black W9MDB
283281c4cb
astyle all files preparing for 4.3 release
2021-08-26 06:49:24 -05:00
Wouter van Gulik
9aec383329
Simplify get_ant by having setting to unknown by default.
...
Drop setting to default in rigs.
Add some more documentation on get_ant.
2021-08-25 22:13:21 +02:00
Mike Black W9MDB
547bd0fb55
Fix ANT get/set for IC756Pro series
...
https://github.com/Hamlib/Hamlib/issues/774
2021-08-22 16:40:48 -05:00
Wouter van Gulik
83a8b98a86
icom.c: Drop width check. Other code assumes != NULL.
...
I am not sure if the intention was to check for width == default.
But that never worked, so for now do not change behaviour.
2021-08-21 20:36:10 +02:00
Mike Black W9MDB
014bc04ddf
Fix Icom rigs to use 0x25 command if capable
...
Fixes #1 and and #2 in the issue
https://github.com/Hamlib/Hamlib/issues/762
2021-08-13 07:42:39 -05:00
Mike Black W9MDB
4bfd71f91f
Fix Icom split and implement reverse split
...
These should work now from rigctl and via the API
S VFOB 1 VFOA
S Sub 1 Main
https://github.com/Hamlib/Hamlib/issues/754
2021-08-02 23:37:31 -05:00
Mike Black W9MDB
a092f1f630
Fix spelling error in icom.c
2021-07-19 22:58:19 -05:00
Mike Black W9MDB
756f8052fc
Minimize 0x25cmdfails resets to only when satmode changes
...
https://github.com/Hamlib/Hamlib/issues/741
2021-07-15 10:19:33 -05:00
Mike Black W9MDB
6bdb82bc54
Fix some vfo swapping issues for Icom rigs
...
https://github.com/Hamlib/Hamlib/issues/734
2021-07-08 13:14:42 -05:00
Mike Black W9MDB
65c77953f8
Add MainA/B SubA/B to icom.c
...
https://github.com/Hamlib/Hamlib/issues/730
2021-07-05 17:04:24 -05:00
Mike Black W9MDB
dd0187ede6
Fix Icom rig 0x25 command for set mode with data and no width change
...
Fix Icom rigs not working with rigtctld and 0x25 command
https://github.com/Hamlib/Hamlib/issues/733
2021-07-03 22:16:33 -05:00
Mike Black W9MDB
763e18fa42
Fix get_mode_with_data for IC7800 as it can set but not read mode with 0x26 command
...
https://github.com/Hamlib/Hamlib/issues/725
2021-06-14 07:52:29 -05:00
Mike Black W9MDB
f41bcaa71a
Add IC-575 rig
2021-06-03 16:13:58 -05:00
Mike Black W9MDB
d9d562874d
Fix compilation warning in icom.c
2021-05-31 08:36:45 -05:00
Mikael Nousiainen
3a67356bc1
Add some comments and improved debugging on SIGIO async data handling
2021-05-31 16:22:22 +03:00
Mikael Nousiainen
263c16984a
Attempt to handle asynchronously pushed Icom CI-V frames (transceive and spectrum data) as these frame will get interleaved with command responses
2021-05-30 01:36:49 +03:00
Mikael Nousiainen
12527581b0
Add SPECTRUM_ATT level (also supported by Kenwood rigs). Get VFO frequency for Icom spectrum edge ranges (if not cached). Fix preamp levels based on docs. Add supported AGC levels to recent Icom rigs.
2021-05-27 10:12:01 +03:00
Mikael Nousiainen
26ea916ca7
Implement Icom rig levels: SPECTRUM_EDGE_LOW and SPECTRUM_EDGE_HIGH
2021-05-27 01:09:01 +03:00
Mikael Nousiainen
b4ba22d369
Implemented initial abstraction for spectrum scope data and support for Icom spectrum data output. The abstraction is based on common features of both Icom and Kenwood rigs. Added TRANSCEIVE func and enumeration of supported AGC levels. Work in progress.
2021-05-26 23:40:53 +03:00
Mike Black W9MDB
e84b8a3c99
Add special check for IC821H in icom_set_vfo
...
Seems the IC821H reverses Main/Sub logic when in satmode
Remove IC821 from riglist.h and icom.c -- not used
https://github.com/Hamlib/Hamlib/issues/693
2021-05-07 08:25:54 -05:00
Mike Black W9MDB
2dd87806cf
Remove 3 second sleep from icom.c powerup
2021-04-30 15:59:43 -05:00
Mike Black W9MDB
81e3e2e5d2
astyle files
2021-04-29 17:23:37 -05:00
Mike Black W9MDB
9a82ebf652
Make icom.c 0x25 cmd check only try once
...
https://github.com/Hamlib/Hamlib/issues/685
2021-04-27 10:00:10 -05:00
Mike Black W9MDB
1d79b9e01c
Fix icom \get_mode in non-vfo mode to stay on VFOB/Sub
...
https://github.com/Hamlib/Hamlib/issues/676
2021-04-23 17:43:54 -05:00
Mike Black W9MDB
b0e006ce6c
astyle files
2021-04-21 23:48:29 -05:00
Mike Black W9MDB
870b9ca748
In icom.c add check for current vfo to avoid vfo swapping
...
https://github.com/Hamlib/Hamlib/issues/665
https://github.com/Hamlib/Hamlib/issues/654
2021-04-19 09:51:58 -05:00
Mike Black W9MDB
cd82a2c008
In icom.c fix reading VFOB width when 0 and set to VFOA width
...
https://github.com/Hamlib/Hamlib/issues/665
https://github.com/Hamlib/Hamlib/issues/654
2021-04-18 22:46:50 -05:00
Mike Black W9MDB
aefe8c44b7
In rig.c if rig does not set get_split_vfo then return cached values
...
https://github.com/Hamlib/Hamlib/issues/654
https://github.com/Hamlib/Hamlib/issues/665
2021-04-18 11:35:35 -05:00
Mike Black W9MDB
73464a6c2e
Fix IC910 behavior with gpredict -- also should fix some Main/Sub behavior elsewhere too
...
https://github.com/Hamlib/Hamlib/issues/657
2021-04-11 11:49:37 -05:00
Mike Black W9MDB
7ea4fd17aa
Fix icom.c default vfo to usa VFOA/Main as appropriate
...
https://github.com/Hamlib/Hamlib/issues/654
2021-04-08 22:37:36 -05:00
Michael Black W9MDB
b696391a66
Try another method of setting Icom default vfo
2021-03-30 15:40:17 -05:00
Michael Black W9MDB
b16eb6ac42
Force Icom rigs to MAIN_A on open
2021-03-30 14:48:41 -05:00
Michael Black W9MDB
ea269b224c
Fix vfo selection for Icom rigs when in split mode
...
https://github.com/Hamlib/Hamlib/issues/637
2021-03-30 14:43:57 -05:00
Michael Black W9MDB
fffaf27f87
Change icom.c to use Main instead of Main_A and Sub instead of Main_B
...
https://github.com/Hamlib/Hamlib/issues/637
2021-03-30 11:48:25 -05:00
Michael Black W9MDB
c831e32db1
Fix icom.c frequency offset when the 0x25 is attempted and fails
...
https://github.com/Hamlib/Hamlib/issues/629
2021-03-26 23:09:36 -05:00
Michael Black W9MDB
4135a65503
Add TARGETABLE_FREQ and TARGETABLE mode to IC7300 IC7610 IC7800 IC785X IC9700
...
This reduces VFO swapping during get_freq and get_mode operations
Log4OMV2 2.0.12 supports vfo mode using new get_vfo_info call
New debug level RIG_DEBUG_CACHE as it can get very verbose
https://github.com/Hamlib/Hamlib/issues/626
2021-03-26 10:54:11 -05:00
Michael Black W9MDB
eb952ad75f
In icom.c have set_vfo return RIG_OK immediately when VFO_CURR is requested
...
https://github.com/Hamlib/Hamlib/issues/625
2021-03-23 12:08:58 -05:00
Michael Black W9MDB
09474b17fb
Reset x25cmdfails when satmode is changed
2021-03-22 16:04:55 -05:00
Michael Black W9MDB
f0a82fa2bf
Fix icom.c vfo detection
...
https://github.com/Hamlib/Hamlib/issues/624
2021-03-22 07:54:46 -05:00
Michael Black W9MDB
80e199b302
Add satmode detection for Icom rigs like IC9700
...
In satmode VFOB/Sub now maps to SubA (2nd VFO)
https://github.com/Hamlib/Hamlib/issues/621
2021-03-20 08:07:16 -05:00
Michael Black W9MDB
950163f1a4
Rigs like IC9700 with MainA/B will have VFOA/Main mapped to MainA and VFOB/Sub mapped to MainB
...
No known use for SubA/SubB yet
https://github.com/Hamlib/Hamlib/issues/621
2021-03-19 23:36:33 -05:00
Michael Black W9MDB
c1277b170e
Fix Icom icom_get_usb_echo_off to read the freq response when echo is on
...
This takes into account whatever the response time of the rig is
https://github.com/Hamlib/Hamlib/issues/615
2021-03-18 22:46:45 -05:00
Michael Black W9MDB
ab59951e97
astyle files
2021-03-17 07:56:27 -05:00
Mikael Nousiainen
90112b5769
First attempt at fixing rigctl_parse return values and unnecessary rig re-open cycles
2021-03-16 23:39:35 +02:00
Michael Black W9MDB
27192d0c81
Fix potential seg faults in icom.c
...
https://github.com/Hamlib/Hamlib/issues/612
2021-03-16 12:45:30 -05:00
Michael Black W9MDB
0942553687
Fix icom_get_raw_buf
...
https://github.com/Hamlib/Hamlib/issues/612#issuecomment-800404923
2021-03-16 12:29:01 -05:00
Michael Black W9MDB
3bc39aaec1
astyle files is preparation for 4.2 release
2021-03-15 17:51:22 -05:00
Michael Black W9MDB
803a8d9e5e
Fix icom.c logic to not reject good answers
...
https://github.com/Hamlib/Hamlib/issues/596
2021-03-10 11:49:47 -06:00
Michael Black W9MDB
4d116d2f6c
Add 50ms pause in icom.c after set_freq and set_mode for possible transceive message which will then get flushed
2021-03-06 17:24:21 -06:00
Michael Black W9MDB
3d613519d5
Rename macros to avoid collisions with other software
2021-03-06 12:37:53 -06:00
Michael Black W9MDB
9a44b27775
astyle icom.c
2021-03-06 09:24:00 -06:00
Michael Black W9MDB
ef2e8a4d94
Change all icom calls to explicitly check for ACK/NAK
...
If neither is received a timeout error occurs so a retry will be done
Serial corruption was causing NAK rejects which was the wrong way to handle it
https://github.com/Hamlib/Hamlib/issues/587
2021-03-06 09:22:21 -06:00
Michael Black W9MDB
678f01d79d
Update debug in icom.c
2021-03-06 08:48:11 -06:00
Michael Black W9MDB
c3a1b489b7
Add return code to debug statements
...
Remove some RETURNFUNC that don't work with this change
2021-03-05 11:51:56 -06:00
Michael Black W9MDB
2c20b0afdb
After echo check to a get_freq in icom.c
...
Should fix poweron for Icom rigs that still echo in standby mode
https://github.com/Hamlib/Hamlib/issues/583
2021-03-05 07:32:01 -06:00
Michael Black W9MDB
247c90d4b0
Should fix icom power on
...
A little more cleanup to come
https://github.com/Hamlib/Hamlib/issues/583
2021-03-04 12:18:00 -06:00
Michael Black W9MDB
1473793f14
Change icom echo detection to a more robust solution.
...
https://github.com/Hamlib/Hamlib/issues/583
2021-03-04 11:01:23 -06:00
Michael Black W9MDB
3ca0313fb4
Implement RETURNFUNC in icom.c
...
https://github.com/Hamlib/Hamlib/issues/514
2021-03-03 16:57:03 -06:00
Michael Black W9MDB
221d87c2e4
Add auto_power_off option from JTDX team
...
Change rig_get_vfo_info to do real calls intstead of cache
2021-03-02 13:03:30 -06:00
Michael Black W9MDB
ee60a68bec
astyle files
2021-02-28 09:46:01 -06:00
Michael Black W9MDB
e5964fe670
Fix IC706 for 5 byte channels
...
https://github.com/Hamlib/Hamlib/issues/295
2021-02-23 23:16:00 -06:00
Michael Black W9MDB
0f9a7fac07
Add -RIG_EINVAL when set_level > 1.0
2021-02-19 08:44:02 -06:00
Michael Black W9MDB
1e9a991a25
Add set_dsp_flt for IC7000 -- any other Icom rigs can use this?
...
https://github.com/Hamlib/Hamlib/issues/521
2021-02-17 22:52:48 -06:00
Michael Black W9MDB
660fd94962
Change all icom rigs to watts for RIG_LEVEL_RFPOWER_METER_WATTS
...
Divide by 100 for old power call
2021-02-12 16:37:17 -06:00
Michael Black W9MDB
e589e078a1
Add 3 second sleep in icom powerstat to allow the rig to wake up
...
https://github.com/Hamlib/Hamlib/issues/525
2021-02-03 12:54:30 -06:00
Michael Black W9MDB
76f3099aef
Remove 500ms from icom/frame.c -- should not be needed
...
Reduce icom echo check to just 2 tries
Improves power up sequencing by about 7 seconds
https://github.com/Hamlib/Hamlib/issues/525
2021-02-03 11:45:57 -06:00
Michael Black W9MDB
cd7811f3ed
Fix icom_get_mode for rigs with 1-byte mode_len
...
https://github.com/Hamlib/Hamlib/issues/522
2021-01-29 16:32:16 -06:00
Michael Black W9MDB
e7b6e61ed0
astyle files prepping for 4.1 release
2021-01-22 10:41:30 -06:00
Michael Black W9MDB
599974bcea
Fix compilation error in icom.c
2021-01-20 22:54:37 -06:00
Michael Black W9MDB
5a9daf5f0e
Fix ic703 and ic705 RIG_LEVEL_RFPOWER_METER_WATTS to scale to 10W instead of 100W
2021-01-20 15:07:59 -06:00
Michael Black W9MDB
598b105e79
astyle files prepping for 4.1 release
2021-01-15 16:48:32 -06:00
Michael Black W9MDB
8024ffb937
Change icom_get_usb_echo_off to return TIMEOUT when it occurs instead of RIG_OK
...
https://github.com/Hamlib/Hamlib/issues/509
2021-01-13 12:42:03 -06:00
Michael Black W9MDB
cf858bfa3c
Change rig.c to return RIG_ENAVAIL instead of RIG_ENTARGET when set_vfo==NULL
...
Add IC706* to rigs that don't do dsp settings
Remove dynamic detection of transceive status in icom/frame.c
https://github.com/Hamlib/Hamlib/issues/490
2021-01-08 12:04:25 -06:00
Michael Black W9MDB
02c0854434
In icom.c init() set priv->filter to RIG_PASSBAND_NOCHANGE to fix set_mode rigs with 2-byte cmds
...
https://github.com/Hamlib/Hamlib/issues/490
2021-01-06 17:04:44 -06:00
Michael Black W9MDB
3211e3aea1
astyle files
2020-12-21 23:50:29 -06:00
Mikael Nousiainen
9e62b2783f
Fix RIG_PASSBAND_NOCHANGE use with Icom data modes. Allow selecting FIL2 as normal passband when in data mode. Add new Icom rigs to list that determines whether Icom data mode command supports setting filter too.
2020-12-21 18:15:15 +02:00
Michael Black W9MDB
2b1bce89bf
Fix icom default filter settings
...
https://github.com/Hamlib/Hamlib/issues/471
2020-12-19 14:30:31 -06:00
Michael Black W9MDB
263f1cde72
astyle files
2020-12-17 15:07:04 -06:00
Michael Black W9MDB
2a0deb3415
Add RIG_LEVEL_RFPOWER_METER_WATTS
...
Old level of 0-1 just doesn't work well with the varying power levels in rigs now
2020-12-16 17:47:49 -06:00
Michael Black W9MDB
9b98a264ab
Fix datamode set in icom.c to use 0x00 0x00 per the manual for 7300 and 9700
...
https://github.com/Hamlib/Hamlib/issues/448
2020-12-13 00:01:09 -06:00
Michael Black W9MDB
5883897656
icom.c passband nochange seems to be working
...
https://github.com/Hamlib/Hamlib/issues/448
2020-12-12 23:05:59 -06:00
Michael Black W9MDB
cdeacfb7d1
move icom.c icmode_ext setting a bit earlier in the code
...
https://github.com/Hamlib/Hamlib/issues/448
2020-12-12 15:38:42 -06:00
Michael Black W9MDB
ddb38db106
Set icom_set_mode to use existing filter for passband nochange
...
https://github.com/Hamlib/Hamlib/issues/448
2020-12-12 15:33:38 -06:00
Michael Black W9MDB
3061a5f8b2
Fix icom filter value, not ASCII!!!
...
https://github.com/Hamlib/Hamlib/issues/448
2020-12-12 12:40:04 -06:00
Michael Black W9MDB
915666add2
Remember filter setting from icom_get_mode so we can refer to it later on set_mode
...
https://github.com/Hamlib/Hamlib/issues/448
2020-12-12 12:21:54 -06:00
Michael Black W9MDB
e4e88b833d
Eliminate warning in icom.c for passband nochange
...
https://github.com/Hamlib/Hamlib/issues/448
2020-12-12 11:24:07 -06:00
Michael Black W9MDB
c0743dfe6e
astyle icom.c
2020-12-12 10:06:44 -06:00
Michael Black W9MDB
2ff3fa0782
icom now recognizes RIG_PASSBAND_NOCHANGE
...
https://github.com/Hamlib/Hamlib/issues/448
2020-12-12 10:06:00 -06:00
Michael Black W9MDB
c70d841b83
Add NOCHANGE_PASSBAND to icom...cascading effect on adding vfo elsewhere...which is needed anyways
...
https://github.com/Hamlib/Hamlib/issues/448
2020-11-29 23:32:14 -06:00
Michael Black W9MDB
20fc303686
Fix set_mode for IC-7000
...
https://github.com/Hamlib/Hamlib/issues/428
2020-11-03 15:24:06 +00:00
Michael Black W9MDB
51b4e0966c
Remove bad targetable code from rigs
...
https://github.com/Hamlib/Hamlib/issues/430
https://github.com/Hamlib/Hamlib/issues/414
2020-11-01 17:05:29 -06:00
Michael Black W9MDB
fd9e5d841b
Backing out targetable flags due to segfault on Linux
...
https://github.com/Hamlib/Hamlib/issues/431
2020-11-01 15:35:17 -06:00
Michael Black W9MDB
5721db70be
Added two more targetable flags for MEM and BANK to avoid VFO swapping
...
https://github.com/Hamlib/Hamlib/issues/430
https://github.com/Hamlib/Hamlib/issues/414
2020-11-01 07:48:52 -06:00
Michael Black W9MDB
74356b3a99
Add RIG_TARGETABLE_PTT and RIG_TARGETABLE_RITXIT
...
For most rigs these are non-vfo specific commands so we can avoid doing VFO switching
Add flags to all Yaesu, Icom, and Kenwood in rig_open
Some rigs do have VFO specific but it's already in the backend
More rigs can use these flags..TBD...
https://github.com/Hamlib/Hamlib/issues/430
2020-10-31 17:19:08 -05:00
Michael Black W9MDB
f55d50c7bc
Finish IC-729 addition
...
https://github.com/Hamlib/Hamlib/issues/429
2020-10-29 22:45:57 -05:00
Michael Black W9MDB
1e41f32017
Remove unused var from icom.c
2020-10-16 18:09:08 -05:00
Michael Black W9MDB
28b7543de6
Add stop_morse to Icom rigs
...
https://github.com/Hamlib/Hamlib/issues/240
2020-10-16 17:26:02 -05:00
Mikael Nousiainen
a77e82be4e
Fix handling of Icom repeater shift and split command responses. Add tuning step definitions for IC-9700.
2020-10-14 18:19:00 +03:00
Michael Black W9MDB
0576a01ec2
astyle files
2020-10-01 22:51:31 -05:00
Mikael Nousiainen
499d17cd20
Fix errors in Icom extcmd definitions and handling. Migrate more commands on Icom rigs to use extcmds. Add extfuncs to dummy rig for testing.
2020-09-16 22:33:39 +03:00
Mikael Nousiainen
23971f8e75
Fix issues with Icom extcmds definitions, some ext_tokens missing. Refactor custom level implementations to use extcmds definitions. Print out extfuncs in caps dump.
2020-09-16 18:10:35 +03:00
Michael Black W9MDB
b97d05369c
astyle files
2020-09-14 23:12:35 -05:00
Michael Black W9MDB
6267d2674e
Fix icom LEVELs
2020-09-14 14:45:36 -07:00
Michael Black W9MDB
9c5b7499f6
Fix IC7300 set_parm PARM_TIME
2020-09-14 09:18:43 -07:00
Michael Black W9MDB
aeaa96bc3b
Fix icom_get_parm to eliminate collisions
2020-09-12 21:37:10 -07:00
Michael Black W9MDB
6e45a7ba78
Fix ic7300 VOXDELAY and other extcmd structures
2020-09-12 14:26:57 -07:00
Michael Black W9MDB
83667f4c65
Added CMD_PARAM_TYPE values for icom rigs to distinguish the different ext cmd types
...
https://github.com/Hamlib/Hamlib/issues/373
2020-09-12 11:21:33 -05:00
Michael Black W9MDB
03ad7a953f
Update codeql
2020-09-11 22:44:35 -05:00
Michael Black W9MDB
2020f29185
Remove redundant RIG_LEVEL_BRIGHT
2020-09-10 10:07:11 -05:00
Michael Black W9MDB
24fb47cbe0
Added IC-705
...
Added RIG_LEVEL_BRIGHT -- IC705 has this level
Fixed range printout
https://github.com/Hamlib/Hamlib/issues/364
2020-09-06 12:28:35 -05:00
Michael Black W9MDB
fade1681fa
Fix cppcheck errors and warnings
2020-09-02 16:56:11 -05:00
Michael Black W9MDB
e459d4edc2
astyle files
2020-09-01 09:06:46 -05:00
Mike Goodey
1138feb576
Remove icom_set_rit - it doesn't (and can't) work - see README.icom
2020-09-01 14:41:45 +01:00
Daniele Forsi
d7b332c3f7
Fix spelling errors
...
Fixed using the following command:
codespell --write-changes --summary --skip=*.m4 --ignore-words-list="develope,get's,quitt,setts,som,ue,vektor"
codespell --write-changes --summary --skip=aclocal.m4,lib --ignore-words-list="develope,get's,quitt,setts,som,ue,vektor"
Codespell home page: https://github.com/codespell-project/codespell
2020-07-24 09:02:48 +02:00
Michael Black W9MDB
133a8acd30
Fix icom MainA/B SubA/B VFO selection
...
https://github.com/Hamlib/Hamlib/issues/348
2020-07-20 14:42:46 +02:00
Michael Black W9MDB
4efbddd0e8
Add ability to set Icom MAIN_VFO_A/B and SUB_VFO_A/B
...
https://github.com/Hamlib/Hamlib/issues/348
2020-07-19 17:21:23 -05:00
Michael Black W9MDB
ba72dc74b2
Upgrade some rigs to STABLE
2020-07-16 11:06:39 -05:00
Michael Black W9MDB
5e801fd2b5
astyle files
2020-07-07 11:39:26 -05:00
Bill Somerville
281febec62
New power on option rather than power on/off
...
Also fixes incorrect token name usage in token definition
2020-07-04 23:23:39 +01:00
Bill Somerville
3f40029720
Add missing config parameters for rig power on/off and screen-saver
...
Defaults set to by compatible with prior released versions to avoid
regressive behaviour.
2020-07-04 19:42:37 +01:00
Michael Black W9MDB
b2dce86e91
Add comment about IC-756 data mode
2020-07-03 23:40:20 -05:00
Michael Black W9MDB
b6a960d48e
All conversions to rig_flush now done
...
https://github.com/Hamlib/Hamlib/issues/307
2020-06-23 09:01:46 -05:00
Michael Black W9MDB
35001b12c0
astyle icom.c
2020-06-21 14:47:38 -05:00
Michael Black W9MDB
362fa77cfd
Move poweron set outside of check to ensure only once whether started power off or on
...
https://github.com/Hamlib/Hamlib/issues/297
2020-06-14 17:20:31 -05:00
Michael Black W9MDB
8fd58e211d
Rigs will only power up once if needed
...
https://github.com/Hamlib/Hamlib/issues/297
2020-06-14 17:14:24 -05:00
Michael Black W9MDB
71b867e141
Add some debug to icom.c
2020-06-14 09:43:42 -05:00
Michael Black W9MDB
c5388b9f37
In icom.c remove priv->curr_vfo and change to rig->state.current_vfo
...
https://github.com/Hamlib/Hamlib/issues/299
2020-06-13 15:53:37 -05:00
Michael Black W9MDB
723f3f0773
Add some more rig cases for MainA/B and Sub A/B priv setting in icom_get_freq
...
Add VFO_CURR as a valid VFO
https://github.com/Hamlib/Hamlib/issues/299
2020-06-13 07:51:35 -05:00
Michael Black W9MDB
2db0da54ea
Add VFO_CURR MAINA/B SUBA/B as valid vfos in icom.c
2020-06-12 17:54:41 -05:00
Michael Black W9MDB
b15c73d2d2
Fix segmentation fault/endless loop for Icom rigs
2020-06-12 16:34:48 -05:00
Michael Black W9MDB
7cdaa0efd1
Change icom.c VFO_TX VFO_RX adjustment to use vfo_fixup function
...
vfo_fixup should be able to handle all rigs variations
https://github.com/Hamlib/Hamlib/issues/299
2020-06-12 07:57:13 -05:00
Michael Black W9MDB
f6112a0d93
Remove block preventing IC910 from reading VFOB during split and returning VFOA
2020-06-11 22:27:38 -05:00
Michael Black W9MDB
b910fa0c58
When get_split_freq_mode is called with RIG_VFO_CURR and split is not enabled
...
we will assume the TX vfo is VFOB or Sub as appropriate
This hopefully makes WSJT-X happy with Icom rigs now.
https://github.com/Hamlib/Hamlib/issues/288
2020-06-11 08:15:52 -05:00
Michael Black W9MDB
9e18b234c2
Change icom_get_split_freq to reset to rx_vfo when done
...
Just like icom_set_split_freq
https://github.com/Hamlib/Hamlib/issues/291
2020-06-10 17:16:52 -05:00
Michael Black W9MDB
876c7bd59f
Fix RIG_VFO_TX clause in icom.c
2020-06-10 08:10:35 -05:00
Michael Black W9MDB
f71c12da94
astyle files
2020-06-09 22:37:03 -05:00
Michael Black W9MDB
750857cdbc
Update comment in icom.c
2020-06-09 22:28:13 -05:00
Michael Black W9MDB
ee8dde16ea
When rig_set_split_freq_mode is called and RIG_VFO_CURR is requested use default tx_vfo
...
https://github.com/Hamlib/Hamlib/issues/288
2020-06-09 12:16:45 -05:00
Michael Black W9MDB
718fcdf0c1
icom.c put one more satmode call in a RIG_FUNC_SATMODE clause
...
https://github.com/Hamlib/Hamlib/issues/288
2020-06-08 23:09:21 -05:00
Michael Black W9MDB
c5732d542e
Fix icom.c so most all satmode requests are restricted to rigs with RIG_FUNC_SATMODE
...
https://github.com/Hamlib/Hamlib/issues/288
2020-06-08 23:04:04 -05:00
Bill Somerville
cc9dfd3b0e
Fixing an operator precedence defect
2020-06-06 02:24:04 +01:00
Michael Black W9MDB
d9d1074f24
Fix IC-910 behavior with gpredict
...
Now allows switching between full duplex, split, and non-split mode
https://github.com/Hamlib/Hamlib/issues/237
2020-06-04 10:37:20 -05:00
Michael Black W9MDB
a8e5a66ffd
Add FT_DX101D as another rig that can't get freq during PTT
...
https://github.com/Hamlib/Hamlib/issues/279
2020-06-03 16:58:42 -05:00
Michael Black
00031994c6
Remove block setting VFO_A -- does not work with rigs that don't have
...
VFO_A
https://github.com/Hamlib/Hamlib/issues/274
2020-06-01 17:38:03 -05:00
Michael Black W9MDB
5df9f81bef
Fix RIG_VFO_NONE problem in icom.c
...
https://github.com/Hamlib/Hamlib/issues/270
2020-05-30 16:59:18 -05:00
Michael Black W9MDB
353066a232
Fix rigctl/rigctld split ops/queries
...
Add vfo_fixup function. We should be able to do all vfo corrections in rig.c instead of backends. So we're migrating that way....
https://github.com/Hamlib/Hamlib/issues/269
2020-05-30 09:34:13 -05:00
Michael Black W9MDB
677ccac4bc
astyle files
2020-05-27 12:23:08 -05:00
Michael Black W9MDB
281022447c
Update some more items in icom.c where appropriate
2020-05-25 09:11:32 -05:00
Michael Black W9MDB
1add89bd71
Add rules for setting VFO_RX and VFO_TX for different rig types
...
https://github.com/Hamlib/Hamlib/issues/261
2020-05-24 23:42:35 -05:00
Michael Black W9MDB
a77a57ff38
Disallow requesting a vfo that the rig doesn't have.
...
This could be changed to automatically selecting a valid VFO so
VFOA=Main or Main=VFOA for example but not sure if we want to do this.
This is already being done for the IC-9700 for example since satmode
only has Main/Sub where non-satmode has MainA/MainB/SubA/SubB
So the question is do we emulate VFOA/B and Main/Sub for all rigs?
2020-05-21 15:51:41 +02:00
Michael Black W9MDB
9c902dd03b
IC-9700 in satmode requesting "S 1 Sub" will now return RIG_OK without
...
taking any action
Since satmode is Sub split anyways this makes sense
https://github.com/Hamlib/Hamlib/issues/254
2020-05-20 06:42:06 +02:00
Michael Black W9MDB
5a631b2f54
Fix icom detection of split mode setting vfos
...
https://github.com/Hamlib/Hamlib/issues/250
2020-05-18 00:39:08 +02:00
Michael Black W9MDB
2e3678d1a7
Fix main/sub frequency saved values
2020-05-17 17:27:28 -05:00
Michael Black W9MDB
ba703787d9
Merge branch 'master' of https://github.com/mdblack98/Hamlib
2020-05-16 15:22:48 -05:00
Michael Black W9MDB
1af1650716
Fix IC_9700 type rigs when client asks for Sub VFO but split or satmode
...
is not in use
https://github.com/Hamlib/Hamlib/issues/250
2020-05-16 21:34:26 +02:00
Michael Black W9MDB
87b25d0c43
If icom rig is asked for VFOA/B but only has Main/Sub
...
then we map VFOA=Main VFOB=Sub
https://github.com/Hamlib/Hamlib/issues/250
2020-05-16 08:31:34 -05:00
Michael Black W9MDB
906a369e00
Change icom behavior for IC-9700 type rig with Main/A/B && Sub A/B setup
...
If Sub is asked for but neither split nor satmode is on it will get changed
to VFOB instead which should avoid doing a VFO swap
https://github.com/Hamlib/Hamlib/issues/250
2020-05-16 07:55:59 -05:00
Michael Black W9MDB
156db580f8
IC-910 (and hopefully IC-9700) now working with gpredict in both simplex non-satmode and full duplex satmode
...
As of 20200514 switching to satmode will automically switch rig to satmode
But switching back to simple requires manually going back to split mode until gpredict provide the correct split mode request of "S 1 VFOB" or "S 1 VFOA"
https://github.com/Hamlib/Hamlib/issues/237
2020-05-14 12:15:37 -04:00
Michael Black W9MDB
9c4dfbc34c
Fix IC910 satellite mode operations
...
https://github.com/Hamlib/Hamlib/issues/237
2020-05-14 10:21:47 -04:00
Michael Black W9MDB
ad7fe1253b
Fix merge
2020-05-12 12:28:19 -05:00
Michael Black W9MDB
6a199559fa
Fix merge
2020-05-12 12:22:51 -05:00
Michael Black W9MDB
fca384dcd6
Fix debug statement in icom.c
2020-05-12 12:16:12 -04:00
Michael Black W9MDB
2813f0ef63
astyle files
2020-05-11 22:39:10 -05:00
Michael Black W9MDB
74cdd96eda
Fix merge of icom.c
2020-05-11 18:05:11 -05:00
Michael Black W9MDB
3b2225e489
Fix IC-910 split mode operation with gpredict
...
https://github.com/Hamlib/Hamlib/issues/237
2020-05-11 19:00:52 -04:00
Michael Black W9MDB
0ffddf779d
Change icom.c set_freq to detect error on bad freq set and swap VFOs back and not update anything
...
Add some more debug
https://github.com/Hamlib/Hamlib/issues/237
2020-05-10 07:40:06 -05:00
Michael Black W9MDB
1a4e61b2dd
Fix several strerror that should be rigerror
2020-05-09 11:52:27 -05:00
mdblack98
0b3605597f
Fix cppcheck warning in icom.c
2020-05-05 22:20:33 -05:00
mdblack98
fa711bb550
Remove unused variable set in icom.c
2020-05-05 22:18:18 -05:00
mdblack98
a3b1b055b3
Fix cppcheck warnings
2020-05-05 11:32:09 -05:00
mdblack98
05ad81bd2c
Update comment in icom.c
2020-05-05 09:50:57 -05:00
mdblack98
baa3787bc5
Add ELAPSED_INVALIDATE for caching use
...
Change rig_get_vfo to use ELAPSED_INVALIDATE
Change elapsed_ms code to make a little more sense
https://github.com/Hamlib/Hamlib/issues/231
2020-05-02 11:19:44 -05:00
mdblack98
48b0234caf
icom.c if VFOA/B is requested for rig without VFOA/A maps to Main/Sub
...
https://github.com/Hamlib/Hamlib/issues/231
2020-05-01 17:51:20 -05:00
mdblack98
2991d43e26
If icom.c rig_get_freq is called and VFO is None then VFO gets set to the requexted VFO
...
https://github.com/Hamlib/Hamlib/issues/231
2020-05-01 10:35:16 -05:00
mdblack98
acc468fcfd
Fix channel reading for civ_731 icom rigs
...
I assume this is true on all such rigs that they return 5 bytes
Writing and reading a channel should confirm it by returning the correct freq
https://github.com/Hamlib/Hamlib/issues/217
2020-04-26 08:45:16 -05:00
mdblack98
7a075ae9fd
https://github.com/Hamlib/Hamlib/issues/222
...
Fix order of calls in icom_get_split_vfos
Need to set split before getting vfos
2020-04-23 22:50:34 -05:00
mdblack98
a9a604758d
https://github.com/Hamlib/Hamlib/issues/222
...
Fix icom_get_split_vfo filling in rx_vfo and tx_vfo
icom_get_split_vfo: vfo=currVFO rx_vfo=None tx_vfo=None split=0
2020-04-23 15:35:29 -05:00
Michael Black
c489f97624
More cppcheck changes
2020-03-20 07:51:32 -05:00
Michael Black
f90046516e
Fix cppcheck item in icom.c
2020-03-16 11:56:34 -05:00
Michael Black
de624c0b8e
Remove get_freq_range from icom_open
2020-03-16 11:17:16 -05:00
Michael Black
35fffc4f38
astyle files
2020-03-15 15:32:46 -05:00
Michael Black
4d06d195e5
Fix ackbuf and add vfo set default in rig_set_split_freq
2020-03-15 15:21:24 -05:00
Michael Black
9ab1130d09
Remove setting default vfo in icom_get_freq.
...
Fix 0x1c0x03 command frequency
2020-03-15 15:03:27 -05:00
Michael Black
4b31563ffb
Change all rc names to retval for consistency
2020-03-14 23:29:07 -05:00
Michael Black
33c1adb158
Add 0x1c 0x03 command to icom_get_freq to eliminate vfo swapping when asking for VFO_TX
2020-03-14 23:25:27 -05:00
Michael Black
d61719ef3b
Add 0x1c 0x03 command to get tx freq in icom_get_split_freq
2020-03-14 22:57:29 -05:00
Michael Black
1e658578ec
Reset x25cmdfails when SATMODE is called
2020-03-14 15:21:56 -05:00
Michael Black
92c6f3924e
Only do x25 command if not in satellite mode for icom rigs
2020-03-14 15:07:49 -05:00
Michael Black
79661711f1
Change 0x25 to constant in icom.c
2020-03-14 14:55:46 -05:00
Michael Black
40ebea303c
astyle icom.c
2020-03-14 14:51:35 -05:00
Michael Black
b1185fb5ff
Set x25cmdfails so it won'r get repeated if not available
2020-03-14 14:51:23 -05:00
Michael Black
f0506f3ab4
Add 0x25 command testing icoms that can set vfos without swapping
2020-03-14 13:00:46 -05:00
Michael Black
e8673161fd
Change icom satmode rigs to return to rx_vfo after set_split_freq
2020-03-13 10:09:32 -05:00
Michael Black
e9ba470d65
Ensure priv->curr_vfo is set to Main for SATMODE rigs as default when no VFO has been set before asking get_* functions
2020-03-13 08:44:01 -05:00
Michael Black
b5680c108d
Working on get_freq_range
2020-03-12 17:53:49 -05:00
Michael Black
6e61069df5
Working on get_freq_range
2020-03-12 17:42:23 -05:00
Michael Black
6983bdd3b0
Working on get_freq_range
2020-03-12 17:32:17 -05:00
Michael Black
793f73475b
Working on get_freq_range
2020-03-12 17:19:20 -05:00
Michael Black
d26006122f
Working on get_freq_range
2020-03-12 17:11:08 -05:00
Michael Black
66b3190fa9
Improve comment in icom.c
2020-03-12 17:01:59 -05:00
Michael Black
e197b90d81
Working on get_freq_range
2020-03-12 16:58:55 -05:00
Michael Black
c8e4e99e97
Reenable icom_get_freq_range now that rigctld stays open after first called
2020-03-12 15:57:05 -05:00
Michael Black
42871be196
Added some places to set default vfo when vfo has not been set yet. We're avoiding setting the default VFO on startup but allowing for clients which don't set the vfo properly.
...
Commented out icom_get_freq_range as can't have this on every rig_open call...too busy for rigctld
2020-03-12 10:12:59 -05:00
Michael Black
7685613310
Add setting of vfo when client does not set vfo themselves and instead asks to do things with RIG_VFO_CURR
2020-03-11 17:37:23 -05:00
Michael Black
40919d703f
Fix icom_get_freq_range index
2020-03-09 23:03:48 -05:00
Michael Black
e6e9d8d8aa
Fix acklen in icom_get_freq_range
2020-03-09 22:56:25 -05:00
Michael Black
d5592f43a8
Remove set_vfo from icom_get_split split=0
2020-03-09 15:37:53 -05:00
Michael Black
ced93c5c7c
Disabel set_vfo calls in icom_set_split
...
Needs to be tested with gpredict operations
2020-03-09 12:25:33 -05:00
Michael Black
aaf8a074d9
Force final VFO selection in icom_set_split
2020-03-09 09:16:30 -05:00
Michael Black
16fed06ba1
Adding dynamic freq_range for Icoms stage2
2020-03-08 23:18:33 -05:00
Michael Black
df1b7620db
Adding dynamic freq_range for Icoms
2020-03-08 10:09:37 -05:00
Michael Black
c21fdf3747
Beginning implementation of dynamic detection of freq_range for Icom rigs
2020-03-08 09:23:11 -05:00
Michael Black
53b1a93431
Fix icom_rig_open return for RIG_OK
2020-03-07 22:00:15 -06:00
Michael Black
117379f42e
Add VFO_A set to IC9700 type Icom rigs
2020-03-06 22:19:03 -06:00
Michael Black
57c7f2a19f
astyle files
2020-03-05 23:49:22 -06:00
Michael Black
30a8a690ca
Fix IC9700 return to VFOA when in split instead of Main
2020-03-05 17:22:51 -06:00
Michael Black
59e92ab829
Fix set_split_vfo for IC9700 and similar rigs
2020-03-05 15:31:56 -06:00
Michael Black
6493d71e1b
Fix spelling error in icom.c
2020-03-05 14:31:19 -06:00