Quell clang warning from adat.c

Comment out the conditional:

                    if( pCmd->pacCmdStrs != NULL )

as the structure does not have a terminating NULL, this expression will
never evaluate to false.  Should the structure assigned be modified to
have a NULL as the last element, then uncomment these lines to restore
the test.
libusb-1-0
Nate Bargmann 2016-02-13 13:45:07 -06:00
rodzic 0e2ee1c4d5
commit dcaa1c7660
1 zmienionych plików z 4 dodań i 4 usunięć

Wyświetl plik

@ -2585,9 +2585,9 @@ int adat_transaction( RIG *pRig,
rig_debug( RIG_DEBUG_TRACE, rig_debug( RIG_DEBUG_TRACE,
"*** ADAT: %d Sending command string ... \n", "*** ADAT: %d Sending command string ... \n",
gFnLevel ); gFnLevel );
// TODO: Quell clang warning of conditional always evaluating to true.
if( pCmd->pacCmdStrs != NULL ) // if( pCmd->pacCmdStrs != NULL )
{ // {
int nJ = 0; int nJ = 0;
if( pCmd->nNrCmdStrs > 0 ) if( pCmd->nNrCmdStrs > 0 )
@ -2622,7 +2622,7 @@ int adat_transaction( RIG *pRig,
nJ++; nJ++;
} }
} }
} // }
} }
if( nRC != RIG_OK ) if( nRC != RIG_OK )