From dcaa1c7660ac5e45dec5f5c7e43c2de84d53fa17 Mon Sep 17 00:00:00 2001 From: Nate Bargmann Date: Sat, 13 Feb 2016 13:45:07 -0600 Subject: [PATCH] Quell clang warning from adat.c Comment out the conditional: if( pCmd->pacCmdStrs != NULL ) as the structure does not have a terminating NULL, this expression will never evaluate to false. Should the structure assigned be modified to have a NULL as the last element, then uncomment these lines to restore the test. --- adat/adat.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/adat/adat.c b/adat/adat.c index f953c9f10..edf21c0d7 100644 --- a/adat/adat.c +++ b/adat/adat.c @@ -2585,9 +2585,9 @@ int adat_transaction( RIG *pRig, rig_debug( RIG_DEBUG_TRACE, "*** ADAT: %d Sending command string ... \n", gFnLevel ); - - if( pCmd->pacCmdStrs != NULL ) - { +// TODO: Quell clang warning of conditional always evaluating to true. +// if( pCmd->pacCmdStrs != NULL ) +// { int nJ = 0; if( pCmd->nNrCmdStrs > 0 ) @@ -2622,7 +2622,7 @@ int adat_transaction( RIG *pRig, nJ++; } } - } +// } } if( nRC != RIG_OK )