Merge branch 'compose-emoji-typing' into 'develop'

AutosuggestTextarea: shouldComponentUpdate fixes

See merge request soapbox-pub/soapbox-fe!278
config-ui-updates
Alex Gleason 2020-09-29 05:07:34 +00:00
commit ca0d39ef88
1 zmienionych plików z 6 dodań i 3 usunięć

Wyświetl plik

@ -160,9 +160,12 @@ export default class AutosuggestTextarea extends ImmutablePureComponent {
}
shouldComponentUpdate(nextProps, nextState) {
// Skip updating when lastToken changes so the cursor doesn't jump around
// due to re-rendering unnecessarily
if (this.state.lastToken !== nextState.lastToken) {
// Skip updating when only the lastToken changes so the
// cursor doesn't jump around due to re-rendering unnecessarily
const lastTokenUpdated = this.state.lastToken !== nextState.lastToken;
const valueUpdated = this.props.value !== nextProps.value;
if (lastTokenUpdated && !valueUpdated) {
return false;
} else {
return super.shouldComponentUpdate(nextProps, nextState);