sforkowany z mirror/soapbox
Merge branch 'more-tests-accounts' into 'develop'
Add tests for 'fetchAccountByUsername' function See merge request soapbox-pub/soapbox-fe!1489dnd
Justin
commit
a13b3b92ba
|
|
@ -5,7 +5,7 @@ import { mockStore } from 'soapbox/jest/test-helpers';
|
|||
import rootReducer from 'soapbox/reducers';
|
||||
|
||||
import { normalizeAccount } from '../../normalizers';
|
||||
import { createAccount, fetchAccount } from '../accounts';
|
||||
import { createAccount, fetchAccount, fetchAccountByUsername } from '../accounts';
|
||||
|
||||
let store;
|
||||
|
||||
|
|
@ -130,3 +130,230 @@ describe('fetchAccount()', () => {
|
|||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe('fetchAccountByUsername()', () => {
|
||||
const id = '123';
|
||||
const username = 'tiger';
|
||||
let state, account;
|
||||
|
||||
describe('when the account has already been cached in redux', () => {
|
||||
beforeEach(() => {
|
||||
account = normalizeAccount({
|
||||
id,
|
||||
acct: username,
|
||||
display_name: 'Tiger',
|
||||
avatar: 'test.jpg',
|
||||
birthday: undefined,
|
||||
});
|
||||
|
||||
state = rootReducer(undefined, {})
|
||||
.set('accounts', ImmutableMap({
|
||||
[id]: account,
|
||||
}));
|
||||
|
||||
store = mockStore(state);
|
||||
|
||||
__stub((mock) => {
|
||||
mock.onGet(`/api/v1/accounts/${id}`).reply(200, account);
|
||||
});
|
||||
});
|
||||
|
||||
it('should return null', async() => {
|
||||
const result = await store.dispatch(fetchAccountByUsername(username));
|
||||
const actions = store.getActions();
|
||||
|
||||
expect(actions).toEqual([]);
|
||||
expect(result).toBeNull();
|
||||
});
|
||||
});
|
||||
|
||||
describe('when "accountByUsername" feature is enabled', () => {
|
||||
beforeEach(() => {
|
||||
const state = rootReducer(undefined, {})
|
||||
.set('instance', {
|
||||
version: '2.7.2 (compatible; Pleroma 2.4.52-1337-g4779199e.gleasonator+soapbox)',
|
||||
pleroma: ImmutableMap({
|
||||
metadata: ImmutableMap({
|
||||
features: [],
|
||||
}),
|
||||
}),
|
||||
})
|
||||
.set('me', '123');
|
||||
store = mockStore(state);
|
||||
});
|
||||
|
||||
describe('with a successful API request', () => {
|
||||
beforeEach(() => {
|
||||
__stub((mock) => {
|
||||
mock.onGet(`/api/v1/accounts/${username}`).reply(200, account);
|
||||
mock.onGet(`/api/v1/accounts/relationships?${[account.id].map(id => `id[]=${id}`).join('&')}`);
|
||||
});
|
||||
});
|
||||
|
||||
it('should return dispatch the proper actions', async() => {
|
||||
await store.dispatch(fetchAccountByUsername(username));
|
||||
const actions = store.getActions();
|
||||
|
||||
expect(actions[0]).toEqual({
|
||||
type: 'RELATIONSHIPS_FETCH_REQUEST',
|
||||
ids: ['123'],
|
||||
skipLoading: true,
|
||||
});
|
||||
expect(actions[1].type).toEqual('ACCOUNTS_IMPORT');
|
||||
expect(actions[2].type).toEqual('ACCOUNT_FETCH_SUCCESS');
|
||||
});
|
||||
});
|
||||
|
||||
describe('with an unsuccessful API request', () => {
|
||||
beforeEach(() => {
|
||||
__stub((mock) => {
|
||||
mock.onGet(`/api/v1/accounts/${username}`).networkError();
|
||||
});
|
||||
});
|
||||
|
||||
it('should return dispatch the proper actions', async() => {
|
||||
const expectedActions = [
|
||||
{
|
||||
type: 'ACCOUNT_FETCH_FAIL',
|
||||
id: null,
|
||||
error: new Error('Network Error'),
|
||||
skipAlert: true,
|
||||
},
|
||||
{ type: 'ACCOUNT_FETCH_FAIL_FOR_USERNAME_LOOKUP', username: 'tiger' },
|
||||
];
|
||||
|
||||
await store.dispatch(fetchAccountByUsername(username));
|
||||
const actions = store.getActions();
|
||||
|
||||
expect(actions).toEqual(expectedActions);
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe('when "accountLookup" feature is enabled', () => {
|
||||
beforeEach(() => {
|
||||
const state = rootReducer(undefined, {})
|
||||
.set('instance', {
|
||||
version: '3.4.1 (compatible; TruthSocial 1.0.0)',
|
||||
pleroma: ImmutableMap({
|
||||
metadata: ImmutableMap({
|
||||
features: [],
|
||||
}),
|
||||
}),
|
||||
})
|
||||
.set('me', '123');
|
||||
store = mockStore(state);
|
||||
});
|
||||
|
||||
describe('with a successful API request', () => {
|
||||
beforeEach(() => {
|
||||
__stub((mock) => {
|
||||
mock.onGet('/api/v1/accounts/lookup').reply(200, account);
|
||||
});
|
||||
});
|
||||
|
||||
it('should return dispatch the proper actions', async() => {
|
||||
await store.dispatch(fetchAccountByUsername(username));
|
||||
const actions = store.getActions();
|
||||
|
||||
expect(actions[0]).toEqual({
|
||||
type: 'ACCOUNT_LOOKUP_REQUEST',
|
||||
acct: username,
|
||||
});
|
||||
expect(actions[1].type).toEqual('ACCOUNTS_IMPORT');
|
||||
expect(actions[2].type).toEqual('ACCOUNT_LOOKUP_SUCCESS');
|
||||
expect(actions[3].type).toEqual('ACCOUNT_FETCH_SUCCESS');
|
||||
});
|
||||
});
|
||||
|
||||
describe('with an unsuccessful API request', () => {
|
||||
beforeEach(() => {
|
||||
__stub((mock) => {
|
||||
mock.onGet('/api/v1/accounts/lookup').networkError();
|
||||
});
|
||||
});
|
||||
|
||||
it('should return dispatch the proper actions', async() => {
|
||||
const expectedActions = [
|
||||
{ type: 'ACCOUNT_LOOKUP_REQUEST', acct: 'tiger' },
|
||||
{ type: 'ACCOUNT_LOOKUP_FAIL' },
|
||||
{
|
||||
type: 'ACCOUNT_FETCH_FAIL',
|
||||
id: null,
|
||||
error: new Error('Network Error'),
|
||||
skipAlert: true,
|
||||
},
|
||||
{ type: 'ACCOUNT_FETCH_FAIL_FOR_USERNAME_LOOKUP', username },
|
||||
];
|
||||
|
||||
await store.dispatch(fetchAccountByUsername(username));
|
||||
const actions = store.getActions();
|
||||
|
||||
expect(actions).toEqual(expectedActions);
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe('when using the accountSearch function', () => {
|
||||
beforeEach(() => {
|
||||
const state = rootReducer(undefined, {}).set('me', '123');
|
||||
store = mockStore(state);
|
||||
});
|
||||
|
||||
describe('with a successful API request', () => {
|
||||
beforeEach(() => {
|
||||
__stub((mock) => {
|
||||
mock.onGet('/api/v1/accounts/search').reply(200, [account]);
|
||||
});
|
||||
});
|
||||
|
||||
it('should return dispatch the proper actions', async() => {
|
||||
await store.dispatch(fetchAccountByUsername(username));
|
||||
const actions = store.getActions();
|
||||
|
||||
expect(actions[0]).toEqual({
|
||||
type: 'ACCOUNT_SEARCH_REQUEST',
|
||||
params: { q: username, limit: 5, resolve: true },
|
||||
});
|
||||
expect(actions[1].type).toEqual('ACCOUNTS_IMPORT');
|
||||
expect(actions[2].type).toEqual('ACCOUNT_SEARCH_SUCCESS');
|
||||
expect(actions[3]).toEqual({
|
||||
type: 'RELATIONSHIPS_FETCH_REQUEST',
|
||||
ids: [ '123' ],
|
||||
skipLoading: true,
|
||||
});
|
||||
expect(actions[4].type).toEqual('ACCOUNT_FETCH_SUCCESS');
|
||||
});
|
||||
});
|
||||
|
||||
describe('with an unsuccessful API request', () => {
|
||||
beforeEach(() => {
|
||||
__stub((mock) => {
|
||||
mock.onGet('/api/v1/accounts/search').networkError();
|
||||
});
|
||||
});
|
||||
|
||||
it('should return dispatch the proper actions', async() => {
|
||||
const expectedActions = [
|
||||
{
|
||||
type: 'ACCOUNT_SEARCH_REQUEST',
|
||||
params: { q: username, limit: 5, resolve: true },
|
||||
},
|
||||
{ type: 'ACCOUNT_SEARCH_FAIL', skipAlert: true },
|
||||
{
|
||||
type: 'ACCOUNT_FETCH_FAIL',
|
||||
id: null,
|
||||
error: new Error('Network Error'),
|
||||
skipAlert: true,
|
||||
},
|
||||
{ type: 'ACCOUNT_FETCH_FAIL_FOR_USERNAME_LOOKUP', username },
|
||||
];
|
||||
|
||||
await store.dispatch(fetchAccountByUsername(username));
|
||||
const actions = store.getActions();
|
||||
|
||||
expect(actions).toEqual(expectedActions);
|
||||
});
|
||||
});
|
||||
});
|
||||
});
|
||||
|
|
|
|||
|
|
@ -160,7 +160,7 @@ export function fetchAccountByUsername(username) {
|
|||
|
||||
if (account) {
|
||||
dispatch(fetchAccount(account.get('id')));
|
||||
return;
|
||||
return null;
|
||||
}
|
||||
|
||||
const instance = state.get('instance');
|
||||
|
|
@ -168,7 +168,7 @@ export function fetchAccountByUsername(username) {
|
|||
const me = state.get('me');
|
||||
|
||||
if (features.accountByUsername && (me || !features.accountLookup)) {
|
||||
api(getState).get(`/api/v1/accounts/${username}`).then(response => {
|
||||
return api(getState).get(`/api/v1/accounts/${username}`).then(response => {
|
||||
dispatch(fetchRelationships([response.data.id]));
|
||||
dispatch(importFetchedAccount(response.data));
|
||||
dispatch(fetchAccountSuccess(response.data));
|
||||
|
|
@ -177,14 +177,14 @@ export function fetchAccountByUsername(username) {
|
|||
dispatch(importErrorWhileFetchingAccountByUsername(username));
|
||||
});
|
||||
} else if (features.accountLookup) {
|
||||
dispatch(accountLookup(username)).then(account => {
|
||||
return dispatch(accountLookup(username)).then(account => {
|
||||
dispatch(fetchAccountSuccess(account));
|
||||
}).catch(error => {
|
||||
dispatch(fetchAccountFail(null, error));
|
||||
dispatch(importErrorWhileFetchingAccountByUsername(username));
|
||||
});
|
||||
} else {
|
||||
dispatch(accountSearch({
|
||||
return dispatch(accountSearch({
|
||||
q: username,
|
||||
limit: 5,
|
||||
resolve: true,
|
||||
|
|
|
|||
Ładowanie…
Reference in New Issue