Merge branch 'eslint-rules' into 'develop'

eslint: add key-spacing and space-unary-ops rules

See merge request soapbox-pub/soapbox-fe!890

.eslintrc.js

@@ -69,6 +69,10 @@ module.exports = {
     eqeqeq: 'error',
     indent: ['error', 2],
     'jsx-quotes': ['error', 'prefer-single'],
+    'key-spacing': [
+      'error',
+      { mode: 'minimum' },
+    ],
     'no-catch-shadow': 'error',
     'no-cond-assign': 'error',
     'no-console': [
@@ -111,6 +115,13 @@ module.exports = {
     'prefer-const': 'error',
     quotes: ['error', 'single'],
     semi: 'error',
+    'space-unary-ops': [
+      'error',
+      {
+        words: true,
+        nonwords: false,
+      },
+    ],
     strict: 'off',
     'valid-typeof': 'error',
 

app/soapbox/actions/lists.js

@@ -367,7 +367,7 @@ export const fetchAccountLists = accountId => (dispatch, getState) => {
 };
 
 export const fetchAccountListsRequest = id => ({
-  type:LIST_ADDER_LISTS_FETCH_REQUEST,
+  type: LIST_ADDER_LISTS_FETCH_REQUEST,
   id,
 });
 

app/soapbox/features/account/components/header.js

@@ -235,7 +235,7 @@ class Header extends ImmutablePureComponent {
         menu.push({
           text: intl.formatMessage(messages.direct, { name: account.get('username') }),
           action: this.props.onDirect,
-          icon:require('@tabler/icons/icons/mail.svg'),
+          icon: require('@tabler/icons/icons/mail.svg'),
         });
       }
 

app/soapbox/features/conversations/components/conversation.js

@@ -14,7 +14,7 @@ export default class Conversation extends ImmutablePureComponent {
     conversationId: PropTypes.string.isRequired,
     accounts: ImmutablePropTypes.list.isRequired,
     lastStatusId: PropTypes.string,
-    unread:PropTypes.bool.isRequired,
+    unread: PropTypes.bool.isRequired,
     onMoveUp: PropTypes.func,
     onMoveDown: PropTypes.func,
     markRead: PropTypes.func.isRequired,

app/soapbox/features/ui/components/accordion.js

@@ -34,7 +34,7 @@ export default @injectIntl class Accordion extends React.PureComponent {
     const { headline, children, menu, expanded, intl } = this.props;
 
     return (
-      <div className={classNames('accordion', { 'accordion--expanded' : expanded })}>
+      <div className={classNames('accordion', { 'accordion--expanded': expanded })}>
         {menu && (
           <div className='accordion__menu'>
             <DropdownMenu items={menu} icon='ellipsis-v' size={18} direction='right' />

app/soapbox/features/ui/components/columns_area.js

@@ -16,7 +16,7 @@ class ColumnsArea extends ImmutablePureComponent {
 
   render() {
     const { children } = this.props;
-    const layout = this.props.layout || { LEFT:null, RIGHT:null };
+    const layout = this.props.layout || { LEFT: null, RIGHT: null };
 
     return (
       <div className='page'>

app/soapbox/features/ui/components/modal_root.js

@@ -38,7 +38,7 @@ const MODAL_COMPONENTS = {
   'EMBED': EmbedModal,
   'LIST_EDITOR': ListEditor,
   'FOCAL_POINT': FocalPointModal,
-  'LIST_ADDER':ListAdder,
+  'LIST_ADDER': ListAdder,
   'HOTKEYS': HotkeysModal,
   'COMPOSE': ComposeModal,
   'UNAUTHORIZED': UnauthorizedModal,

app/soapbox/features/ui/components/profile_dropdown.js

@@ -127,7 +127,7 @@ class ProfileDropdown extends React.PureComponent {
     });
 
     return (
-      <div className='compose__action-bar' style={{ 'marginTop':'-6px' }}>
+      <div className='compose__action-bar' style={{ marginTop: '-6px' }}>
         <div className='compose__action-bar-dropdown'>
           <DropdownMenuContainer items={menu} icon='chevron-down' size={size} direction='right' />
         </div>

webpack/translationRunner.js

@@ -152,7 +152,7 @@ const extractedMessages = extractedMessagesFiles.reduce((acc, messageFile) => {
 const translations = languages.map((language) => {
   return {
     language: language,
-    data : JSON.parse(fs.readFileSync(path.join(translationsDirectory, language + '.json'), 'utf8')),
+    data: JSON.parse(fs.readFileSync(path.join(translationsDirectory, language + '.json'), 'utf8')),
   };
 });