2020-04-14 17:30:26 +00:00
|
|
|
module.exports = {
|
|
|
|
root: true,
|
|
|
|
|
2022-02-27 00:13:35 +00:00
|
|
|
extends: [
|
|
|
|
'eslint:recommended',
|
|
|
|
'plugin:import/typescript',
|
2022-07-21 17:19:36 +00:00
|
|
|
'plugin:compat/recommended',
|
2022-02-27 00:13:35 +00:00
|
|
|
],
|
2021-08-03 19:29:36 +00:00
|
|
|
|
2020-04-14 17:30:26 +00:00
|
|
|
env: {
|
|
|
|
browser: true,
|
|
|
|
node: true,
|
|
|
|
es6: true,
|
|
|
|
jest: true,
|
|
|
|
},
|
|
|
|
|
|
|
|
globals: {
|
|
|
|
ATTACHMENT_HOST: false,
|
|
|
|
},
|
|
|
|
|
|
|
|
parser: 'babel-eslint',
|
|
|
|
|
|
|
|
plugins: [
|
|
|
|
'react',
|
2022-05-12 02:08:04 +00:00
|
|
|
'jsdoc',
|
2020-04-14 17:30:26 +00:00
|
|
|
'jsx-a11y',
|
|
|
|
'import',
|
|
|
|
'promise',
|
2020-06-10 03:52:24 +00:00
|
|
|
'react-hooks',
|
2022-04-27 14:11:21 +00:00
|
|
|
'@typescript-eslint',
|
2020-04-14 17:30:26 +00:00
|
|
|
],
|
|
|
|
|
|
|
|
parserOptions: {
|
|
|
|
sourceType: 'module',
|
|
|
|
ecmaFeatures: {
|
|
|
|
experimentalObjectRestSpread: true,
|
|
|
|
jsx: true,
|
|
|
|
},
|
|
|
|
ecmaVersion: 2018,
|
|
|
|
},
|
|
|
|
|
|
|
|
settings: {
|
|
|
|
react: {
|
|
|
|
version: 'detect',
|
|
|
|
},
|
2022-03-09 19:23:52 +00:00
|
|
|
'import/extensions': ['.js', '.jsx', '.ts', '.tsx'],
|
2020-04-14 17:30:26 +00:00
|
|
|
'import/ignore': [
|
|
|
|
'node_modules',
|
|
|
|
'\\.(css|scss|json)$',
|
|
|
|
],
|
|
|
|
'import/resolver': {
|
|
|
|
node: {
|
|
|
|
paths: ['app'],
|
|
|
|
},
|
|
|
|
},
|
2022-07-21 17:19:36 +00:00
|
|
|
polyfills: [
|
|
|
|
'es:all',
|
|
|
|
'fetch',
|
|
|
|
'IntersectionObserver',
|
|
|
|
'Promise',
|
|
|
|
'URL',
|
|
|
|
'URLSearchParams',
|
|
|
|
],
|
2020-04-14 17:30:26 +00:00
|
|
|
},
|
|
|
|
|
|
|
|
rules: {
|
2021-08-03 19:41:27 +00:00
|
|
|
'brace-style': 'error',
|
2020-04-14 17:30:26 +00:00
|
|
|
'comma-dangle': ['error', 'always-multiline'],
|
|
|
|
'comma-spacing': [
|
|
|
|
'warn',
|
|
|
|
{
|
|
|
|
before: false,
|
|
|
|
after: true,
|
|
|
|
},
|
|
|
|
],
|
|
|
|
'comma-style': ['warn', 'last'],
|
2020-04-14 21:47:35 +00:00
|
|
|
'space-before-function-paren': ['error', 'never'],
|
2022-05-11 17:40:34 +00:00
|
|
|
'space-infix-ops': 'error',
|
2020-04-14 21:47:35 +00:00
|
|
|
'space-in-parens': ['error', 'never'],
|
2022-05-11 17:40:34 +00:00
|
|
|
'keyword-spacing': 'error',
|
2020-04-14 17:30:26 +00:00
|
|
|
'dot-notation': 'error',
|
|
|
|
eqeqeq: 'error',
|
2022-03-03 22:00:43 +00:00
|
|
|
indent: ['error', 2, {
|
2022-05-11 21:06:35 +00:00
|
|
|
SwitchCase: 1, // https://stackoverflow.com/a/53055584/8811886
|
2022-03-03 22:00:43 +00:00
|
|
|
ignoredNodes: ['TemplateLiteral'],
|
|
|
|
}],
|
2020-04-14 17:30:26 +00:00
|
|
|
'jsx-quotes': ['error', 'prefer-single'],
|
2021-11-24 17:28:35 +00:00
|
|
|
'key-spacing': [
|
|
|
|
'error',
|
|
|
|
{ mode: 'minimum' },
|
|
|
|
],
|
2020-04-14 17:30:26 +00:00
|
|
|
'no-catch-shadow': 'error',
|
|
|
|
'no-cond-assign': 'error',
|
|
|
|
'no-console': [
|
|
|
|
'warn',
|
|
|
|
{
|
|
|
|
allow: [
|
|
|
|
'error',
|
|
|
|
'warn',
|
|
|
|
],
|
|
|
|
},
|
|
|
|
],
|
2021-08-03 19:22:51 +00:00
|
|
|
'no-extra-semi': 'error',
|
2021-08-03 19:29:36 +00:00
|
|
|
'no-const-assign': 'error',
|
2020-04-14 17:30:26 +00:00
|
|
|
'no-fallthrough': 'error',
|
|
|
|
'no-irregular-whitespace': 'error',
|
2021-08-03 19:29:36 +00:00
|
|
|
'no-loop-func': 'error',
|
2020-04-18 19:04:18 +00:00
|
|
|
'no-mixed-spaces-and-tabs': 'error',
|
2020-04-14 17:30:26 +00:00
|
|
|
'no-nested-ternary': 'warn',
|
2022-04-10 18:18:10 +00:00
|
|
|
'no-restricted-imports': ['error', {
|
|
|
|
patterns: [{
|
|
|
|
group: ['react-inlinesvg'],
|
|
|
|
message: 'Use the SvgIcon component instead.',
|
|
|
|
}],
|
|
|
|
}],
|
2020-04-14 17:30:26 +00:00
|
|
|
'no-trailing-spaces': 'warn',
|
|
|
|
'no-undef': 'error',
|
|
|
|
'no-unreachable': 'error',
|
|
|
|
'no-unused-expressions': 'error',
|
2022-04-27 14:11:21 +00:00
|
|
|
'no-unused-vars': 'off',
|
|
|
|
'@typescript-eslint/no-unused-vars': [
|
2020-04-14 17:30:26 +00:00
|
|
|
'error',
|
|
|
|
{
|
|
|
|
vars: 'all',
|
2020-04-14 20:45:38 +00:00
|
|
|
args: 'none',
|
2020-04-14 17:30:26 +00:00
|
|
|
ignoreRestSiblings: true,
|
|
|
|
},
|
|
|
|
],
|
2021-08-03 19:29:36 +00:00
|
|
|
'no-useless-escape': 'warn',
|
|
|
|
'no-var': 'error',
|
2020-04-14 17:30:26 +00:00
|
|
|
'object-curly-spacing': ['error', 'always'],
|
|
|
|
'padded-blocks': [
|
|
|
|
'error',
|
|
|
|
{
|
|
|
|
classes: 'always',
|
|
|
|
},
|
|
|
|
],
|
2021-08-03 19:29:36 +00:00
|
|
|
'prefer-const': 'error',
|
2020-04-14 17:30:26 +00:00
|
|
|
quotes: ['error', 'single'],
|
|
|
|
semi: 'error',
|
2021-11-24 17:28:35 +00:00
|
|
|
'space-unary-ops': [
|
|
|
|
'error',
|
|
|
|
{
|
|
|
|
words: true,
|
|
|
|
nonwords: false,
|
|
|
|
},
|
|
|
|
],
|
2020-04-14 17:30:26 +00:00
|
|
|
strict: 'off',
|
|
|
|
'valid-typeof': 'error',
|
|
|
|
|
|
|
|
'react/jsx-boolean-value': 'error',
|
|
|
|
'react/jsx-closing-bracket-location': ['error', 'line-aligned'],
|
|
|
|
'react/jsx-curly-spacing': 'error',
|
|
|
|
'react/jsx-equals-spacing': 'error',
|
|
|
|
'react/jsx-first-prop-new-line': ['error', 'multiline-multiprop'],
|
|
|
|
'react/jsx-indent': ['error', 2],
|
2022-03-21 18:09:01 +00:00
|
|
|
// 'react/jsx-no-bind': ['error'],
|
2022-04-11 00:59:53 +00:00
|
|
|
'react/jsx-no-comment-textnodes': 'error',
|
2020-04-14 17:30:26 +00:00
|
|
|
'react/jsx-no-duplicate-props': 'error',
|
|
|
|
'react/jsx-no-undef': 'error',
|
|
|
|
'react/jsx-tag-spacing': 'error',
|
|
|
|
'react/jsx-uses-react': 'error',
|
|
|
|
'react/jsx-uses-vars': 'error',
|
|
|
|
'react/jsx-wrap-multilines': 'error',
|
|
|
|
'react/no-multi-comp': 'off',
|
|
|
|
'react/no-string-refs': 'error',
|
|
|
|
'react/self-closing-comp': 'error',
|
|
|
|
|
|
|
|
'jsx-a11y/accessible-emoji': 'warn',
|
|
|
|
'jsx-a11y/alt-text': 'warn',
|
|
|
|
'jsx-a11y/anchor-has-content': 'warn',
|
|
|
|
'jsx-a11y/anchor-is-valid': [
|
|
|
|
'warn',
|
|
|
|
{
|
|
|
|
components: [
|
|
|
|
'Link',
|
|
|
|
'NavLink',
|
|
|
|
],
|
|
|
|
specialLink: [
|
|
|
|
'to',
|
|
|
|
],
|
|
|
|
aspect: [
|
|
|
|
'noHref',
|
|
|
|
'invalidHref',
|
|
|
|
'preferButton',
|
|
|
|
],
|
|
|
|
},
|
|
|
|
],
|
|
|
|
'jsx-a11y/aria-activedescendant-has-tabindex': 'warn',
|
|
|
|
'jsx-a11y/aria-props': 'warn',
|
|
|
|
'jsx-a11y/aria-proptypes': 'warn',
|
|
|
|
'jsx-a11y/aria-role': 'warn',
|
|
|
|
'jsx-a11y/aria-unsupported-elements': 'warn',
|
|
|
|
'jsx-a11y/heading-has-content': 'warn',
|
|
|
|
'jsx-a11y/html-has-lang': 'warn',
|
|
|
|
'jsx-a11y/iframe-has-title': 'warn',
|
|
|
|
'jsx-a11y/img-redundant-alt': 'warn',
|
|
|
|
'jsx-a11y/interactive-supports-focus': 'warn',
|
|
|
|
'jsx-a11y/label-has-for': 'off',
|
|
|
|
'jsx-a11y/mouse-events-have-key-events': 'warn',
|
|
|
|
'jsx-a11y/no-access-key': 'warn',
|
|
|
|
'jsx-a11y/no-distracting-elements': 'warn',
|
|
|
|
'jsx-a11y/no-noninteractive-element-interactions': [
|
|
|
|
'warn',
|
|
|
|
{
|
|
|
|
handlers: [
|
|
|
|
'onClick',
|
|
|
|
],
|
|
|
|
},
|
|
|
|
],
|
|
|
|
'jsx-a11y/no-onchange': 'warn',
|
|
|
|
'jsx-a11y/no-redundant-roles': 'warn',
|
|
|
|
'jsx-a11y/no-static-element-interactions': [
|
|
|
|
'warn',
|
|
|
|
{
|
|
|
|
handlers: [
|
|
|
|
'onClick',
|
|
|
|
],
|
|
|
|
},
|
|
|
|
],
|
|
|
|
'jsx-a11y/role-has-required-aria-props': 'warn',
|
|
|
|
'jsx-a11y/role-supports-aria-props': 'off',
|
|
|
|
'jsx-a11y/scope': 'warn',
|
|
|
|
'jsx-a11y/tabindex-no-positive': 'warn',
|
|
|
|
|
|
|
|
'import/extensions': [
|
|
|
|
'error',
|
|
|
|
'always',
|
|
|
|
{
|
|
|
|
js: 'never',
|
2020-04-14 20:45:38 +00:00
|
|
|
mjs: 'ignorePackages',
|
2022-02-27 00:13:35 +00:00
|
|
|
jsx: 'never',
|
|
|
|
ts: 'never',
|
|
|
|
tsx: 'never',
|
2020-04-14 17:30:26 +00:00
|
|
|
},
|
|
|
|
],
|
|
|
|
'import/newline-after-import': 'error',
|
|
|
|
'import/no-extraneous-dependencies': [
|
|
|
|
'error',
|
2022-04-04 15:53:47 +00:00
|
|
|
// {
|
|
|
|
// devDependencies: [
|
|
|
|
// 'webpack/**',
|
|
|
|
// 'app/soapbox/test_setup.js',
|
|
|
|
// 'app/soapbox/test_helpers.js',
|
|
|
|
// 'app/**/__tests__/**',
|
|
|
|
// 'app/**/__mocks__/**',
|
|
|
|
// ],
|
|
|
|
// },
|
2020-04-14 17:30:26 +00:00
|
|
|
],
|
|
|
|
'import/no-unresolved': 'error',
|
|
|
|
'import/no-webpack-loader-syntax': 'error',
|
2022-01-10 22:01:24 +00:00
|
|
|
'import/order': [
|
|
|
|
'error',
|
|
|
|
{
|
|
|
|
groups: [
|
|
|
|
'builtin',
|
|
|
|
'external',
|
|
|
|
'internal',
|
|
|
|
'parent',
|
|
|
|
'sibling',
|
|
|
|
'index',
|
|
|
|
'object',
|
|
|
|
'type',
|
|
|
|
],
|
2022-01-10 22:25:06 +00:00
|
|
|
'newlines-between': 'always',
|
2022-01-10 22:17:52 +00:00
|
|
|
alphabetize: { order: 'asc' },
|
2022-01-10 22:01:24 +00:00
|
|
|
},
|
|
|
|
],
|
2022-06-07 20:21:18 +00:00
|
|
|
'@typescript-eslint/no-duplicate-imports': 'error',
|
2020-04-14 17:30:26 +00:00
|
|
|
|
|
|
|
'promise/catch-or-return': 'error',
|
2020-06-10 03:52:24 +00:00
|
|
|
|
|
|
|
'react-hooks/rules-of-hooks': 'error',
|
2020-04-14 17:30:26 +00:00
|
|
|
},
|
2022-03-07 18:43:40 +00:00
|
|
|
overrides: [
|
|
|
|
{
|
2022-03-18 18:16:59 +00:00
|
|
|
files: ['**/*.ts', '**/*.tsx'],
|
2022-03-09 19:23:52 +00:00
|
|
|
rules: {
|
2022-03-18 18:16:59 +00:00
|
|
|
'no-undef': 'off', // https://stackoverflow.com/a/69155899
|
2022-09-27 13:59:01 +00:00
|
|
|
'space-before-function-paren': 'off',
|
2022-03-07 18:43:40 +00:00
|
|
|
},
|
2022-03-18 18:16:59 +00:00
|
|
|
parser: '@typescript-eslint/parser',
|
2022-03-09 19:23:52 +00:00
|
|
|
},
|
2022-05-12 02:08:04 +00:00
|
|
|
{
|
|
|
|
// Only enforce JSDoc comments on UI components for now.
|
|
|
|
// https://www.npmjs.com/package/eslint-plugin-jsdoc
|
|
|
|
files: ['app/soapbox/components/ui/**/*'],
|
|
|
|
rules: {
|
|
|
|
'jsdoc/require-jsdoc': ['error', {
|
|
|
|
publicOnly: true,
|
|
|
|
require: {
|
|
|
|
ArrowFunctionExpression: true,
|
|
|
|
ClassDeclaration: true,
|
|
|
|
ClassExpression: true,
|
|
|
|
FunctionDeclaration: true,
|
|
|
|
FunctionExpression: true,
|
|
|
|
MethodDefinition: true,
|
|
|
|
},
|
|
|
|
}],
|
|
|
|
},
|
|
|
|
},
|
2022-03-07 18:43:40 +00:00
|
|
|
],
|
2020-04-14 17:30:26 +00:00
|
|
|
};
|