Hypolite Petovan
1f20111c80
Replace share_header calls with BBCode::getShareOpeningTag
2020-06-18 08:53:57 -04:00
Hypolite Petovan
cd74fb8609
Add new Content\BBCode::getShareOpeningTag
2020-06-18 08:53:30 -04:00
Hypolite Petovan
f544c8383b
Implement pull request feedback
...
- Improve formatting of drop_item in mod/item
- Replace deprecated Logger::log() calls in Protocol\Feed::consume
2020-06-17 21:44:28 -04:00
Hypolite Petovan
4e7c45f835
Add PageInfo result panels to Debug\Babel
2020-06-17 13:24:44 -04:00
Hypolite Petovan
f3323aff5e
Deprecate page_info functions to new PageInfo class
...
- Add tests for parts not using remote requests
- Add scheme requirement for page info URLs
- Add policy to keep label from stripped Page Info links
2020-06-17 13:24:44 -04:00
Hypolite Petovan
eba964ec12
Deprecate consume_feed() in favor of Protocol\Feed::consume
2020-06-17 13:24:44 -04:00
Hypolite Petovan
e3d20b4366
Move subscribe_to_hub function to Worker/OnePoll from include/items
...
- It was its only usage
2020-06-17 13:24:44 -04:00
Hypolite Petovan
51925f2994
Add new endsWith method to Util\Strings
2020-06-17 13:24:44 -04:00
Michael Vogel
df03b19a9d
Merge pull request #8783 from MrPetovan/bug/8488-exclude-img-tags
...
Exclude [img] tags from tag replacement
2020-06-17 08:20:50 +02:00
Michael
1a86167ac5
Possibly fix "Undefined index: url"
2020-06-16 20:41:34 +00:00
Hypolite Petovan
f9ecbbd743
Exclude [img] tags from tag replacement
...
- It broke image captions by inserting an HTML link inside an HTML attribute
2020-06-16 16:34:16 -04:00
Michael
8707ced2f7
Hopefully fixes notice "Undefined index: gravity"
2020-06-16 20:30:25 +00:00
Michael Vogel
c5e5defc29
Update src/Module/Admin/Site.php
...
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2020-06-16 14:37:36 +02:00
Michael
016c99935c
Different comment limits for single view
2020-06-16 06:49:53 +00:00
Michael
e1dac1a87a
Categories are not showing up at the bottom of the post
...
Fixes friendica/friendica#8766
2020-06-15 03:43:51 +00:00
Hypolite Petovan
4dc68b32b5
Merge pull request #8772 from annando/post-update
...
Speed up post update for gsid
2020-06-14 14:57:10 -04:00
Michael Vogel
6b93a7e395
Speed up post update for gsid
2020-06-14 18:09:59 +02:00
Michael
8ec2b21a14
Abuse mail received because of "unusual traffic"
...
Fixes friendica/friendica#8663
2020-06-14 15:47:47 +00:00
Hypolite Petovan
5f43f56f72
Merge pull request #8770 from annando/probing
...
Reduced network request when probing
2020-06-14 11:18:16 -04:00
Michael Vogel
f10062dfdb
Merge pull request #8617 from MrPetovan/task/8220-twitter-followers-list
...
(Re)Implement Twitter contact API endpoints
2020-06-14 16:06:22 +02:00
Michael
b948887221
Reduced network request when probing
2020-06-14 13:37:28 +00:00
Hypolite Petovan
f60697110e
Clear all previous template variables before replacing Macros in FriendicaSmartyEngine
...
- Prevents variables leaking between replaceMacros() calls
2020-06-12 22:06:09 -04:00
Michael Vogel
aedbb0d627
Merge pull request #8753 from MrPetovan/bug/fatal-errors
...
Remove dependency to App in Contact::createFromProbe
2020-06-12 06:58:20 +02:00
Michael Vogel
9b85d0b16e
Merge pull request #8740 from MrPetovan/task/frio-improve-share-display
...
[frio] Improve share blocks display
2020-06-11 07:32:29 +02:00
Michael Vogel
a5d1c0ff78
Merge pull request #8754 from MrPetovan/task/8676-ap-attachments
...
Strip the link preview URL from the end of the body if any in ActivityPub\Processor
2020-06-11 06:29:33 +02:00
Hypolite Petovan
7919860274
Merge pull request #8757 from annando/simplify-probe
...
Simplify the probing process
2020-06-10 15:33:03 -04:00
Michael
e49de92cd4
Simplify the probing process
2020-06-10 19:19:10 +00:00
Hypolite Petovan
db3f90ec01
Replace mention to $_SERVER with parameter in Content\Markdown::convert
...
- $_SERVER key isn't always available, no idea what it was used for exactly
2020-06-10 11:40:18 -04:00
Hypolite Petovan
53b951a179
Strip the link preview URL from the end of the body if any in ActivityPub\Processor
2020-06-10 11:19:44 -04:00
Hypolite Petovan
a5a7855d39
Remove dependency to App in Contact::createFromProbe
...
- Address https://github.com/friendica/friendica/issues/8473#issuecomment-641259906
2020-06-10 10:36:42 -04:00
Hypolite Petovan
9b2d758c1a
Add no-parsing block escaping in BBCode::setMentions
2020-06-10 10:16:07 -04:00
Hypolite Petovan
eaa7740da6
Remove superfluous code
...
- Remove explicit default parameter value in BBCode::convertShareCallback
- Remove Probe::$baseurl reset since the twitter probe sets the `baseurl` property
- Remove baseurl guessing in Probe::detect
2020-06-10 10:15:54 -04:00
Hypolite Petovan
a5f0225d60
Add mention support to shared content
2020-06-10 10:15:54 -04:00
Hypolite Petovan
e7f50a05d1
Move handle_tag() to Content\Item::replaceTag
2020-06-10 10:13:32 -04:00
Hypolite Petovan
be41095936
Add probe data return if Contact::getDetailsByURL didn't yield a result in Contact::getDetailsByAddr
2020-06-10 09:56:01 -04:00
Hypolite Petovan
2233fa0e46
Fix issue with Probe returning local baseurl for probed Twitter accounts
2020-06-10 09:56:01 -04:00
Hypolite Petovan
5f18d27b0b
Merge pull request #8752 from annando/posts-from-id
...
Avoid unneeded database calls when showing posts of contacts
2020-06-10 00:11:51 -04:00
Hypolite Petovan
8e14836152
Merge pull request #8751 from annando/notice
...
Fix notice "Undefined index: template in src/Network/Probe.php on line 598"
2020-06-10 00:10:32 -04:00
Michael
0e9331a1ff
Avoid unneeded database calls when showing posts of contacts
2020-06-09 22:38:06 +00:00
Michael
e485836a24
Fix notice " Undefined index: template in src/Network/Probe.php on line 598"
2020-06-09 20:44:55 +00:00
Michael Vogel
6a23f51549
Merge pull request #8749 from MrPetovan/task/8676-ap-attachments
...
Add quote support in attachment title in ActivityPub\Processor
2020-06-09 22:23:26 +02:00
Michael Vogel
ad47ff50a9
Merge pull request #8729 from MrPetovan/bug/8726-mention-parsing
...
Add tag escaping to BBCode::setTags
2020-06-09 22:03:06 +02:00
AlfredSK
66723023f9
fix-continue-warnings
2020-06-09 16:40:36 +00:00
Hypolite Petovan
fdb22320ff
Add quote support in attachment title in ActivityPub\Processor
2020-06-09 08:53:48 -04:00
Hypolite Petovan
8111ede2e5
Add support for max_id parameter in new Twitter contact API endpoints
...
- Use filter_input instead of manual type casting
2020-06-09 08:36:53 -04:00
Hypolite Petovan
7a5afc10bb
Implement Twitter contact endpoints
...
- Implement /followers/ids
- Implement /followers/list
- Reimplement /friends/ids
- Reimplement /friends/list
- Update API reference
- Remove obsolete tests
2020-06-09 08:36:46 -04:00
Hypolite Petovan
173264eaab
Add Twitter User Object and Factory
2020-06-08 21:51:42 -04:00
Hypolite Petovan
89b3ae2657
Add null/empty string parameter value case in BBCode::convert
...
- Remove obsolete coalesce operator uses
2020-06-08 19:15:08 -04:00
Hypolite Petovan
76460ddd2d
Add tag escaping to Item::setHashtags
...
- Add return value to Item::setHashtags
2020-06-08 18:40:21 -04:00
Hypolite Petovan
472018191b
Add tag escaping to BBCode::setTags
2020-06-08 18:40:20 -04:00
Hypolite Petovan
0bc7b89530
Replace existing block escaping by performWitEscaped* calls
2020-06-08 18:40:20 -04:00
Hypolite Petovan
348b71d0b0
Add new Strings::performWithEscapedBlocks methods
...
- Add new BBCode::performWithEscapedTags method
- Add tests
2020-06-08 18:40:20 -04:00
Hypolite Petovan
4d3dd28c44
Add check for existing attachment in ActivityPub\Processor::constructAttachList
2020-06-07 16:23:57 -04:00
Hypolite Petovan
01e9beffc2
[ActivityPub] Add support for more attachments structures
...
- Add support for type: Page into [attachment], type: Link using href attribute
- Ensure Receiver::process* parameter is an array
- Remove superfluous eptiness check in JsonLD::fetchElementArray
2020-06-07 15:41:11 -04:00
Hypolite Petovan
8eeb7807d3
Replace remaining instances with "allowlist", "denylist" and "blocklist"
2020-06-07 11:24:56 -04:00
Hypolite Petovan
530ff51898
Rename system config value to db_log_index_denylist
2020-06-07 11:24:56 -04:00
Hypolite Petovan
34463f37e4
Rename contact table column to ffi_keyword_denylist
2020-06-07 11:24:52 -04:00
Hypolite Petovan
586eddbd1a
Merge pull request #8738 from annando/jsonld-tests
...
Added tests for JsonLD class
2020-06-07 10:23:12 -04:00
Michael Vogel
3e2ebcb1c7
Merge pull request #8741 from MrPetovan/task/hook-probe-detect
...
Add probe_detect hook
2020-06-06 23:06:51 +02:00
Michael
c38452d16e
Avoiding unwanted side effects
2020-06-06 19:29:37 +00:00
Hypolite Petovan
5cb3a5ff74
Remove obsolete Twitter probing
...
- Profile page source offers no details about accounts when not logged in
2020-06-06 15:08:21 -04:00
Hypolite Petovan
6bed6d5587
Add probe_detect hook
2020-06-06 14:54:04 -04:00
Michael
d68372c872
Issue 8732: Fix fetch aved searches
2020-06-06 18:45:16 +00:00
Michael
bc4e5b4d69
Issue 8735: Ensure the correct data type for "hide"
2020-06-06 08:11:19 +00:00
Hypolite Petovan
1304e14572
Exit with an error if profile info isn't available in Module\NoScrape
2020-06-05 14:28:11 -04:00
Michael
7374104f29
Fix Notice "Undefined index: subscribe"
2020-06-05 10:44:36 +00:00
Michael
7b70eefbb6
Remove the "addr" when webfinger fails
2020-06-04 22:08:31 +00:00
Michael
62217735f0
Use webfinger in apcontact fetch
2020-06-04 21:55:14 +00:00
Hypolite Petovan
e0152bec7d
Remove Twitter exception for shared blocks in Text\BBCode::convertShareCallback
...
- Twitter stopped supporting OEmbed which defaulted to an undesirable fallback
2020-06-04 11:13:31 -04:00
Hypolite Petovan
f68652d61c
Revert "Move share content conversion before link handling in Text\BBCode::convert"
...
This reverts commit 010ec99b35
.
2020-06-04 11:11:44 -04:00
Hypolite Petovan
010ec99b35
Move share content conversion before link handling in Text\BBCode::convert
2020-06-03 22:02:01 -04:00
Michael
ad2f45d1d8
Fix fatal errors because of mixed data types
2020-06-03 06:57:51 +00:00
Michael Vogel
5630c9f132
Merge pull request #8719 from MrPetovan/task/8717-help-console-globalcommunitysilence
...
Improve language of console globalcommunitysilence help line
2020-06-03 06:14:56 +02:00
Hypolite Petovan
779099a491
Improve language of console globalcommunitysilence help line
2020-06-03 00:03:58 -04:00
Hypolite Petovan
a2de7d25ec
Use expected return variable type in Network\Probe::detect
2020-06-02 23:41:10 -04:00
Michael
50e5bd6703
Let "subscribe" be filled at every time to avoid a notice
2020-06-02 19:11:37 +00:00
Michael
736f69c33a
Changed logging
2020-06-02 06:47:44 +00:00
Michael
e379698227
Issue 8675: reduce requests of foreign pages
2020-06-01 21:52:31 +00:00
Michael
e374e5752a
Changed deprecated log calls
2020-06-01 13:51:58 +00:00
Michael
7ac4a08e1b
Additional "is null" check in post update / create the "vid" if needed
2020-05-31 15:48:31 +00:00
Michael
46e2423af9
Fix wrong variable names
2020-05-30 17:06:59 +00:00
Michael
2eb371dcaf
Fix foreign key constraint with "post-tag" table
2020-05-30 16:36:09 +00:00
Michael
9328eee550
Missing gravity
2020-05-29 22:19:59 +00:00
Michael
b837c487c5
Fix "gravity" notice
2020-05-29 21:41:10 +00:00
Michael Vogel
235f4eaa89
Merge pull request #8697 from MrPetovan/task/8691-like-links-one-way
...
Make like links one way
2020-05-29 15:33:24 +02:00
Hypolite Petovan
f0b6f025d2
Appease VSCode inferior static analysis in Model\Item
2020-05-29 09:01:37 -04:00
Hypolite Petovan
0efd3dedeb
Merge pull request #8705 from annando/thread-uri-id
...
Add "uri-id" to the "thread" table
2020-05-28 23:59:44 -04:00
Michael Vogel
c6aa42dd4e
Merge pull request #8696 from MrPetovan/bug/8694-event-network-unkn
...
Assign default protocol to new events
2020-05-29 05:05:35 +02:00
Michael
3258216e8d
Add "uri-id" to the "thread" table
2020-05-28 21:44:55 +00:00
Michael
0acb5d4558
"parent = id" is replaced with gravity check
2020-05-28 16:02:36 +00:00
Michael
db907c2ff8
Issue 8700: Resolvable activities
2020-05-27 19:05:33 +00:00
Hypolite Petovan
df1c74bd33
Make "like" links one way
...
- Updated dolike() function to accept a "un-" switch
- [frio] Updated doLikeAction() function to call dolike() instead of having duplicated code
- Added boolean logic (with explanatory truth table) to smartly delete existing activities in Model\Item::performActivity
- Moved verb/activity parameter handling closer to their use in Model\Item::performActivity
- Updated all references to dolike() and doLikeAction() to include the "un-" switch
2020-05-27 08:41:13 -04:00
Hypolite Petovan
e20d5ff0b5
Fix the event feature disabling logic in Object\Post
...
- Conditions on item network and dislike feature presence were mixed which could have led to unexpected behaviors
2020-05-27 08:41:12 -04:00
Hypolite Petovan
2d217129b9
Improve performance of asynchronous like/update
...
- Make the like module return earlier instead of outputting a full empty HTML page
- Update the force_update variable earlier to prevent spilling on multiple unrelated nav update calls
2020-05-27 08:41:10 -04:00
Hypolite Petovan
05c3d02854
Assign default protocol to new events
...
- This restores event interactions on the items
2020-05-27 08:23:15 -04:00
Michael
973abb6196
Replace "id = parent" checks with "gravity" checks
2020-05-27 12:19:06 +00:00
Michael
465e1890b5
Fix notice because of missing array item
2020-05-27 03:19:17 +00:00
Michael
4d23de997a
Updated postupdate function
2020-05-26 21:45:57 +00:00
Michael
ba9cf32f36
The "item-activity" is removed
2020-05-26 05:18:50 +00:00
Michael
327cdf21ce
Some more "baseurl" improvements
2020-05-24 20:40:00 +00:00
Hypolite Petovan
669124e72f
Merge pull request #8678 from annando/gserver-detection-type
...
Improved server detection / gsid introduced
2020-05-22 10:25:37 -04:00
Michael
21ab11ac18
Only fetch the gsid when it had been empty before
2020-05-22 11:29:58 +00:00
Michael
e27915a819
Centralized gsid generation
2020-05-22 10:10:24 +00:00
Michael
071505f024
Added documentation, simplified code
2020-05-22 04:52:43 +00:00
Michael
95b4f35a12
Improved server detection / gsid introduced
2020-05-22 04:19:32 +00:00
Michael Vogel
58f06a830f
Merge pull request #8671 from MrPetovan/bug/8623-relative-href
...
Add support for relative URL in HTML documents
2020-05-21 13:51:26 +02:00
Hypolite Petovan
04e8d5be2c
Remove deprecated/implicit filter_var() flags in Network\Probe::ensureAbsoluteLinkFromHTMLDoc
...
- Suppresses a test breaking notice message in PHP 7.4
2020-05-21 02:27:33 -04:00
Hypolite Petovan
3ef987e4e1
Add new Network\Probe::ensureAbsoluteLinkFromHTMLDoc method
...
- Add supports for relative URL in href attributes to probe feed URL
2020-05-21 00:25:48 -04:00
Hypolite Petovan
c2105f93d1
Remove duplicate curl call in Network\Probe::getFeedLink
...
- Add page body argument instead
- Expand method scope to allow tests
2020-05-21 00:25:48 -04:00
Hypolite Petovan
6fd13300cb
Fix wrong variable name in Model\Attach
...
- Prevented attachment data from being retrieved from storage
2020-05-20 18:28:14 -04:00
Michael
a77c0194dc
Issue 8663: Prevent abusive behaviour when probing servers
2020-05-20 06:57:46 +00:00
Michael Vogel
b7b6fae389
Update src/Model/Verb.php
...
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2020-05-19 22:42:01 +02:00
Michael
eeda115e32
Adding some more verb handling
2020-05-19 20:32:15 +00:00
Michael
ef3dc72dca
Ensure unified order of 'verb' records
2020-05-19 05:51:58 +00:00
Hypolite Petovan
3cc3bfe531
Merge pull request #8660 from annando/item-insert
...
Improved item insert functionality
2020-05-18 19:35:26 -04:00
Michael
e09965fcc5
Simplified code
2020-05-18 22:34:47 +00:00
Michael Vogel
e315bc3eae
Merge pull request #8657 from MrPetovan/bug/8653-catch-template-engine-errors
...
Catch template engine errors
2020-05-19 00:22:45 +02:00
Hypolite Petovan
8b05af176c
Add detailed error messages for admin user in Core\Renderer and Render\FriendicaSmartyEngine
2020-05-18 18:10:21 -04:00
Michael
2a56370cf4
Merge remote-tracking branch 'upstream/develop' into annando/issue8514
2020-05-18 21:38:17 +00:00
Michael
2f8c6f00b5
Improved item insert functionality
2020-05-18 21:34:57 +00:00
Hypolite Petovan
64e89a516d
Restore default parameter value in Core\Renderer::replaceMacros
2020-05-18 10:01:51 -04:00
Hypolite Petovan
ef9b51e631
Replace direct error output and exit by logger + exception in Core\Renderer
...
- Same in Render\FriendicaSmartyEngine
2020-05-18 01:21:58 -04:00
Hypolite Petovan
346f99b877
Add new TemplateEngine->testInstall method
...
- Add admin summary template engine error messages
2020-05-18 01:20:47 -04:00
Hypolite Petovan
c6ba92c43d
Refactor template engine code
...
- Convert ITemplateEngine interface to abstract class
- Remove dependency to App in FriendicaSmarty and FriendicaSmartyEngine
- Normalize replaceMacro parameter behavior using Smarty template string prefixes
- Remove obsolete FriendicaSmarty->parsed method
- Update unused Smarty directory paths
2020-05-18 01:18:41 -04:00
Hypolite Petovan
75a0b80888
Add new Strings::startsWith method
...
- Move previous method to Strings::startsWithChars and update every known call
2020-05-18 01:05:38 -04:00
Michael
efb1c630fd
Fix warnings ("Divide by zero" and "key parameter is not a valid public key")
2020-05-18 02:58:08 +00:00
Michael
e737eea17d
Issue 8458-2: Now all unicode emojis should work
2020-05-17 21:46:54 +00:00
Michael
d7f0ffdbc1
Issue 8458: Display big emojis
...
Fixes #8458
2020-05-17 16:55:54 +00:00
Hypolite Petovan
db63d1d501
Merge pull request #8652 from annando/annando/issue8582
...
Issue 8582: "cid" in "network" is now "contactid"
2020-05-17 11:41:53 -04:00
Hypolite Petovan
8a96fe6d7f
Merge pull request #8648 from annando/annando/issue8565
...
Issue 8565: Sanitize input data
2020-05-17 11:40:18 -04:00
Michael
3b1d89252a
Issue 8582: "cid" in "network" is now "contactid"
...
Fixes #8582
2020-05-17 15:01:27 +00:00
Michael
bc26c980f0
Reverts test changes
2020-05-17 13:59:05 +00:00
Michael
a3c4021f12
Issue 8514: Make paging for searcg items work again
...
Fixes #8514
2020-05-17 13:51:56 +00:00
Hypolite Petovan
90b1355555
Merge pull request #8649 from annando/annando/issue8550
...
Issue 8550: New experimental database configurations
2020-05-17 09:11:30 -04:00
Michael
7ace1049bb
Issue 8572: Ensure to log database errors
2020-05-17 10:56:19 +00:00
Michael
4d4678ceb6
New experimental database configurations
2020-05-17 09:03:56 +00:00
Michael
d771c50d63
Issue 8565: Sanitize input data
...
Fixes #8565
2020-05-17 06:13:58 +00:00
Michael
ecde6b0066
Issue 8635: Create foreign keys without constraint name
2020-05-16 20:57:04 +00:00
Michael
b625797591
issue 8642: Make hashtags more compatible
2020-05-16 18:38:50 +00:00
Hypolite Petovan
013d75c2ec
Merge pull request #8644 from annando/bbcode-constants
...
Use constants for the BBCode modes
2020-05-16 13:15:24 -04:00
Michael
b192810288
Still more missing places replaced
2020-05-16 16:41:37 +00:00
Michael
76d845a138
Found another occurence replaced with constants
2020-05-16 16:39:44 +00:00
Michael
0da0580a82
use "self"
2020-05-16 16:32:37 +00:00
Michael
0cf517ad76
Use constants for the BBCode modes
2020-05-16 16:28:15 +00:00
Michael
b8cf415f0d
Issue 8635 - Handle weird default values
...
This handles an issue that occured in #8635 (But will not fix the issue behind this)
2020-05-16 14:23:17 +00:00
Michael
28e7564d79
Added some more sql commands to the list
2020-05-16 10:21:16 +00:00
Michael
8e12edc375
Improved code
2020-05-16 10:04:09 +00:00
Michael
4faef126ff
Improved structure
2020-05-16 09:01:54 +00:00
Michael
4e1b1c0811
Issue 8635: Avoid concurrent database updates
...
Possibly helps with #8635
2020-05-16 08:15:51 +00:00
Michael
28e52f4db1
Fixed table name
2020-05-16 06:14:25 +00:00