From 6a857b00db8e8dfa4be81f33110996c0fb5bbfc5 Mon Sep 17 00:00:00 2001
From: Professr <github@professr.net>
Date: Mon, 22 Jun 2020 14:06:02 -0700
Subject: [PATCH] Add cpp clamp function to util.h, switched battery and signal
 strength percentage calcs to it #197

---
 src/esp32/main-esp32.cpp | 4 ++--
 src/screen.cpp           | 3 ++-
 src/utils.h              | 7 +++++++
 3 files changed, 11 insertions(+), 3 deletions(-)
 create mode 100644 src/utils.h

diff --git a/src/esp32/main-esp32.cpp b/src/esp32/main-esp32.cpp
index 8b08118c..e0d53eab 100644
--- a/src/esp32/main-esp32.cpp
+++ b/src/esp32/main-esp32.cpp
@@ -5,6 +5,7 @@
 #include "main.h"
 #include "power.h"
 #include "sleep.h"
+#include "utils.h"
 #include "target_specific.h"
 
 bool bluetoothOn;
@@ -81,8 +82,7 @@ void readPowerStatus()
         } else {
             // If the AXP192 returns a percentage less than 0, the feature is either not supported or there is an error
             // In that case, we compute an estimate of the charge percent based on maximum and minimum voltages defined in power.h
-            int calculatedPercentage = ((powerStatus.batteryVoltageMv - BAT_MILLIVOLTS_EMPTY) * 1e2) / (BAT_MILLIVOLTS_FULL - BAT_MILLIVOLTS_EMPTY);
-            powerStatus.batteryChargePercent = (calculatedPercentage < 0) ? 0 : (calculatedPercentage > 100) ? 100 : calculatedPercentage;
+            powerStatus.batteryChargePercent = clamp((int)(((powerStatus.batteryVoltageMv - BAT_MILLIVOLTS_EMPTY) * 1e2) / (BAT_MILLIVOLTS_FULL - BAT_MILLIVOLTS_EMPTY)), 0, 100);
         }
         DEBUG_MSG("Battery %dmV %d%%\n", powerStatus.batteryVoltageMv, powerStatus.batteryChargePercent);
     }
diff --git a/src/screen.cpp b/src/screen.cpp
index 9d43eda8..707d52c1 100644
--- a/src/screen.cpp
+++ b/src/screen.cpp
@@ -31,6 +31,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #include "main.h"
 #include "mesh-pb-constants.h"
 #include "screen.h"
+#include "utils.h"
 
 #define FONT_HEIGHT 14 // actually 13 for "ariel 10" but want a little extra space
 #define FONT_HEIGHT_16 (ArialMT_Plain_16[1] + 1)
@@ -379,7 +380,7 @@ static void drawNodeInfo(OLEDDisplay *display, OLEDDisplayUiState *state, int16_
     const char *username = node->has_user ? node->user.long_name : "Unknown Name";
 
     static char signalStr[20];
-    snprintf(signalStr, sizeof(signalStr), "Signal: %.0f", node->snr);
+    snprintf(signalStr, sizeof(signalStr), "Signal: %d%%", clamp((int)((node->snr + 10) * 5), 0, 100));
 
     uint32_t agoSecs = sinceLastSeen(node);
     static char lastStr[20];
diff --git a/src/utils.h b/src/utils.h
new file mode 100644
index 00000000..36f719ca
--- /dev/null
+++ b/src/utils.h
@@ -0,0 +1,7 @@
+#pragma once
+
+/// C++ v17+ clamp function, limits a given value to a range defined by lo and hi
+template<class T>
+constexpr const T& clamp( const T& v, const T& lo, const T& hi ) {
+    return (v < lo) ? lo : (hi < v) ? hi : v;
+}
\ No newline at end of file