From 1908d131cad091bf71c321259da56503627b7013 Mon Sep 17 00:00:00 2001 From: Kevin Hester Date: Fri, 12 Mar 2021 20:22:40 +0800 Subject: [PATCH] turn on access control for admin plugin, only allow remote access over special channel --- src/mesh/MeshPlugin.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesh/MeshPlugin.cpp b/src/mesh/MeshPlugin.cpp index 361cad26..99bf7643 100644 --- a/src/mesh/MeshPlugin.cpp +++ b/src/mesh/MeshPlugin.cpp @@ -53,7 +53,7 @@ void MeshPlugin::callPlugins(const MeshPacket &mp) assert(ch.has_settings); /// Is the channel this packet arrived on acceptable? (security check) - bool rxChannelOk = true || !pi.boundChannel || (mp.from == 0) || (strcmp(ch.settings.name, pi.boundChannel) == 0); + bool rxChannelOk = !pi.boundChannel || (mp.from == 0) || (strcmp(ch.settings.name, pi.boundChannel) == 0); /// We only call plugins that are interested in the packet (and the message is destined to us or we are promiscious) bool wantsPacket = rxChannelOk && (pi.isPromiscuous || toUs) && pi.wantPacket(&mp);