From f4e28918571351c13a72959c2c31cb9dda8a3eab Mon Sep 17 00:00:00 2001 From: Thibaud Colas Date: Thu, 23 May 2019 17:40:37 +0100 Subject: [PATCH] Remove all existing outline overrides in admin UI --- client/scss/components/_button.scss | 2 -- client/scss/components/_forms.scss | 6 ------ client/scss/components/_main-nav.scss | 2 -- client/scss/components/_modals.scss | 1 - client/scss/components/_streamfield.scss | 2 -- client/scss/components/_tabs.scss | 1 - client/scss/elements/_forms.scss | 2 -- client/scss/elements/_typography.scss | 1 - client/src/components/Draftail/blocks/MediaBlock.scss | 4 ---- client/src/components/Explorer/Explorer.scss | 3 --- client/src/components/Explorer/ExplorerItem.scss | 2 -- .../modeladmin/static_src/wagtailmodeladmin/scss/index.scss | 1 - 12 files changed, 27 deletions(-) diff --git a/client/scss/components/_button.scss b/client/scss/components/_button.scss index b7f8a3f04d..66a9f6978e 100644 --- a/client/scss/components/_button.scss +++ b/client/scss/components/_button.scss @@ -22,7 +22,6 @@ white-space: nowrap; position: relative; overflow: hidden; - outline: none; box-sizing: border-box; -webkit-font-smoothing: auto; // stylelint-disable-next-line property-no-vendor-prefix @@ -163,7 +162,6 @@ white-space: nowrap; position: relative; overflow: hidden; - outline: none; box-sizing: border-box; -webkit-font-smoothing: auto; // stylelint-disable-next-line property-no-vendor-prefix diff --git a/client/scss/components/_forms.scss b/client/scss/components/_forms.scss index 166f1e3eaf..60ab2cbca1 100644 --- a/client/scss/components/_forms.scss +++ b/client/scss/components/_forms.scss @@ -51,7 +51,6 @@ // color: $color-text-input; // font-size: 1.2em; // font-weight: 300; -// outline: none; // // &:hover { // background-color: $color-white; @@ -60,7 +59,6 @@ // &:focus { // background-color: $color-input-focus; // border-color: $color-input-focus-border; -// outline: none; // } // // &:disabled, @@ -84,10 +82,6 @@ select::-ms-expand { .typed_choice_field .input { position: relative; - select { - outline: none; - } - // Add select arrow back on browsers where native ui has been removed select ~ span:after { border-radius: 0 6px 6px 0; diff --git a/client/scss/components/_main-nav.scss b/client/scss/components/_main-nav.scss index a699d10934..008609ea13 100644 --- a/client/scss/components/_main-nav.scss +++ b/client/scss/components/_main-nav.scss @@ -62,7 +62,6 @@ // making the text semi-transparent &:hover, &:focus { - outline: none; background-color: $nav-item-hover-bg; color: $color-white; text-shadow: -1px -1px 0 rgba(0, 0, 0, 0.3); @@ -333,7 +332,6 @@ body.explorer-open { cursor: pointer; &:hover { - outline: none; background-color: rgba(100, 100, 100, 0.15); color: $color-white; text-shadow: -1px -1px 0 rgba(0, 0, 0, 0.3); diff --git a/client/scss/components/_modals.scss b/client/scss/components/_modals.scss index 462350fc34..d4e43886cc 100644 --- a/client/scss/components/_modals.scss +++ b/client/scss/components/_modals.scss @@ -58,7 +58,6 @@ $zindex-modal-background: 500; width: 98.7%; position: relative; background-color: $color-white; - outline: none; margin-top: 2em; padding-bottom: 3em; display: inline-block; diff --git a/client/scss/components/_streamfield.scss b/client/scss/components/_streamfield.scss index 917cee33c6..2e702e8cc7 100644 --- a/client/scss/components/_streamfield.scss +++ b/client/scss/components/_streamfield.scss @@ -252,7 +252,6 @@ li.sequence-member { z-index: 1; color: $color-grey-1; background-color: $color-white; - outline: none; span { @include visuallyhidden(); @@ -305,7 +304,6 @@ li.sequence-member { display: block; width: 100%; padding: 0 0 0.5em; - outline: $color-teal; overflow: visible; span { diff --git a/client/scss/components/_tabs.scss b/client/scss/components/_tabs.scss index bf32b9891b..b607cdfa89 100644 --- a/client/scss/components/_tabs.scss +++ b/client/scss/components/_tabs.scss @@ -19,7 +19,6 @@ a { @include transition(border-color 0.2s ease); background-color: $color-teal-darker; - outline: none; text-transform: uppercase; font-weight: 700; font-size: 1.2em; diff --git a/client/scss/elements/_forms.scss b/client/scss/elements/_forms.scss index e761bdab24..bf683f9ae2 100644 --- a/client/scss/elements/_forms.scss +++ b/client/scss/elements/_forms.scss @@ -80,7 +80,6 @@ select, color: $color-text-input; font-size: 1.2em; font-weight: 300; - outline: none; &:hover { background-color: $color-white; @@ -89,7 +88,6 @@ select, &:focus { background-color: $color-input-focus; border-color: $color-input-focus-border; - outline: none; } &:disabled, diff --git a/client/scss/elements/_typography.scss b/client/scss/elements/_typography.scss index 5d5b37f9fb..ba4574f0ed 100644 --- a/client/scss/elements/_typography.scss +++ b/client/scss/elements/_typography.scss @@ -49,7 +49,6 @@ p { a { // @include transition(color 0.2s ease, background-color 0.2s ease); - outline: none; color: $color-link; text-decoration: none; diff --git a/client/src/components/Draftail/blocks/MediaBlock.scss b/client/src/components/Draftail/blocks/MediaBlock.scss index e62947be79..440d3535ab 100644 --- a/client/src/components/Draftail/blocks/MediaBlock.scss +++ b/client/src/components/Draftail/blocks/MediaBlock.scss @@ -5,10 +5,6 @@ padding: 0; cursor: pointer; - &:focus { - outline: none; - } - &__icon-wrapper { position: absolute; top: 0; diff --git a/client/src/components/Explorer/Explorer.scss b/client/src/components/Explorer/Explorer.scss index 49e6b05d41..a97ad482bd 100644 --- a/client/src/components/Explorer/Explorer.scss +++ b/client/src/components/Explorer/Explorer.scss @@ -58,7 +58,6 @@ $menu-footer-height: 50px; &:focus { background-color: $c-explorer-bg-active; color: $color-white; - outline: none; } // Overrides for default link hover. @@ -88,7 +87,6 @@ $menu-footer-height: 50px; &:focus { background-color: $c-explorer-bg-active; color: $color-white; - outline: none; } // Overrides for default link hover. @@ -136,7 +134,6 @@ $menu-footer-height: 50px; &:focus { color: $c-explorer-secondary; background: $c-explorer-bg-active; - outline: none; } // Overrides for default link hover. diff --git a/client/src/components/Explorer/ExplorerItem.scss b/client/src/components/Explorer/ExplorerItem.scss index 63ffd39bf1..30b1419137 100644 --- a/client/src/components/Explorer/ExplorerItem.scss +++ b/client/src/components/Explorer/ExplorerItem.scss @@ -14,7 +14,6 @@ &:focus { background: $c-explorer-bg-active; color: $color-white; - outline: none; } // Overrides for default link hover. @@ -60,7 +59,6 @@ &:focus { background: $c-explorer-bg-active; color: $color-white; - outline: none; } // Overrides for default link hover. diff --git a/wagtail/contrib/modeladmin/static_src/wagtailmodeladmin/scss/index.scss b/wagtail/contrib/modeladmin/static_src/wagtailmodeladmin/scss/index.scss index e6e4767dd1..afd812031c 100644 --- a/wagtail/contrib/modeladmin/static_src/wagtailmodeladmin/scss/index.scss +++ b/wagtail/contrib/modeladmin/static_src/wagtailmodeladmin/scss/index.scss @@ -84,7 +84,6 @@ text-transform: uppercase; position: relative; overflow: hidden; - outline: none; box-sizing: border-box; -webkit-font-smoothing: auto; // stylelint-disable-next-line property-no-vendor-prefix