Add a "Dashboard" label for logo link in the main nav for screen reader users (#5349)

* Use the correct link label for Dashboard link in main nav
* Remove dashboard link title with Wagtail version number
pull/5314/head^2
Thibaud Colas 2019-06-04 21:51:18 +01:00 zatwierdzone przez GitHub
rodzic 8d10c4688e
commit e191582b94
Nie znaleziono w bazie danych klucza dla tego podpisu
ID klucza GPG: 4AEE18F83AFDEB23
4 zmienionych plików z 6 dodań i 2 usunięć

Wyświetl plik

@ -20,5 +20,5 @@ Any other relevant information. For example, why do you consider this a bug and
* Python version: Run `python --version`.
* Django version: Look in your requirements.txt, or run `pip show django | grep Version`.
* Wagtail version: Hover over the Wagtail bird in the admin, or run `pip show wagtail | grep Version:`.
* Wagtail version: Look at the bottom of the Settings menu in the Wagtail admin, or run `pip show wagtail | grep Version:`.
* Browser version: You can use http://www.whatsmybrowser.org/ to find this out.

Wyświetl plik

@ -18,6 +18,7 @@ Changelog
* Increase font-size across the whole admin (Beth Menzies, Katie Locke)
* Improved text color contrast across the whole admin (Beth Menzies, Katie Locke)
* Added consistent focus outline styles across the whole admin (Thibaud Colas)
* Removed version number from the logo links title. The version can now be found under the Settings menu (Thibaud Colas)
* Fix: ModelAdmin no longer fails when filtering over a foreign key relation (Jason Dilworth, Matt Westcott)
* Fix: The Wagtail version number is now visible within the Settings menu (Kevin Howbrook)
* Fix: Scaling images now rounds values to an integer so that images render without errors (Adrian Brunyate)
@ -33,6 +34,7 @@ Changelog
* Fix: Make URL generator preview image alt translateable (Thibaud Colas)
* Fix: Clear pending AJAX request if error occurs on page chooser (Matt Westcott)
* Fix: Prevent text from overlapping in focal point editing UI (Beth Menzies)
* Fix: Screen readers now announce "Dashboard" for the main navs logo link instead of Wagtails version number (Thibaud Colas)
2.5.1 (07.05.2019)

Wyświetl plik

@ -27,6 +27,7 @@ Other features
* Increase font-size across the whole admin (Beth Menzies, Katie Locke)
* Improved text color contrast across the whole admin (Beth Menzies, Katie Locke)
* Added consistent focus outline styles across the whole admin (Thibaud Colas)
* Removed version number from the logo links title. The version can now be found under the Settings menu (Thibaud Colas)
Bug fixes
~~~~~~~~~
@ -46,6 +47,7 @@ Bug fixes
* Make URL generator preview image alt translateable (Thibaud Colas)
* Clear pending AJAX request if error occurs on page chooser (Matt Westcott)
* Prevent text from overlapping in focal point editing UI (Beth Menzies)
* Screen readers now announce "Dashboard" for the main navs logo link instead of Wagtails version number (Thibaud Colas)
Upgrade considerations

Wyświetl plik

@ -4,7 +4,7 @@
{% block furniture %}
<aside class="nav-wrapper">
<div class="inner">
<a href="{% url 'wagtailadmin_home' %}" class="logo" title="Wagtail v.{% wagtail_version %}">
<a href="{% url 'wagtailadmin_home' %}" class="logo" aria-label="{% trans 'Dashboard' %}">
{% block branding_logo %}
{# Mobile-only logo: #}
<div class="wagtail-logo-container__mobile u-hidden@sm">