rename BaseChooser.render_html to render_hidden_input

wagtail/admin/widgets/chooser.py

@@ -123,10 +123,13 @@ class BaseChooser(widgets.Input):
         else:
             return result
 
-    def render_html(self, name, value, attrs):
-        """Render the HTML (non-JS) portion of the field markup"""
+    def render_hidden_input(self, name, value, attrs):
+        """Render the HTML for the underlying hidden input element"""
         return super().render(name, value, attrs)
 
+    def render_html(self, name, value, attrs):
+        raise NotImplementedError
+
     def get_value_data(self, value):
         # Perform any necessary preprocessing on the value passed to render() before it is passed
         # on to render_html / render_js_init. This is a good place to perform database lookups
@@ -238,7 +241,9 @@ class AdminPageChooser(BaseChooser):
 
     def render_html(self, name, value_data, attrs):
         value_data = value_data or {}
-        original_field_html = super().render_html(name, value_data.get("id"), attrs)
+        original_field_html = self.render_hidden_input(
+            name, value_data.get("id"), attrs
+        )
 
         return render_to_string(
             "wagtailadmin/widgets/chooser.html",

wagtail/admin/widgets/workflows.py

@@ -35,7 +35,9 @@ class AdminTaskChooser(BaseChooser):
 
     def render_html(self, name, value_data, attrs):
         value_data = value_data or {}
-        original_field_html = super().render_html(name, value_data.get("id"), attrs)
+        original_field_html = self.render_hidden_input(
+            name, value_data.get("id"), attrs
+        )
 
         return render_to_string(
             "wagtailadmin/workflows/widgets/task_chooser.html",

wagtail/documents/widgets.py

@@ -41,7 +41,9 @@ class AdminDocumentChooser(BaseChooser):
 
     def render_html(self, name, value_data, attrs):
         value_data = value_data or {}
-        original_field_html = super().render_html(name, value_data.get("id"), attrs)
+        original_field_html = self.render_hidden_input(
+            name, value_data.get("id"), attrs
+        )
 
         return render_to_string(
             "wagtailadmin/widgets/chooser.html",

wagtail/images/widgets.py

@@ -48,7 +48,9 @@ class AdminImageChooser(BaseChooser):
 
     def render_html(self, name, value_data, attrs):
         value_data = value_data or {}
-        original_field_html = super().render_html(name, value_data.get("id"), attrs)
+        original_field_html = self.render_hidden_input(
+            name, value_data.get("id"), attrs
+        )
 
         return render_to_string(
             "wagtailimages/widgets/image_chooser.html",

wagtail/snippets/widgets.py

@@ -43,7 +43,9 @@ class AdminSnippetChooser(BaseChooser):
     def render_html(self, name, value_data, attrs):
         value_data = value_data or {}
 
-        original_field_html = super().render_html(name, value_data.get("id"), attrs)
+        original_field_html = self.render_hidden_input(
+            name, value_data.get("id"), attrs
+        )
         chooser_url = reverse(
             "wagtailsnippets:choose",
             args=[