From db1305f94c60de7f3ab7107e2c3fd4317ba5b29b Mon Sep 17 00:00:00 2001 From: Matt Westcott Date: Mon, 12 Apr 2021 18:41:43 +0100 Subject: [PATCH] Fix API tests with an empty order_by clause This works around a Django bug apparently introduced in https://github.com/django/django/commit/779e615e362108862f1681f965ee9e4f1d0ae6d2 --- wagtail/api/v2/tests/test_pages.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/wagtail/api/v2/tests/test_pages.py b/wagtail/api/v2/tests/test_pages.py index 4abc20ffda..fbd1f1a30f 100644 --- a/wagtail/api/v2/tests/test_pages.py +++ b/wagtail/api/v2/tests/test_pages.py @@ -86,7 +86,7 @@ class TestPageListing(TestCase): missing_page_content_type = ContentType.objects.create(app_label='tests', model='missingpage') # Turn a BlogEntryPage into this content_type - models.BlogEntryPage.objects.filter(id=16).update(content_type=missing_page_content_type) + models.BlogEntryPage.objects.filter(id=16).order_by().update(content_type=missing_page_content_type) # get page listing with missing model response = self.get_response() @@ -985,7 +985,7 @@ class TestPageDetail(TestCase): self.assertEqual(list(content['meta'].keys()), meta_field_order) def test_null_foreign_key(self): - models.BlogEntryPage.objects.filter(id=16).update(feed_image_id=None) + models.BlogEntryPage.objects.filter(id=16).order_by().update(feed_image_id=None) response = self.get_response(16) content = json.loads(response.content.decode('UTF-8')) @@ -998,7 +998,7 @@ class TestPageDetail(TestCase): missing_page_content_type = ContentType.objects.create(app_label='tests', model='missingpage') # Turn a BlogEntryPage into this content_type - models.BlogEntryPage.objects.filter(id=16).update(content_type=missing_page_content_type) + models.BlogEntryPage.objects.filter(id=16).order_by().update(content_type=missing_page_content_type) # get missing model page response = self.get_response(16)