Update privacy collection switch button

- The status tag styles did not actually change when the permissions changed
- Instead of trying to treat the status tag as a button, use an actual button styling as this pattern is not used anywhere else in Wagtail
- Fixes #10128

CHANGELOG.txt

@@ -23,6 +23,7 @@ Changelog
  * Fix: No longer allow invalid duplicate site hostname creation as hostnames and domain names are a case insensitive (Coen van der Kamp)
  * Fix: Image and Document multiple upload update forms now correctly use the progress button (longrunning) behaviour when clicked (Loveth Omokaro)
  * Fix: Prevent audit log report from failing on missing models (Andy Chosak)
+ * Fix: Ensure that the privacy collection privacy edit button is styled as a button (Jatin Kumar)
  * Docs: Add code block to make it easier to understand contribution docs (Suyash Singh)
  * Docs: Add new "Icons" page for icons customisation and reuse across the admin interface (Coen van der Kamp)
  * Docs: Fix broken formatting for MultiFieldPanel / FieldRowPanel permission kwarg docs (Matt Westcott)

CONTRIBUTORS.rst

@@ -695,6 +695,7 @@ Contributors
 * Kenny Wolf
 * Himanshu Garg
 * Christopher Wardle
+* Jatin Kumar
 
 Translators
 ===========

docs/releases/5.0.md

@@ -36,6 +36,7 @@ depth: 1
  * No longer allow invalid duplicate site hostname creation as hostnames and domain names are a case insensitive (Coen van der Kamp)
  * Image and Document multiple upload update forms now correctly use the progress button (longrunning) behaviour when clicked (Loveth Omokaro)
  * Prevent audit log report from failing on missing models (Andy Chosak)
+ * Ensure that the privacy collection privacy edit button is styled as a button (Jatin Kumar)
 
 ### Documentation
 

wagtail/admin/templates/wagtailadmin/collections/_privacy_switch.html

@@ -11,7 +11,7 @@
 
     <div class="privacy-indicator {% if is_public %}public{% else %}private{% endif %}">
         {% trans "Privacy" %}
-        <button type="button" data-a11y-dialog-show="set-privacy" class="status-tag primary">
+        <button type="button" data-a11y-dialog-show="set-privacy" class="button button-small button-secondary">
             {# labels are shown/hidden in CSS according to the 'private' / 'public' class on view-permission-indicator #}
             <span class="label-public icon icon-view" aria-label="{% trans 'Set collection privacy. Current status: Public' %}">
                 {% trans "Public" %}