From a26c0bcfa0c3d4994dc72ea206a34c029cbbd185 Mon Sep 17 00:00:00 2001
From: Karl Hobley <karl@torchbox.com>
Date: Tue, 10 Jun 2014 15:39:28 +0100
Subject: [PATCH] Revert "Cleanup Filter.process_image a bit"

This reverts commit b5586102ed5ae4bb3f56c33f2dc9de56628fdd2b.
---
 wagtail/wagtailimages/models.py | 37 +++++++++++++++++----------------
 1 file changed, 19 insertions(+), 18 deletions(-)

diff --git a/wagtail/wagtailimages/models.py b/wagtail/wagtailimages/models.py
index ddde18d295..a2be29486e 100644
--- a/wagtail/wagtailimages/models.py
+++ b/wagtail/wagtailimages/models.py
@@ -161,17 +161,15 @@ class Filter(models.Model):
         # and save the results to self.method_name and self.method_arg
         try:
             (method_name_simple, method_arg_string) = self.spec.split('-')
-            method_name = Filter.OPERATION_NAMES[method_name_simple]
+            self.method_name = Filter.OPERATION_NAMES[method_name_simple]
 
             if method_name_simple in ('max', 'min', 'fill'):
                 # method_arg_string is in the form 640x480
                 (width, height) = [int(i) for i in method_arg_string.split('x')]
-                method_arg = (width, height)
+                self.method_arg = (width, height)
             else:
                 # method_arg_string is a single number
-                method_arg = int(method_arg_string)
-
-            return method_name, method_arg
+                self.method_arg = int(method_arg_string)
 
         except (ValueError, KeyError):
             raise ValueError("Invalid image filter spec: %r" % self.spec)
@@ -182,33 +180,36 @@ class Filter(models.Model):
         generate an output image with this filter applied, returning it
         as another django.core.files.File object
         """
-        # Get image backend
         backend = get_image_backend(backend_name)
 
-        # Open image file
+        if not self.method:
+            self._parse_spec_string()
+
+        # If file is closed, open it
         input_file.open('rb')
         image = backend.open_image(input_file)
         file_format = image.format
 
-        # Parse filter spec string
-        method_name, method_arg = self._parse_spec_string()
+        method = getattr(backend, self.method_name)
 
-        # Run filter
-        method_f = getattr(backend, method_name)
-        image = method_f(image, method_arg)
+        image = method(image, self.method_arg)
 
-        # Save
         output = StringIO.StringIO()
         backend.save_image(image, output, file_format)
 
-        # Close input file
+        # and then close the input file
         input_file.close()
 
-        # Generate new filename derived from old one, inserting the filter spec string before the extension
-        filename_noext, ext = os.path.splitext(input_file.name)
-        output_filename = '.'.join([filename_noext[:60], self.spec]) + ext
+        # generate new filename derived from old one, inserting the filter spec string before the extension
+        input_filename_parts = os.path.basename(input_file.name).split('.')
+        filename_without_extension = '.'.join(input_filename_parts[:-1])
+        filename_without_extension = filename_without_extension[:60]  # trim filename base so that we're well under 100 chars
+        output_filename_parts = [filename_without_extension, self.spec] + input_filename_parts[-1:]
+        output_filename = '.'.join(output_filename_parts)
 
-        return File(output, name=output_filename)
+        output_file = File(output, name=output_filename)
+
+        return output_file
 
 
 class AbstractRendition(models.Model):