move branding_title to the end of page title

Ensure the title of the Web page first identifies the topic of the page, then shows the group name followed by the name of the parent organisation.
* fixes #9054
* https://www.w3.org/WAI/WCAG21/Techniques/general/G88
* https://www.w3.org/WAI/WCAG21/Understanding/page-titled.html
pull/9093/head
Mehrdad Moradizadeh 2022-08-26 16:44:32 -04:00 zatwierdzone przez LB (Ben Johnston)
rodzic 167a923fb1
commit a0f038af14
8 zmienionych plików z 14 dodań i 12 usunięć

Wyświetl plik

@ -12,6 +12,7 @@ Changelog
* Optimise the performance of the Wagtail userbar to remove duplicated queries, improving page loads when viewing live pages while signed in (Jake Howard)
* Remove legacy `unbutton` styling for buttons (Paarth Agarwal)
* Add button variations to the pattern library (Paarth Agarwal)
* Provide a more accessible page title where the unique information is shown first and the CMS name is shown last (Mehrdad Moradizadeh)
* Fix: Prevent `PageQuerySet.not_public` from returning all pages when no page restrictions exist (Mehrdad Moradizadeh)

Wyświetl plik

@ -4,7 +4,7 @@ describe('Groups', () => {
}, 10000);
it('has the right heading', async () => {
expect(await page.title()).toContain('Wagtail - Editing Editors');
expect(await page.title()).toContain('Editing Editors - Wagtail');
});
it('axe', async () => {

Wyświetl plik

@ -5,7 +5,7 @@ describe('Listing', () => {
it('has the right heading', async () => {
expect(await page.title()).toContain(
'Wagtail - Exploring Welcome to your new Wagtail site!',
'Exploring Welcome to your new Wagtail site! - Wagtail',
);
});

Wyświetl plik

@ -20,6 +20,7 @@ Wagtail 4.1 is designated a Long Term Support (LTS) release. Long Term Support r
* Optimise the performance of the Wagtail userbar to remove duplicated queries, improving page loads when viewing live pages while signed in (Jake Howard)
* Remove legacy `unbutton` styling for buttons (Paarth Agarwal)
* Add button variations to the pattern library (Paarth Agarwal)
* Provide a more accessible page title where the unique information is shown first and the CMS name is shown last (Mehrdad Moradizadeh)
### Bug fixes

Wyświetl plik

@ -5,7 +5,7 @@
<html lang="{{ LANGUAGE_CODE }}" dir="{% if LANGUAGE_BIDI %}rtl{% else %}ltr{% endif %}">
<head>
<meta charset="utf-8" />
<title>{% block branding_title %}Wagtail{% endblock %} - {% block titletag %}{% endblock %}</title>
<title>{% block titletag %}{% endblock %} - {% block branding_title %}Wagtail{% endblock %}</title>
<meta name="description" content="" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<meta name="robots" content="noindex" />

Wyświetl plik

@ -862,7 +862,7 @@ class TestPageEdit(TestCase, WagtailTestUtils):
# We should have an error page because we are unable to
# preview; the page key was not in the session.
self.assertContains(
response, "<title>Wagtail - Preview not available</title>", html=True
response, "<title>Preview not available - Wagtail</title>", html=True
)
self.assertContains(
response,

Wyświetl plik

@ -149,7 +149,7 @@ class TestPreview(TestCase, WagtailTestUtils):
self.assertTemplateUsed(response, "wagtailadmin/generic/preview_error.html")
self.assertContains(
response,
"<title>Wagtail - Preview not available</title>",
"<title>Preview not available - Wagtail</title>",
html=True,
)
self.assertContains(
@ -188,7 +188,7 @@ class TestPreview(TestCase, WagtailTestUtils):
self.assertTemplateUsed(response, "wagtailadmin/generic/preview_error.html")
self.assertContains(
response,
"<title>Wagtail - Preview not available</title>",
"<title>Preview not available - Wagtail</title>",
html=True,
)
self.assertContains(
@ -345,7 +345,7 @@ class TestPreview(TestCase, WagtailTestUtils):
self.assertTemplateUsed(response, "wagtailadmin/generic/preview_error.html")
self.assertContains(
response,
"<title>Wagtail - Preview not available</title>",
"<title>Preview not available - Wagtail</title>",
html=True,
)
self.assertContains(
@ -380,7 +380,7 @@ class TestPreview(TestCase, WagtailTestUtils):
self.assertTemplateUsed(response, "wagtailadmin/generic/preview_error.html")
self.assertContains(
response,
"<title>Wagtail - Preview not available</title>",
"<title>Preview not available - Wagtail</title>",
html=True,
)
self.assertContains(

Wyświetl plik

@ -50,7 +50,7 @@ class TestPreview(TestCase, WagtailTestUtils):
self.assertTemplateUsed(response, "wagtailadmin/generic/preview_error.html")
self.assertContains(
response,
"<title>Wagtail - Preview not available</title>",
"<title>Preview not available - Wagtail</title>",
html=True,
)
self.assertContains(
@ -81,7 +81,7 @@ class TestPreview(TestCase, WagtailTestUtils):
self.assertTemplateUsed(response, "wagtailadmin/generic/preview_error.html")
self.assertContains(
response,
"<title>Wagtail - Preview not available</title>",
"<title>Preview not available - Wagtail</title>",
html=True,
)
self.assertContains(
@ -220,7 +220,7 @@ class TestPreview(TestCase, WagtailTestUtils):
self.assertTemplateUsed(response, "wagtailadmin/generic/preview_error.html")
self.assertContains(
response,
"<title>Wagtail - Preview not available</title>",
"<title>Preview not available - Wagtail</title>",
html=True,
)
self.assertContains(
@ -250,7 +250,7 @@ class TestPreview(TestCase, WagtailTestUtils):
self.assertTemplateUsed(response, "wagtailadmin/generic/preview_error.html")
self.assertContains(
response,
"<title>Wagtail - Preview not available</title>",
"<title>Preview not available - Wagtail</title>",
html=True,
)
self.assertContains(