From 9d6715e3ddaa1179d25527f0928af2b0eb4841c1 Mon Sep 17 00:00:00 2001 From: Robert Rollins Date: Mon, 31 Jul 2023 12:26:02 -0700 Subject: [PATCH] Corrected a typo in {% page_header_buttons %} Fixes #10730 --- CHANGELOG.txt | 1 + docs/releases/5.1.md | 1 + wagtail/admin/templatetags/wagtailadmin_tags.py | 2 +- 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.txt b/CHANGELOG.txt index f91c3a190f..688a6e2cf0 100644 --- a/CHANGELOG.txt +++ b/CHANGELOG.txt @@ -76,6 +76,7 @@ Changelog * Fix: Fix `search_promotions` `0004_copy_queries` migration for long-lived Wagtail instances (Sage Abdullah) * Fix: Guard against `TypeError` in `0088_fix_log_entry_json_timestamps` migration (Sage Abdullah) * Fix: Add migration to replace JSON null values with empty objects in log entries' data (Sage Abdullah) + * Fix: Typo in the `page_header_buttons` template tag when accessing the context's request object (Robert Rollins) * Docs: Document how to add non-ModelAdmin views to a `ModelAdminGroup` (Onno Timmerman) * Docs: Document how to add StructBlock data to a StreamField (Ramon Wenger) * Docs: Update ReadTheDocs settings to v2 to resolve urllib3 issue in linkcheck extension (Thibaud Colas) diff --git a/docs/releases/5.1.md b/docs/releases/5.1.md index 76f22abe9d..6ca4d372d5 100644 --- a/docs/releases/5.1.md +++ b/docs/releases/5.1.md @@ -125,6 +125,7 @@ This feature was developed by Aman Pandey as part of the Google Summer of Code p * Fix `search_promotions` `0004_copy_queries` migration for long-lived Wagtail instances (Sage Abdullah) * Guard against `TypeError` in `0088_fix_log_entry_json_timestamps` migration (Sage Abdullah) * Add migration to replace JSON null values with empty objects in log entries' data (Sage Abdullah) + * Fix typo in the `page_header_buttons` template tag when accessing the context's request object (Robert Rollins) ### Documentation diff --git a/wagtail/admin/templatetags/wagtailadmin_tags.py b/wagtail/admin/templatetags/wagtailadmin_tags.py index f962dfcc93..0a9ae7a172 100644 --- a/wagtail/admin/templatetags/wagtailadmin_tags.py +++ b/wagtail/admin/templatetags/wagtailadmin_tags.py @@ -473,7 +473,7 @@ def page_listing_buttons(context, page, page_perms): "wagtailadmin/pages/listing/_page_header_buttons.html", takes_context=True ) def page_header_buttons(context, page, page_perms): - next_url = context.request.path + next_url = context["request"].path button_hooks = hooks.get_hooks("register_page_header_buttons") buttons = []