Show 'Close Explorer' button on mobile viewports. Fix #5396 (#5773)

* Rework 'Close Explorer' button css so that it does not rely on u-hidden. Fixes issue #5396
* Update tests due to changed css classes on 'close explorer' button
pull/5784/head
Sævar Öfjörð Magnússon 2020-01-23 16:18:15 +00:00 zatwierdzone przez Thibaud Colas
rodzic ef6ace6e98
commit 9b64b39f4b
3 zmienionych plików z 7 dodań i 6 usunięć

Wyświetl plik

@ -58,6 +58,7 @@ $menu-footer-height: 50px;
color: $c-explorer-secondary;
border-bottom: 1px solid rgba(200, 200, 200, 0.1);
cursor: pointer;
display: none;
&:focus {
background-color: $c-explorer-bg-active;

Wyświetl plik

@ -146,7 +146,7 @@ class ExplorerPanel extends React.Component {
onDeactivate: onClose,
}}
>
<Button className="c-explorer__close u-hidden" onClick={onClose}>
<Button className="c-explorer__close" onClick={onClose}>
{STRINGS.CLOSE_EXPLORER}
</Button>
<Transition name={transition} className="c-explorer" component="nav" label={STRINGS.PAGE_EXPLORER}>

Wyświetl plik

@ -17,7 +17,7 @@ exports[`ExplorerPanel general rendering #isError 1`] = `
>
<Button
accessibleLabel={null}
className="c-explorer__close u-hidden"
className="c-explorer__close"
dialogTrigger={false}
href="#"
icon=""
@ -96,7 +96,7 @@ exports[`ExplorerPanel general rendering #isFetching 1`] = `
>
<Button
accessibleLabel={null}
className="c-explorer__close u-hidden"
className="c-explorer__close"
dialogTrigger={false}
href="#"
icon=""
@ -165,7 +165,7 @@ exports[`ExplorerPanel general rendering #items 1`] = `
>
<Button
accessibleLabel={null}
className="c-explorer__close u-hidden"
className="c-explorer__close"
dialogTrigger={false}
href="#"
icon=""
@ -259,7 +259,7 @@ exports[`ExplorerPanel general rendering no children 1`] = `
>
<Button
accessibleLabel={null}
className="c-explorer__close u-hidden"
className="c-explorer__close"
dialogTrigger={false}
href="#"
icon=""
@ -322,7 +322,7 @@ exports[`ExplorerPanel general rendering renders 1`] = `
>
<Button
accessibleLabel={null}
className="c-explorer__close u-hidden"
className="c-explorer__close"
dialogTrigger={false}
href="#"
icon=""