From 871c09fd2e714d013b7fc2a5282380fff047302c Mon Sep 17 00:00:00 2001
From: CheesyPhoenix <30808373+CheesyPhoenix@users.noreply.github.com>
Date: Fri, 20 Oct 2023 11:07:21 +0200
Subject: [PATCH] Ensure the sidebar's explorer does not trigger action-button
of current view
Fixes #11037
Co-authored-by: Christer Jensen <chr.code@gmail.com>
---
CHANGELOG.txt | 1 +
CONTRIBUTORS.md | 1 +
client/scss/components/_dropdown.legacy.scss | 4 ++--
docs/releases/5.3.md | 1 +
4 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/CHANGELOG.txt b/CHANGELOG.txt
index be1485d2fe..bf39b0228c 100644
--- a/CHANGELOG.txt
+++ b/CHANGELOG.txt
@@ -6,6 +6,7 @@ Changelog
* Fix: Update system check for overwriting storage backends to recognise the `STORAGES` setting introduced in Django 4.2 (phijma-leukeleu)
* Fix: Prevent password change form from raising a validation error when browser autocomplete fills in the "Old password" field (Chiemezuo Akujobi)
+ * Fix: Ensure that the legacy dropdown options, when closed, do not get accidentally clicked by other interactions wide viewports (CheesyPhoenix)
* Maintenance: Update BeautifulSoup upper bound to 4.12.x (scott-8)
* Maintenance: Migrate initialization of classes (such as `body.ready`) from multiple JavaScript implementations to one Stimulus controller `w-init` (Chiemezuo Akujobi)
diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md
index 1b085f874f..42faac71d4 100644
--- a/CONTRIBUTORS.md
+++ b/CONTRIBUTORS.md
@@ -755,6 +755,7 @@
* Chinedu Ihedioha
* scott-8
* phijma-leukeleu
+* CheesyPhoenix
## Translators
diff --git a/client/scss/components/_dropdown.legacy.scss b/client/scss/components/_dropdown.legacy.scss
index 5fa8e9c776..790f969ca0 100644
--- a/client/scss/components/_dropdown.legacy.scss
+++ b/client/scss/components/_dropdown.legacy.scss
@@ -33,9 +33,9 @@
position: absolute;
overflow: hidden;
top: 100%;
- inset-inline-start: -2000px;
z-index: 500;
opacity: 0;
+ pointer-events: none;
li {
float: none;
@@ -127,7 +127,7 @@
&.open ul {
box-shadow: 0 3px 3px 0 theme('colors.black-20');
opacity: 1;
- inset-inline-start: 0;
+ pointer-events: initial;
display: block;
}
diff --git a/docs/releases/5.3.md b/docs/releases/5.3.md
index 5337354e83..5687685611 100644
--- a/docs/releases/5.3.md
+++ b/docs/releases/5.3.md
@@ -20,6 +20,7 @@ depth: 1
* Update system check for overwriting storage backends to recognise the `STORAGES` setting introduced in Django 4.2 (phijma-leukeleu)
* Prevent password change form from raising a validation error when browser autocomplete fills in the "Old password" field (Chiemezuo Akujobi)
+ * Ensure that the legacy dropdown options, when closed, do not get accidentally clicked by other interactions wide viewports (CheesyPhoenix)
### Documentation