From 47af24381e4c1e649342812efd8294b3059a3597 Mon Sep 17 00:00:00 2001 From: Sage Abdullah Date: Fri, 15 Sep 2023 10:29:17 +0100 Subject: [PATCH] Do not use super().get_urlpatterns in ModelViewSet and SnippetViewSet In ModelViewSet, this doesn't do anything as the base ViewSet class returns an empty list. In SnippetViewSet, this causes the ModelViewSet's urlpatterns to be carried over, resulting in duplicate URLs that we do not want. --- wagtail/admin/viewsets/model.py | 2 +- wagtail/snippets/views/snippets.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/wagtail/admin/viewsets/model.py b/wagtail/admin/viewsets/model.py index d140a91f29..429cf402d2 100644 --- a/wagtail/admin/viewsets/model.py +++ b/wagtail/admin/viewsets/model.py @@ -409,7 +409,7 @@ class ModelViewSet(ViewSet): ReferenceIndex.register_model(self.model) def get_urlpatterns(self): - return super().get_urlpatterns() + [ + return [ path("", self.index_view, name="index"), path("results/", self.index_results_view, name="index_results"), path("new/", self.add_view, name="add"), diff --git a/wagtail/snippets/views/snippets.py b/wagtail/snippets/views/snippets.py index 651625730a..0fd2132214 100644 --- a/wagtail/snippets/views/snippets.py +++ b/wagtail/snippets/views/snippets.py @@ -1255,7 +1255,7 @@ class SnippetViewSet(ModelViewSet): ) def get_urlpatterns(self): - urlpatterns = super().get_urlpatterns() + [ + urlpatterns = [ path("", self.index_view, name="list"), path("results/", self.index_results_view, name="list_results"), path("add/", self.add_view, name="add"),