Prevent lowercase conversions of spreadsheet export column headers

pull/10827/head
Sage Abdullah 2023-08-30 15:14:08 +01:00
rodzic dfa84e835d
commit 391cdb52ff
Nie znaleziono w bazie danych klucza dla tego podpisu
ID klucza GPG: EB1A33CC51CC0217
4 zmienionych plików z 13 dodań i 12 usunięć

Wyświetl plik

@ -126,7 +126,7 @@ class TestLockedPagesView(WagtailTestUtils, TestCase):
self.assertEqual(response.status_code, 200)
data_lines = response.getvalue().decode().split("\n")
self.assertEqual(
data_lines[0], "Title,Updated,Status,Type,Locked At,Locked By\r"
data_lines[0], "Title,Updated,Status,Type,Locked at,Locked by\r"
)
if settings.USE_TZ:
self.assertEqual(
@ -163,7 +163,7 @@ class TestLockedPagesView(WagtailTestUtils, TestCase):
cell_array = [[cell.value for cell in row] for row in worksheet.rows]
self.assertEqual(
cell_array[0],
["Title", "Updated", "Status", "Type", "Locked At", "Locked By"],
["Title", "Updated", "Status", "Type", "Locked at", "Locked by"],
)
self.assertEqual(
cell_array[1],

Wyświetl plik

@ -506,7 +506,7 @@ class TestListExport(WagtailTestUtils, TestCase):
)
data_lines = response.getvalue().decode().strip().split("\r\n")
self.assertEqual(data_lines[0], "Name,Launch date,Is Cool")
self.assertEqual(data_lines[0], "Name,Launch date,Is cool")
self.assertEqual(data_lines[1], "Catso,2010-06-18,False")
self.assertEqual(data_lines[2], "LEVEL,2010-06-18,True")
self.assertEqual(data_lines[3], "Racecar,1995-11-19,None")
@ -526,7 +526,7 @@ class TestListExport(WagtailTestUtils, TestCase):
)
data_lines = response.getvalue().decode().strip().split("\r\n")
self.assertEqual(data_lines[0], "Name,Launch date,Is Cool")
self.assertEqual(data_lines[0], "Name,Launch date,Is cool")
self.assertEqual(data_lines[1], "Catso,2010-06-18,False")
self.assertEqual(data_lines[2], "LEVEL,2010-06-18,True")
self.assertEqual(len(data_lines), 3)
@ -544,7 +544,7 @@ class TestListExport(WagtailTestUtils, TestCase):
workbook_data = response.getvalue()
worksheet = load_workbook(filename=BytesIO(workbook_data)).active
cell_array = [[cell.value for cell in row] for row in worksheet.rows]
self.assertEqual(cell_array[0], ["Name", "Launch date", "Is Cool"])
self.assertEqual(cell_array[0], ["Name", "Launch date", "Is cool"])
self.assertEqual(cell_array[1], ["Catso", datetime.date(2010, 6, 18), "False"])
self.assertEqual(cell_array[2], ["LEVEL", datetime.date(2010, 6, 18), "True"])
self.assertEqual(
@ -568,7 +568,7 @@ class TestListExport(WagtailTestUtils, TestCase):
workbook_data = response.getvalue()
worksheet = load_workbook(filename=BytesIO(workbook_data)).active
cell_array = [[cell.value for cell in row] for row in worksheet.rows]
self.assertEqual(cell_array[0], ["Name", "Launch date", "Is Cool"])
self.assertEqual(cell_array[0], ["Name", "Launch date", "Is cool"])
self.assertEqual(cell_array[1], ["Catso", datetime.date(2010, 6, 18), "False"])
self.assertEqual(cell_array[2], ["LEVEL", datetime.date(2010, 6, 18), "True"])
self.assertEqual(len(cell_array), 3)

Wyświetl plik

@ -10,6 +10,7 @@ from django.utils import timezone
from django.utils.dateformat import Formatter
from django.utils.encoding import force_str
from django.utils.formats import get_format
from django.utils.text import capfirst
from openpyxl import Workbook
from openpyxl.cell import WriteOnlyCell
@ -225,7 +226,7 @@ class SpreadsheetExportMixin:
if heading_override:
return force_str(heading_override)
try:
return force_str(label_for_field(field, queryset.model)).title()
return capfirst(force_str(label_for_field(field, queryset.model)))
except (AttributeError, FieldDoesNotExist):
return force_str(field)

Wyświetl plik

@ -774,7 +774,7 @@ class TestListExport(BaseSnippetViewSetTests):
data_lines = response.getvalue().decode().split("\n")
self.assertEqual(
data_lines[0],
"Text,Country Code,Custom Foo Column,Some Date,First Published At\r",
"Text,Country code,Custom FOO column,Some date,First published at\r",
)
self.assertEqual(
data_lines[1],
@ -801,10 +801,10 @@ class TestListExport(BaseSnippetViewSetTests):
cell_array[0],
[
"Text",
"Country Code",
"Custom Foo Column",
"Some Date",
"First Published At",
"Country code",
"Custom FOO column",
"Some date",
"First published at",
],
)
self.assertEqual(