From 265d4baaf2f3dd5e31fb0bee4566d79ee1caef49 Mon Sep 17 00:00:00 2001 From: Samir Shah Date: Mon, 18 Jun 2018 14:23:27 +0300 Subject: [PATCH] Add a title attribute to the image displayed in an ImageChooserBlock. --- CHANGELOG.txt | 1 + docs/releases/2.3.rst | 1 + wagtail/images/static_src/wagtailimages/js/image-chooser.js | 3 ++- .../images/templates/wagtailimages/widgets/image_chooser.html | 2 +- 4 files changed, 5 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.txt b/CHANGELOG.txt index 682312c4c6..ba11a1205e 100644 --- a/CHANGELOG.txt +++ b/CHANGELOG.txt @@ -10,6 +10,7 @@ Changelog * EmbedBlock now validates against recognised embed providers on save (Bertrand Bordage) * Made cache control headers on Wagtail admin consistent with Django admin (Tomasz Knapik) * Notification emails now include an "Auto-Submitted: auto-generated" header (Dan Braghis) + * Image chooser panels now show alt text as title (Samir Shah) * Fix: Respect next param on login (Loic Teixeira) * Fix: InlinePanel now handles relations that specify a related_query_name (Aram Dulyan) * Fix: before_delete_page / after_delete_page hooks now run within the same database transaction as the page deletion (Tomasz Knapik) diff --git a/docs/releases/2.3.rst b/docs/releases/2.3.rst index 379348eba1..59ef403a9c 100644 --- a/docs/releases/2.3.rst +++ b/docs/releases/2.3.rst @@ -27,6 +27,7 @@ Other features * EmbedBlock now validates against recognised embed providers on save (Bertrand Bordage) * Made cache control headers on Wagtail admin consistent with Django admin (Tomasz Knapik) * Notification emails now include an "Auto-Submitted: auto-generated" header (Dan Braghis) + * Image chooser panels now show alt text as title (Samir Shah) Bug fixes diff --git a/wagtail/images/static_src/wagtailimages/js/image-chooser.js b/wagtail/images/static_src/wagtailimages/js/image-chooser.js index 866ad56f5f..b39e72fa0b 100644 --- a/wagtail/images/static_src/wagtailimages/js/image-chooser.js +++ b/wagtail/images/static_src/wagtailimages/js/image-chooser.js @@ -15,7 +15,8 @@ function createImageChooser(id) { src: imageData.preview.url, width: imageData.preview.width, height: imageData.preview.height, - alt: imageData.title + alt: imageData.title, + title: imageData.title }); chooserElement.removeClass('blank'); editLink.attr('href', imageData.edit_link); diff --git a/wagtail/images/templates/wagtailimages/widgets/image_chooser.html b/wagtail/images/templates/wagtailimages/widgets/image_chooser.html index 7072b4b935..96f007baac 100644 --- a/wagtail/images/templates/wagtailimages/widgets/image_chooser.html +++ b/wagtail/images/templates/wagtailimages/widgets/image_chooser.html @@ -6,7 +6,7 @@ {% block chosen_state_view %}
{% if image %} - {% image image max-165x165 class="show-transparency" %} + {% image image max-165x165 class="show-transparency" title=image.title %} {% else %} {% endif %}