Remove unused search-bar and button-filter styles (#9812)

- Remove unneeded search-bar class from templates
- Remove _file_field_as_li template with unneeded overrides
- Remove unused search-bar styles

CHANGELOG.txt

@@ -93,6 +93,7 @@ Changelog
  * Maintenance: Refactor submit-on-change search filters for image and document listings to use Stimulus (LB (Ben) Johnston)
  * Maintenance: Switch userbar to initialise a Web Component to avoid styling clashes (Albina Starykova)
  * Maintenance: Refactor userbar stylesheets to use the same CSS loading as the rest of the admin (Albina Starykova)
+ * Maintenance: Remove unused search-bar and button-filter styles (Thibaud Colas)
 
 
 4.1.2 (xx.xx.xxxx) - IN DEVELOPMENT

client/scss/components/_search-bar.scss

@@ -1,11 +0,0 @@
-// search-bars
-.search-bar {
-  .required .field > label:after {
-    display: none;
-  }
-
-  .button-filter {
-    height: 2.71em;
-    border-color: transparent;
-  }
-}

client/scss/core.scss

@@ -143,7 +143,6 @@ These are classes for components.
 @import 'components/messages.capability';
 @import 'components/messages.status';
 @import 'components/header';
-@import 'components/search-bar';
 @import 'components/progressbar';
 @import 'components/summary';
 @import 'components/whats-new';

docs/releases/4.2.md

@@ -118,6 +118,7 @@ This feature was developed by Sage Abdullah.
  * Update `tsconfig` to better support modern TypeScript development and clean up some code quality issues via Eslint (Loveth Omokaro)
  * Switch userbar to initialise a Web Component to avoid styling clashes (Albina Starykova)
  * Refactor userbar stylesheets to use the same CSS loading as the rest of the admin (Albina Starykova)
+ * Remove unused search-bar and button-filter styles (Thibaud Colas)
 
 ## Upgrade considerations
 

wagtail/admin/templates/wagtailadmin/generic/chooser/chooser.html

@@ -30,7 +30,7 @@
 
             {% block filter_form %}
                 {% if filter_form.fields %}
-                    <form data-chooser-modal-search class="search-bar" action="{{ results_url }}" method="GET" novalidate>
+                    <form data-chooser-modal-search action="{{ results_url }}" method="GET" novalidate>
                         {% for field in filter_form.hidden_fields %}{{ field }}{% endfor %}
 
                         {% if filter_form.visible_fields %}

wagtail/admin/templates/wagtailadmin/workflows/task_chooser/chooser.html

@@ -30,7 +30,7 @@
                 aria-labelledby="tab-label-existing"
                 hidden
             >
-                <form class="task-search search-bar" action="{% url 'wagtailadmin_workflows:task_chooser_results' %}" method="GET" novalidate>
+                <form class="task-search" action="{% url 'wagtailadmin_workflows:task_chooser_results' %}" method="GET" novalidate>
                     <ul class="fields">
                         {% for field in search_form %}
                             {% include "wagtailadmin/shared/field_as_li.html" with field=field %}
@@ -45,7 +45,7 @@
     </div>
 {% else %}
     <div class="nice-padding">
-        <form class="task-search search-bar" action="{% url 'wagtailadmin_workflows:task_chooser_results' %}" method="GET" novalidate>
+        <form class="task-search" action="{% url 'wagtailadmin_workflows:task_chooser_results' %}" method="GET" novalidate>
             <ul class="fields">
                 {% for field in search_form %}
                     {% include "wagtailadmin/shared/field_as_li.html" with field=field %}

wagtail/documents/templates/wagtaildocs/documents/_file_field_as_li.html

@@ -1,4 +0,0 @@
-{% load wagtailadmin_tags %}
-<li class="{% if field.field.required %}required{% endif %} {% if field.errors %}error{% endif %}">
-    {% include "wagtaildocs/documents/_file_field.html" %}
-</li>

wagtail/documents/templates/wagtaildocs/documents/edit.html

@@ -37,7 +37,7 @@
                 <ul class="fields">
                     {% for field in form %}
                         {% if field.name == 'file' %}
-                            {% include "wagtaildocs/documents/_file_field_as_li.html" %}
+                            <li>{% include "wagtaildocs/documents/_file_field.html" %}</li>
                         {% elif field.is_hidden %}
                             {{ field }}
                         {% else %}

wagtail/documents/templates/wagtaildocs/documents/index.html

@@ -29,7 +29,7 @@
 
     <div class="nice-padding">
         {% if collections %}
-            <form class="image-search search-bar" action="{% url 'wagtaildocs:index' %}" method="GET" novalidate>
+            <form class="image-search" action="{% url 'wagtaildocs:index' %}" method="GET" novalidate>
                 <ul class="fields">
                     <li>{% include "wagtailadmin/shared/collection_chooser.html" %}</li>
                 </ul>

wagtail/images/templates/wagtailimages/chooser/chooser.html

@@ -2,7 +2,7 @@
 {% load i18n wagtailadmin_tags %}
 
 {% block filter_form %}
-    <form data-chooser-modal-search class="search-bar" action="{{ results_url }}{% if will_select_format %}?select_format=true{% endif %}" method="GET" autocomplete="off" novalidate>
+    <form data-chooser-modal-search action="{{ results_url }}{% if will_select_format %}?select_format=true{% endif %}" method="GET" autocomplete="off" novalidate>
         <ul class="fields">
             {% for field in filter_form %}
                 {% include "wagtailadmin/shared/field_as_li.html" with field=field %}

wagtail/images/templates/wagtailimages/images/index.html

@@ -31,7 +31,7 @@
     {% endif %}
 
     <div class="nice-padding">
-        <form class="image-search search-bar" action="{% url 'wagtailimages:index' %}" method="GET" novalidate>
+        <form class="image-search" action="{% url 'wagtailimages:index' %}" method="GET" novalidate>
             {% if current_tag %}
                 <input type="hidden" name="tag" value="{{ current_tag }}" />
             {% endif %}

wagtail/search/templates/wagtailsearch/queries/chooser/chooser.html

@@ -3,7 +3,7 @@
 {% include "wagtailadmin/shared/header.html" with title=pop_str %}
 
 <div class="nice-padding">
-    <form class="query-search search-bar full-width" action="{% url 'wagtailsearch_admin:queries_chooserresults' %}" method="GET" autocomplete="off" novalidate>
+    <form class="query-search full-width" action="{% url 'wagtailsearch_admin:queries_chooserresults' %}" method="GET" autocomplete="off" novalidate>
         <ul class="fields">
             {% for field in searchform %}
                 {% include "wagtailadmin/shared/field_as_li.html" with field=field %}