refactored for optimized parent-by-type detection

pull/89/head
jmoenig 2019-02-07 09:54:22 +01:00
rodzic 22e12c834a
commit affbe2f437
5 zmienionych plików z 15 dodań i 12 usunięć

Wyświetl plik

@ -43,6 +43,7 @@
* Objects: tweaked spec for settings getter
* Blocks: improved dropping command blocks into reporter rings
* Morphic: simplified and optimized Node>>parentThatIsA / parentThatIsAnyOf
* Blocks, Lists, Tables: refactored for optimized parent-by-type detection
### 2019-02-06
* Blocks, BYOB: refactored custom block input options and drop-down menus

Wyświetl plik

@ -6,14 +6,14 @@
<link rel="shortcut icon" href="src/favicon.ico">
<script type="text/javascript" src="src/morphic.js?version=2019-02-07"></script>
<script type="text/javascript" src="src/widgets.js?version=2018-10-02"></script>
<script type="text/javascript" src="src/blocks.js?version=2019-02-06"></script>
<script type="text/javascript" src="src/blocks.js?version=2019-02-07"></script>
<script type="text/javascript" src="src/threads.js?version=2019-01-28"></script>
<script type="text/javascript" src="src/objects.js?version=2019-02-07"></script>
<script type="text/javascript" src="src/gui.js?version=2019-02-06"></script>
<script type="text/javascript" src="src/paint.js?version=2018-10-02"></script>
<script type="text/javascript" src="src/lists.js?version=2019-01-10"></script>
<script type="text/javascript" src="src/lists.js?version=2019-02-07"></script>
<script type="text/javascript" src="src/byob.js?version=2019-02-06"></script>
<script type="text/javascript" src="src/tables.js?version=2018-10-02"></script>
<script type="text/javascript" src="src/tables.js?version=2019-02-07"></script>
<script type="text/javascript" src="src/symbols.js?version=2019-01-14"></script>
<script type="text/javascript" src="src/sketch.js?version=2018-10-02"></script>
<script type="text/javascript" src="src/xml.js?version=2018-11-12"></script>

Wyświetl plik

@ -148,7 +148,7 @@ CustomCommandBlockMorph, SymbolMorph, ToggleButtonMorph, DialMorph*/
// Global stuff ////////////////////////////////////////////////////////
modules.blocks = '2019-February-06';
modules.blocks = '2019-February-07';
var SyntaxElementMorph;
var BlockMorph;
@ -1966,8 +1966,10 @@ SyntaxElementMorph.prototype.fixLayout = function (silently) {
}
}
if (this.width() !== initialExtent.x) {
affected = this.parentThatIsAnyOf(
[ReporterBlockMorph, CommandSlotMorph, RingCommandSlotMorph]
affected = this.parentThatIsA(
ReporterBlockMorph,
CommandSlotMorph,
RingCommandSlotMorph
);
if (affected) {
affected.fixLayout();

Wyświetl plik

@ -62,7 +62,7 @@ CellMorph, ArrowMorph, MenuMorph, snapEquals, Morph, isNil, localize, isString,
MorphicPreferences, TableDialogMorph, SpriteBubbleMorph, SpeechBubbleMorph,
TableFrameMorph, TableMorph, Variable, isSnapObject*/
modules.lists = '2019-January-10';
modules.lists = '2019-February-07';
var List;
var ListWatcherMorph;
@ -924,11 +924,11 @@ ListWatcherMorph.prototype.userMenu = function () {
};
ListWatcherMorph.prototype.showTableView = function () {
var view = this.parentThatIsAnyOf([
var view = this.parentThatIsA(
SpriteBubbleMorph,
SpeechBubbleMorph,
CellMorph
]);
);
if (!view) {return; }
if (view instanceof SpriteBubbleMorph) {
view.changed();

Wyświetl plik

@ -70,7 +70,7 @@ SpriteMorph, Context, Costume, ArgMorph, BlockEditorMorph, SymbolMorph,
SyntaxElementMorph, MenuMorph, SpriteBubbleMorph, SpeechBubbleMorph, Sound,
CellMorph, ListWatcherMorph, isNil, BoxMorph, Variable, isSnapObject*/
modules.tables = '2017-September-01';
modules.tables = '2019-February-07';
var Table;
var TableCellMorph;
@ -1059,11 +1059,11 @@ TableMorph.prototype.openInDialog = function () {
};
TableMorph.prototype.showListView = function () {
var view = this.parentThatIsAnyOf([
var view = this.parentThatIsA(
SpriteBubbleMorph,
SpeechBubbleMorph,
CellMorph
]);
);
if (!view) {return; }
if (view instanceof SpriteBubbleMorph) {
view.changed();