fixed #2510 (disabled direct editing of list watchers for non-literal typed lists)

such as costumes, avoids unloadable projects

HISTORY.md

@@ -14,11 +14,15 @@
     * loading a project that fires STOP ALL from a WHEN hat block no longer "hangs" Snap
     * fixed pixel-manipulation distortions on newly imported hi-res images
     * assert that dimensions given for STRETCH are finite numbers (avoid crash)
+    * disabled direct editing of list watchers for non-literal typed lists (such as costumes, avoids unloadable projects)
     * fixed occasional "dead clicks" on buttons and menu items
 * **Translation Updates:**
     * English
     * German
 
+### 2019-10-23
+* lists: disabled direct editing of list watchers for non-literal typed lists (such as costumes)
+
 ### 2019-10-22
 * morphic: url-clicking fix by @brollb, updated morphic documentation
 * pushed dev version to release-candidate status

snap.html

@@ -11,7 +11,7 @@
         <script type="text/javascript" src="src/objects.js?version=2019-10-22"></script>
         <script type="text/javascript" src="src/gui.js?version=2019-10-22"></script>
         <script type="text/javascript" src="src/paint.js?version=2019-06-27"></script>
-        <script type="text/javascript" src="src/lists.js?version=2019-07-01"></script>
+        <script type="text/javascript" src="src/lists.js?version=2019-10-23"></script>
         <script type="text/javascript" src="src/byob.js?version=2019-07-24"></script>
         <script type="text/javascript" src="src/tables.js?version=2019-06-27"></script>
         <script type="text/javascript" src="src/symbols.js?version=2019-06-27"></script>

src/lists.js

@@ -60,9 +60,9 @@
 Color, Point, WatcherMorph, StringMorph, SpriteMorph, ScrollFrameMorph,
 CellMorph, ArrowMorph, MenuMorph, snapEquals, Morph, isNil, localize, isString,
 MorphicPreferences, TableDialogMorph, SpriteBubbleMorph, SpeechBubbleMorph,
-TableFrameMorph, TableMorph, Variable, isSnapObject, Costume*/
+TableFrameMorph, TableMorph, Variable, isSnapObject, Costume, contains*/
 
-modules.lists = '2019-July-01';
+modules.lists = '2019-October-23';
 
 var List;
 var ListWatcherMorph;
@@ -657,6 +657,11 @@ ListWatcherMorph.prototype.init = function (list, parentCell) {
     this.plusButton.drawNew();
     this.plusButton.fixLayout();
 
+    // disable direct editing for non-literal typed lists (such as costumes):
+    if (this.list.type && !contains(['text', 'number'], this.list.type)) {
+        this.plusButton.hide();
+    }
+
     ListWatcherMorph.uber.init.call(
         this,
         SyntaxElementMorph.prototype.rounding,