From 2cb904d2bb6f23708297aed13a414f91e29d663f Mon Sep 17 00:00:00 2001 From: jmoenig Date: Tue, 26 Nov 2013 10:02:38 +0100 Subject: [PATCH] fixed #207 (stricter comparison of strings vs. numbers) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Some intentional edge cases remain, such as empty string equals zero and disregarding trailing / leading blanks. Please don’t nitpick and spare me the fundamentalism, plus discussing whether discussing the discussing qualifies as fundamentalism :-) --- history.txt | 1 + threads.js | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/history.txt b/history.txt index 050960ac..1618601a 100755 --- a/history.txt +++ b/history.txt @@ -2010,3 +2010,4 @@ ______ 132226 ------ * Cloud: fixed #125 (encode email address when signing up), thanks, Nathan! +* Threads: fixed #207 (stricter comparison of strings vs. numbers). Some edge cases remain, such as empty string equals zero and disregarding trailing / leading blanks. These are intentional. Please don’t nitpick and spare me the fundamentalism :-) diff --git a/threads.js b/threads.js index 9b347f92..48d73ca8 100644 --- a/threads.js +++ b/threads.js @@ -83,7 +83,7 @@ ArgLabelMorph, localize, XML_Element, hex_sha512*/ // Global stuff //////////////////////////////////////////////////////// -modules.threads = '2013-October-17'; +modules.threads = '2013-November-26'; var ThreadManager; var Process; @@ -98,8 +98,8 @@ function snapEquals(a, b) { } return false; } - var x = parseFloat(a), - y = parseFloat(b); + var x = +a; + y = +b; if (isNaN(x) || isNaN(y)) { x = a; y = b;